Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-18 Thread Patrick McHardy
Am 14.02.2011 17:52, schrieb Patrick McHardy: Am 14.02.2011 17:48, schrieb Eric Dumazet: I am not sure, but I guess nf_reinject() needs a fix too ;) I agree. That one looks uglier though, I guess we'll have to iterate through all hooks to note the previous one. How about this? Unfortunately

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-18 Thread Eric Dumazet
Le vendredi 18 février 2011 à 19:37 +0100, Patrick McHardy a écrit : Am 14.02.2011 17:52, schrieb Patrick McHardy: Am 14.02.2011 17:48, schrieb Eric Dumazet: I am not sure, but I guess nf_reinject() needs a fix too ;) I agree. That one looks uglier though, I guess we'll have to iterate

Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Avi Kivity
We see severe memory corruption in kvm while used in conjunction with bridge/netfilter. Enabling slab debugging points the finger at a netfilter chain invoked from the bridge code. Can someone take a look? https://bugzilla.kernel.org/show_bug.cgi?id=27052 -- error compiling committee.c: too

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Eric Dumazet
Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit : We see severe memory corruption in kvm while used in conjunction with bridge/netfilter. Enabling slab debugging points the finger at a netfilter chain invoked from the bridge code. Can someone take a look?

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Jan Engelhardt
On Monday 2011-02-14 16:11, Eric Dumazet wrote: Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit : We see severe memory corruption in kvm while used in conjunction with bridge/netfilter. Enabling slab debugging points the finger at a netfilter chain invoked from the bridge code.

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Eric Dumazet
Le lundi 14 février 2011 à 16:18 +0100, Jan Engelhardt a écrit : On Monday 2011-02-14 16:11, Eric Dumazet wrote: Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit : We see severe memory corruption in kvm while used in conjunction with bridge/netfilter. Enabling slab debugging

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Patrick McHardy
Am 14.02.2011 16:50, schrieb Eric Dumazet: Le lundi 14 février 2011 à 16:18 +0100, Jan Engelhardt a écrit : On Monday 2011-02-14 16:11, Eric Dumazet wrote: Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit : We see severe memory corruption in kvm while used in conjunction with

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Eric Dumazet
Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit : Am 14.02.2011 16:50, schrieb Eric Dumazet: Le lundi 14 février 2011 à 16:18 +0100, Jan Engelhardt a écrit : On Monday 2011-02-14 16:11, Eric Dumazet wrote: Le lundi 14 février 2011 à 16:58 +0200, Avi Kivity a écrit : We

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Patrick McHardy
Am 14.02.2011 17:29, schrieb Eric Dumazet: Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit : Also, I wonder if RCU rules are respected in nf_iterate(). For example this line is really suspicious : *i = (*i)-prev; Yeah, that definitely looks wrong. How about this instead?

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Eric Dumazet
Le lundi 14 février 2011 à 17:37 +0100, Patrick McHardy a écrit : Am 14.02.2011 17:29, schrieb Eric Dumazet: Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit : Also, I wonder if RCU rules are respected in nf_iterate(). For example this line is really suspicious : *i =

Re: Possible netfilter-related memory corruption in 2.6.37

2011-02-14 Thread Patrick McHardy
Am 14.02.2011 17:48, schrieb Eric Dumazet: Le lundi 14 février 2011 à 17:37 +0100, Patrick McHardy a écrit : Am 14.02.2011 17:29, schrieb Eric Dumazet: Le lundi 14 février 2011 à 17:24 +0100, Patrick McHardy a écrit : Also, I wonder if RCU rules are respected in nf_iterate(). For example this