[kvm-devel] [PATCH] [RESEND] libkvm: NULL pointer dereference in kvm_destroy_phys_mem as used in kvm-56

2007-12-18 Thread Carlo Marcelo Arenas Belon
The following patch eliminates the uninitialized mem pointer, using instead the corresponding entry from the slots array to fix : libkvm.c:580: warning: 'mem' is used uninitialized in this function Also changes the formatting type for phys_addr to long to prevent : libkvm.c:581: warning:

[kvm-devel] [ kvm-Bugs-1852938 ] Emulation failure with VM memory size = 1G

2007-12-18 Thread SourceForge.net
Bugs item #1852938, was opened at 2007-12-18 15:03 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=1852938group_id=180599 Please note that this message will contain a full copy of

Re: [kvm-devel] [kvm-ppc-devel] Current e500 kvm guest kernel booting log

2007-12-18 Thread Christian Ehrhardt
Hollis already pointed me to the mkasm-values patches which are the continuation of the mkasm-offset discussion on lkml Hollis last patch was based on. As stated before by Xiantao and Hollis in this thread the mkasm-value patches are not yet accepted upstream, but may be useful for us. Based

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-18 Thread Dor Laor
Cam Macdonell wrote: Dor Laor wrote: Cam Macdonell wrote: Dor Laor wrote: Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: --- a/drivers/net/virtio_net.c +++

[kvm-devel] [RFC] external module: compatibility with older kernels (SMP and non SMP)

2007-12-18 Thread Carlo Marcelo Arenas Belon
The following patch (which is composed of 3 different patches from a series) has been validated to solve compilation issues observed with kvm-56 in x86 with kernels older than 2.6.21 and are posted here for testing and debate. The main points accomplished (in the same sequence that the snippets)

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-18 Thread Dor Laor
Rusty Russell wrote: On Wednesday 12 December 2007 23:54:00 Dor Laor wrote: commit 763769621d271d92204ed27552d75448587c1ac0 Author: Dor Laor [EMAIL PROTECTED] Date: Wed Dec 12 14:52:00 2007 +0200 [virtio-net][PATCH] Don't arm tx hrtimer with a constant 50us each transmit The

Re: [kvm-devel] [PATCH][UPDATE] kvm-userspace: sync icache for morearchitectures

2007-12-18 Thread Christian Ehrhardt
Hollis Blanchard wrote: On Fri, 2007-12-14 at 10:07 +0100, Christian Ehrhardt wrote: Hollis Blanchard wrote: A comment to explain why the icache needs flushing only in the KVM case would be useful. Other than that I'm fine with it. Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] AFAIK

[kvm-devel] [PATCH][UPDATE] kvm-userspace: sync icache for more architectures

2007-12-18 Thread Christian Ehrhardt
Subject: [PATCH][UPDATE] kvm-userspace: sync icache for more architectures From: Christian Ehrhardt [EMAIL PROTECTED] A ia64 patch introduced kvm_sync_icache within a ifdef __ia64__, but the concept of split caches is not bound to ia64. This patch replaces the the call to kvm_synch_icache by

[kvm-devel] [PATCH][UPDATE] kvm-userspace: simplify mmio callback

2007-12-18 Thread Christian Ehrhardt
Subject: [PATCH][UPDATE] kvm-userspace: simplify mmio callback From: Christian Ehrhardt [EMAIL PROTECTED] Merging the read[bwlq]/write[bwlq] callback callback pointers to mmio_read/write functions simplifies the callback interface. On the qemu side it now uses the cpu_physical_memory_rw

[kvm-devel] [RFC] concurrent guest walker and instruction emulation

2007-12-18 Thread Marcelo Tosatti
Hi, The following is an improvement on top of an earlier patch by Izik. It increases pagefault scalability for SMP guests by allowing concurrent guest walking, allocation and instruction emulation on the fault path. The test being used is pft, which starts a number of threads allocating and

Re: [kvm-devel] [RFC] concurrent guest walker and instruction emulation

2007-12-18 Thread Marcelo Tosatti
On Tue, Dec 18, 2007 at 08:26:14AM -0500, Marcelo Tosatti wrote: + page = __gfn_to_page(vcpu-kvm, gpa PAGE_SHIFT); + spin_lock(vcpu-kvm-mmu_lock); kvm_mmu_pte_write(vcpu, gpa, val, bytes); This should be the gfn which the new pte points to, not its address.

Re: [kvm-devel] [RFC] concurrent guest walker and instruction emulation

2007-12-18 Thread Izik Eidus
On Tue, 2007-12-18 at 08:26 -0500, Marcelo Tosatti wrote: Hi, The following is an improvement on top of an earlier patch by Izik. It i would say MUCH improvement :) increases pagefault scalability for SMP guests by allowing concurrent guest walking, allocation and instruction emulation on

Re: [kvm-devel] merge kvm_flush_remote_tlbs when modifing shadow pte

2007-12-18 Thread Avi Kivity
Dong, Eddie wrote: Dong, Eddie wrote: host side TLB flush can be merged together if multiple spte need to be write-protected. Signed-off-by: Yaozu (Eddie) Dong [EMAIL PROTECTED] diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c index 92ac0d1..749db46 100644 --- a/drivers/kvm/mmu.c

Re: [kvm-devel] [RFC] concurrent guest walker and instruction emulation

2007-12-18 Thread Avi Kivity
Marcelo Tosatti wrote: Hi, The following is an improvement on top of an earlier patch by Izik. It increases pagefault scalability for SMP guests by allowing concurrent guest walking, allocation and instruction emulation on the fault path. The test being used is pft, which starts a number

[kvm-devel] [ANNOUNCE] kvm-57 release

2007-12-18 Thread Avi Kivity
The major focus for this release is a qemu-cvs merge, which brings many new features, some introduced by kvm developers. Examples are improved usb support and the new -drive qemu option. While we've tested this carefully, this is a big merge so please handle this release with care and

Re: [kvm-devel] KVM Test result, kernel 5ca24d9.., userspace 120e0c8..

2007-12-18 Thread Avi Kivity
Zhao, Yunfeng wrote: Save/restore still passes on IA32e host but fails on IA32 host. This is now fixed. -- error compiling committee.c: too many arguments to function - SF.Net email is sponsored by: Check out the

Re: [kvm-devel] [PATCH] [RESEND] libkvm: NULL pointer dereference in kvm_destroy_phys_mem as used in kvm-56

2007-12-18 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: The following patch eliminates the uninitialized mem pointer, using instead the corresponding entry from the slots array to fix : libkvm.c:580: warning: 'mem' is used uninitialized in this function Also changes the formatting type for phys_addr to long to

Re: [kvm-devel] PATCH vmx.c: add printk_ratelimit in vmx_intr_assist

2007-12-18 Thread Avi Kivity
Ryan Harper wrote: * Ryan Harper [EMAIL PROTECTED] [2007-12-14 09:36]: * Avi Kivity [EMAIL PROTECTED] [2007-12-14 08:49]: Ryan Harper wrote: Add printk_ratelimit check in front of printk. This prevents spamming of the message during 32-bit ubuntu 6.06server install.

Re: [kvm-devel] [RFC] external module: compatibility with older kernels (SMP and non SMP)

2007-12-18 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: The following patch (which is composed of 3 different patches from a series) has been validated to solve compilation issues observed with kvm-56 in x86 with kernels older than 2.6.21 and are posted here for testing and debate. The main points accomplished (in

Re: [kvm-devel] [PATCH][UPDATE] kvm-userspace: sync icache for more architectures

2007-12-18 Thread Avi Kivity
Christian Ehrhardt wrote: Subject: [PATCH][UPDATE] kvm-userspace: sync icache for more architectures From: Christian Ehrhardt [EMAIL PROTECTED] A ia64 patch introduced kvm_sync_icache within a ifdef __ia64__, but the concept of split caches is not bound to ia64. This patch replaces the the

[kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-18 Thread Avi Kivity
Booting RHEL 5 i386 in kvm with -no-kvm-irqchip -smp 4 will hang in udev. I bisected this to a change in the _guest_ kernel: commit 95492e4646e5de8b43d9a7908d6177fb737b61f0 Author: Ingo Molnar [EMAIL PROTECTED] Date: Fri Feb 16 01:27:34 2007 -0800 [PATCH] x86: rewrite SMP TSC sync

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-18 Thread Cam Macdonell
Cam Macdonell wrote: Dor Laor wrote: Cam Macdonell wrote: Dor Laor wrote: Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: --- a/drivers/net/virtio_net.c +++

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-18 Thread Ingo Molnar
* Avi Kivity [EMAIL PROTECTED] wrote: Booting RHEL 5 i386 in kvm with -no-kvm-irqchip -smp 4 will hang in udev. I bisected this to a change in the _guest_ kernel: commit 95492e4646e5de8b43d9a7908d6177fb737b61f0 Author: Ingo Molnar [EMAIL PROTECTED] Date: Fri Feb 16 01:27:34 2007 -0800

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-18 Thread Cam Macdonell
Cam Macdonell wrote: Cam Macdonell wrote: Dor Laor wrote: Cam Macdonell wrote: Dor Laor wrote: Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: --- a/drivers/net/virtio_net.c +++

Re: [kvm-devel] KVM Test result, kernel 5ca24d9.., userspace 120e0c8..

2007-12-18 Thread Zhao, Yunfeng
Retested it on KVM-57. It has been fixed already. Thanks a lot! Yunfeng -Original Message- From: Avi Kivity [mailto:[EMAIL PROTECTED] Sent: 2007年12月19日 0:18 To: Zhao, Yunfeng Cc: kvm-devel Subject: Re: [kvm-devel] KVM Test result, kernel 5ca24d9.., userspace 120e0c8.. Zhao, Yunfeng

Re: [kvm-devel] KVM Test result, kernel 5ca24d9.., userspace 120e0c8..

2007-12-18 Thread Avi Kivity
Zhao, Yunfeng wrote: Retested it on KVM-57. It has been fixed already. Actually, the fix is post kvm-57. What kvm-userspace.git commit did you test? -- error compiling committee.c: too many arguments to function -

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-18 Thread Avi Kivity
Ingo Molnar wrote: While the change mentions that it fixes a time warp bug, it also says it should be rare. So clearly kvm smp tsc handing is buggy. Ingo/Thomas, (or anybody else), do you have any insight as to what kvm can be doing wrong to trigger this behavior? hm. Those time

Re: [kvm-devel] KVM Test result, kernel 5ca24d9.., userspace 120e0c8..

2007-12-18 Thread Zhao, Yunfeng
The kvm-userspace commit is c41ab776181097efb6e6fbb5aa33b4a1f5df3d4f and kernel commit is 89075253714a299236b8debfbfdcb670a3932a1b. I just noticed that the userspace is not kvm-57. Thanks Yunfeng -Original Message- From: Avi Kivity [mailto:[EMAIL PROTECTED] Sent: 2007年12月19日 14:30 To: