Re: [kvm-devel] loop in copy_user_generic_string

2008-03-09 Thread Zdenek Kabelac
2008/3/7, Zdenek Kabelac <[EMAIL PROTECTED]>: > 2008/3/5, Zdenek Kabelac <[EMAIL PROTECTED]>: > > > 2008/3/5, Avi Kivity <[EMAIL PROTECTED]>: > > > > > Andi Kleen wrote: > > > > Avi Kivity <[EMAIL PROTECTED]> writes: > > > > > > > >> Most likely movs emulation is broken for long counts.

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread Jamie Lokier
M. Warner Losh wrote: > In message: <[EMAIL PROTECTED]> > Jamie Lokier <[EMAIL PROTECTED]> writes: > : Btw, unfortunately pthread_self() is not safe to call from signal > : handlers. > > And also often times meaningless, as signal handlers can run in > arbitrary threads... That's usua

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread Daniel P. Berrange
On Sun, Mar 09, 2008 at 11:26:43AM +0200, Gilad Ben-Yossef wrote: > Glauber Costa wrote: > > This patch introduces a "thread_id" variable to CPUState. > > It's duty will be to hold the process, or more generally, thread > > id of the current executing cpu > > > > env->nb_watchpoints = 0; > >

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Gilad Ben-Yossef <[EMAIL PROTECTED]> writes: : > What you're supposed to do with pthreads in general is use pthread_self(). : : Unfortunately, AFAIK the opaque handle that pthread_self() returns is : not quite meaningless outside of the process whereas

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Jamie Lokier <[EMAIL PROTECTED]> writes: : Btw, unfortunately pthread_self() is not safe to call from signal : handlers. And also often times meaningless, as signal handlers can run in arbitrary threads... Warner ---

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread Gilad Ben-Yossef
Jamie Lokier wrote: > Gilad Ben-Yossef wrote: >> Glauber Costa wrote: >>> This patch introduces a "thread_id" variable to CPUState. >>> It's duty will be to hold the process, or more generally, thread >>> id of the current executing cpu >>> >>> env->nb_watchpoints = 0; >>> +#ifdef __WIN32 >>> +

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread Jamie Lokier
Gilad Ben-Yossef wrote: > Glauber Costa wrote: > >This patch introduces a "thread_id" variable to CPUState. > >It's duty will be to hold the process, or more generally, thread > >id of the current executing cpu > > > > env->nb_watchpoints = 0; > >+#ifdef __WIN32 > >+env->thread_id = GetCurr

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-09 Thread Mikael Pettersson
Balaji Rao writes: > Yes the idea works. One more memset is needed in sysdev_register. Here's the > final patch. > > diff --git a/drivers/base/sys.c b/drivers/base/sys.c > index 2f79c55..7c839d9 100644 > --- a/drivers/base/sys.c > +++ b/drivers/base/sys.c > @@ -133,6 +133,7 @@ int sysdev_

Re: [kvm-devel] [Qemu-devel] [PATCH] use a thread id variable

2008-03-09 Thread Gilad Ben-Yossef
Glauber Costa wrote: > This patch introduces a "thread_id" variable to CPUState. > It's duty will be to hold the process, or more generally, thread > id of the current executing cpu > > env->nb_watchpoints = 0; > +#ifdef __WIN32 > +env->thread_id = GetCurrentProcessId(); > +#else > +e