Re: [kvm-devel] [PATCH 08 of 11] anon-vma-rwsem

2008-05-07 Thread Andrew Morton
On Thu, 8 May 2008 00:44:06 +0200 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > On Wed, May 07, 2008 at 03:31:03PM -0700, Andrew Morton wrote: > > Nope. We only need to take the global lock before taking *two or more* of > > the per-vma locks. > > > > I really

Re: [kvm-devel] [PATCH 08 of 11] anon-vma-rwsem

2008-05-07 Thread Andrew Morton
On Thu, 8 May 2008 00:22:05 +0200 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > > No, the simple solution is to just make up a whole new upper-level lock, > > and get that lock *first*. You can then take all the multiple locks at a > > lower level in any order you damn well please. > > Unfortu

Re: [kvm-devel] [PATCH 01 of 11] mmu-notifier-core

2008-05-07 Thread Andrew Morton
On Wed, 07 May 2008 16:35:51 +0200 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > # HG changeset patch > # User Andrea Arcangeli <[EMAIL PROTECTED]> > # Date 1210096013 -7200 > # Node ID e20917dcc8284b6a07cfcced13dda4cbca850a9c > # Parent 5026689a3bc323a26d33ad882c34c4c9c9a3ecd8 > mmu-notifier-cor

Re: [kvm-devel] [PATCH 01 of 11] mmu-notifier-core

2008-05-07 Thread Andrew Morton
On Wed, 07 May 2008 16:35:51 +0200 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > # HG changeset patch > # User Andrea Arcangeli <[EMAIL PROTECTED]> > # Date 1210096013 -7200 > # Node ID e20917dcc8284b6a07cfcced13dda4cbca850a9c > # Parent 5026689a3bc323a26d33ad882c34c4c9c9a3ecd8 > mmu-notifier-cor

Re: [kvm-devel] + kvm-provide-kvmh-for-all-architecture-fixes-headers_install.patch added to -mm tree

2008-03-25 Thread Andrew Morton
fail on all architectures without asm/kvm.h. Therefore, this patch also provides asm/kvm.h on all architectures. Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> Acked-by: Avi Kivity <[EMAIL PROTECTED]> Cc: Sam Ravnborg <[EMAIL PROTECTED] Cc: David Woodhouse <[EMAIL PROT

Re: [kvm-devel] [RFC/PATCH 02/15 v2] preparation: host memory management changes for s390 kvm

2008-03-24 Thread Andrew Morton
On Sat, 22 Mar 2008 18:02:39 +0100 Carsten Otte <[EMAIL PROTECTED]> wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > From: Christian Borntraeger <[EMAIL PROTECTED]> > > This patch changes the s390 memory management defintions to use the pgste > field > for dirty and reference bit tracking of

Re: [kvm-devel] [RFC/PATCH 01/15 v2] preparation: provide hook to enable pgstes in user pagetable

2008-03-24 Thread Andrew Morton
On Sat, 22 Mar 2008 18:02:37 +0100 Carsten Otte <[EMAIL PROTECTED]> wrote: > From: Martin Schwidefsky <[EMAIL PROTECTED]> > > The SIE instruction on s390 uses the 2nd half of the page table page to > virtualize the storage keys of a guest. This patch offers the s390_enable_sie > function, which r

Re: [kvm-devel] [Bugme-new] [Bug 10246] New: "in" after successful ioperm() results in SEGV after kvm use

2008-03-14 Thread Andrew Morton
On Fri, 14 Mar 2008 18:48:15 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=10246 > >Summary: "in" after successful ioperm() results in SEGV after kvm > use >Product: Memory Management >Version: 2.5 >

Re: [kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install

2008-03-10 Thread Andrew Morton
On Mon, 10 Mar 2008 14:11:04 +0100 Christian Borntraeger <[EMAIL PROTECTED]> wrote: > [PATCH v2] kvm: provide kvm.h for all architecture: fixes headers_install > > Currently include/linux/kvm.h is not considered by make headers_install, > because Kbuild cannot handle " unifdef-$(CONFIG_FOO) +=

Re: [kvm-devel] [PATCH] mmu notifiers #v7

2008-02-28 Thread Andrew Morton
On Fri, 29 Feb 2008 01:40:01 +0100 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > > > +#define mmu_notifier(function, mm, args...) > > > \ > > > + do {\ > > > + struct mmu_notifier *__mn;

Re: [kvm-devel] [PATCH] KVM swapping with MMU Notifiers V7

2008-02-16 Thread Andrew Morton
On Sat, 16 Feb 2008 11:48:27 +0100 Andrea Arcangeli <[EMAIL PROTECTED]> wrote: > +void kvm_mmu_notifier_invalidate_range_end(struct mmu_notifier *mn, > +struct mm_struct *mm, > +unsigned long start, unsigned long > en

Re: [kvm-devel] [patch 1/6] mmu_notifier: Core code

2008-02-16 Thread Andrew Morton
On Sat, 16 Feb 2008 10:45:50 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > How important is this feature to KVM? > > > > Very. kvm pins pages that are referenced by the guest; hm. Why does it do that? > a 64-bit guest > will easi

Re: [kvm-devel] [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-15 Thread Andrew Morton
On Thu, 14 Feb 2008 22:49:04 -0800 Christoph Lameter <[EMAIL PROTECTED]> wrote: > These special additional callbacks are required because XPmem (and likely > other mechanisms) do use their own rmap (multiple processes on a series > of remote Linux instances may be accessing the memory of a process

Re: [kvm-devel] [patch 3/6] mmu_notifier: invalidate_page callbacks

2008-02-15 Thread Andrew Morton
On Thu, 14 Feb 2008 22:49:02 -0800 Christoph Lameter <[EMAIL PROTECTED]> wrote: > Two callbacks to remove individual pages as done in rmap code > > invalidate_page() > > Called from the inner loop of rmap walks to invalidate pages. > > age_page() > > Called for the determination of

Re: [kvm-devel] [patch 1/6] mmu_notifier: Core code

2008-02-15 Thread Andrew Morton
On Thu, 14 Feb 2008 22:49:00 -0800 Christoph Lameter <[EMAIL PROTECTED]> wrote: > MMU notifiers are used for hardware and software that establishes > external references to pages managed by the Linux kernel. These are > page table entriews or tlb entries or something else that allows > hardware (s

Re: [kvm-devel] [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges

2008-02-15 Thread Andrew Morton
On Thu, 14 Feb 2008 22:49:01 -0800 Christoph Lameter <[EMAIL PROTECTED]> wrote: > The invalidation of address ranges in a mm_struct needs to be > performed when pages are removed or permissions etc change. hm. Do they? Why? If I'm in the process of zero-copy writing a hunk of memory out to har

Re: [kvm-devel] [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Andrew Morton
On Fri, 8 Feb 2008 16:05:00 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Fri, 8 Feb 2008, Andrew Morton wrote: > > > You took it correctly, and I didn't understand the answer ;) > > We have done several rounds of discussion on linux-kernel about th

Re: [kvm-devel] [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Andrew Morton
On Fri, 8 Feb 2008 17:43:02 -0600 Robin Holt <[EMAIL PROTECTED]> wrote: > On Fri, Feb 08, 2008 at 03:41:24PM -0800, Christoph Lameter wrote: > > On Fri, 8 Feb 2008, Robin Holt wrote: > > > > > > > What about ib_umem_get()? > > > > Correct. > > > > You missed the turn of the conversation to how

Re: [kvm-devel] [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Andrew Morton
On Fri, 08 Feb 2008 14:06:16 -0800 Christoph Lameter <[EMAIL PROTECTED]> wrote: > This is a patchset implementing MMU notifier callbacks based on Andrea's > earlier work. These are needed if Linux pages are referenced from something > else than tracked by the rmaps of the kernel (an external MMU).

Re: [kvm-devel] 2.6.24-rc8-mm1 (KVM build issues)

2008-01-22 Thread Andrew Morton
> On Fri, 18 Jan 2008 22:56:32 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > * Andrew Morton <[EMAIL PROTECTED]> [2008-01-17 02:35:14]: > > > - kvm probably doesn't work properly because I couldn't be bothered fixing > > the conflicts between git-k

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Andrew Morton
On Sun, 23 Dec 2007 15:15:25 -0500 Marcelo Tosatti <[EMAIL PROTECTED]> wrote: > Are you guys OK with this ? > > > Modular KVM needs walk_page_range(), and also vm_normal_page() to be > used on pagewalk callback. I am. - T

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Andrew Morton
On Sun, 23 Dec 2007 12:35:30 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > > > > > >> Avi Kivity wrote: > >> > >>> Avi Kivity

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Andrew Morton
On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Avi Kivity wrote: > > Avi Kivity wrote: > > > >> Exactly. But it is better to be explicit about it and pass the page > >> directly like you did before. I hate to make you go back-and-fourth, > >> but I did not understa

Re: [kvm-devel] [PATCH] Define smp_call_function_mask() on uniprocessor builds

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 10:51:25 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Rather than #ifdef users of smp_call_function_mask(), define it as an > empty macro to avoid build errors. The function explicitly prohibits > callers from specifying the current cpu, so nothing needs to be done. > > This

Re: [kvm-devel] 2.6.23-rc8-mm1: drivers/kvm/ioapic.o build failure

2007-09-26 Thread Andrew Morton
On Wed, 26 Sep 2007 11:00:09 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Mariusz Kozlowski wrote: > > Hello, > > > > Similar (the same?) as in 2.6.23-rc6-mm1? > > > > http://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg208812.html > > > > CC [M] drivers/kvm/ioapic.o > > dri

Re: [kvm-devel] kvm warning

2007-08-08 Thread Andrew Morton
On Thu, 09 Aug 2007 01:48:07 +0300 Avi Kivity <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > >> ia64 allmodconfig says > >> > >> drivers/kvm/Kconfig:14:warning: 'sel

[kvm-devel] kvm warning

2007-08-08 Thread Andrew Morton
ia64 allmodconfig says drivers/kvm/Kconfig:14:warning: 'select' used by config symbol 'KVM' refers to undefined symbol 'PREEMPT_NOTIFIERS' Because of commit 8928fb48c7a7f9053a55f1d0023cbc533f2b3663 Author: Avi Kivity <[EMAIL PROTECTED]> Date: Wed Jul 11 18:17:21 2007 +0300 KVM: Use the

Re: [kvm-devel] 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-12 Thread Andrew Morton
On Tue, 12 Jun 2007 18:16:29 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > > # Read KERNELRELEASE from include/config/kernel.release (if it exists) > > > > This causes the i386 allmodconfig build to fail: > > Seems to be doing its job rather effectively. err, hang on. I had a different p

Re: [kvm-devel] 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

2007-06-12 Thread Andrew Morton
On Mon, 11 Jun 2007 23:22:24 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > Add -Werror-implicit-function-declaration > This makes builds fail sooner if something is implicitly defined instead > of having to wait half an hour for it to fail at the linking stage. > > Signed-off-by: Dave Jones <[EMA

Re: [kvm-devel] [PATCH] make KVM conform to sucky rdmsr interface

2007-03-22 Thread Andrew Morton
On Thu, 22 Mar 2007 18:49:30 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > rdmsr_safe() takes pointers. rdmsr() modifies its arguments. What a > mess. > > Fix rdmsr_safe() with !CONFIG_PARAVIRT. > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> > > diff -r a7f78e8eacc8 include/asm-i386/

Re: [kvm-devel] [PATCH 0/6] KVM userspace interface updates for 2.6.21

2007-02-25 Thread Andrew Morton
> On Sun, 25 Feb 2007 11:58:23 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Avi Kivity wrote: > > > > The patchset, along with the previous fixset, is available as a git > > tree from git://kvm.qumranet.com/home/avi/kvm/linux-2.6. You may wish > > to plant it in your little git forest. > > > >

Re: [kvm-devel] [PATCH 4/5] KVM: cpu hotplug support

2007-01-30 Thread Andrew Morton
On Tue, 30 Jan 2007 14:56:16 - Avi Kivity <[EMAIL PROTECTED]> wrote: > +static void decache_vcpus_on_cpu(int cpu) > +{ > + struct kvm *vm; > + struct kvm_vcpu *vcpu; > + int i; > + > + spin_lock(&kvm_lock); > + list_for_each_entry(vm, &vm_list, vm_list) > + for

Re: [kvm-devel] [PATCH 0/33] KVM: MMU: Cache shadow page tables

2007-01-04 Thread Andrew Morton
On Thu, 04 Jan 2007 17:48:45 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > The current kvm shadow page table implementation does not cache shadow > page tables (except for global translations, used for kernel addresses) > across context switches. This means that after a context switch, every >

Re: [kvm-devel] [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Andrew Morton
On Thu, 30 Nov 2006 16:44:25 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > [...] Pretty similar to things like the msr or mtrr driver that expose > > cpu features as character drivers aswell. > > you can expose everything as character drivers and ioctls, but that > doesnt make it the right s

Re: [kvm-devel] [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-17 Thread Andrew Morton
On Fri, 17 Nov 2006 09:20:49 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > >> +out_vcpu: > >> + vcpu_put(vcpu); > >> + > >> + return rc; > >> +} > >> > > > > This function returns no indication of how many msrs it actually did set. > > Should it? > > > > It can't hurt. Is returning th

Re: [kvm-devel] [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-16 Thread Andrew Morton
On Thu, 16 Nov 2006 18:04:22 - Avi Kivity <[EMAIL PROTECTED]> wrote: > +static int kvm_dev_ioctl_set_msrs(struct kvm *kvm, struct kvm_msrs *msrs) > +{ > + struct kvm_vcpu *vcpu; > + struct kvm_msr_entry *entry, *entries; > + int rc; > + u32 size, num_entries, i; > + > + if

Re: [kvm-devel] [PATCH 0/14] KVM: Kernel-based Virtual Machine (v4)

2006-11-08 Thread Andrew Morton
On Wed, 08 Nov 2006 10:07:15 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Wed, 08 Nov 2006 09:14:50 +0200 > > Avi Kivity <[EMAIL PROTECTED]> wrote: > > > > > >> Roland Dreier wrote: > >> > >>

Re: [kvm-devel] [PATCH 0/14] KVM: Kernel-based Virtual Machine (v4)

2006-11-07 Thread Andrew Morton
On Wed, 08 Nov 2006 09:14:50 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > Roland Dreier wrote: > > > That's gas 2.16.1. I assume it needs some super-new binutils. > > > > > > I'm not sure what to do about this. What's the minimum version? > > > > According to http://kvm.sourceforge.net/howt

Re: [kvm-devel] [PATCH 0/14] KVM: Kernel-based Virtual Machine (v4)

2006-11-07 Thread Andrew Morton
On Sun, 05 Nov 2006 22:27:45 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > The following patchset adds a driver for Intel's hardware > virtualization extensions to the x86 architecture. kapow. {standard input}: Assembler messages: {standard input}:157: Error: no such instruction: `vmxon -20(%eb