Re: [kvm-devel] [PATCH] Moving ioapic.h and ioapic.c back to common directory

2007-12-16 Thread Avi Kivity
Zhang, Xiantao wrote: common-objs = $(addprefix ../../../virt/kvm/, kvm_main.o) +common-objs += $(addprefix ../../../virt/kvm/, ioapic.o) Just add ioapic.o behind kvm_main.o; it's a list. -- Any sufficiently difficult bug is indistinguishable from a feature.

Re: [kvm-devel] [PATCH][10/22] kvm: Portability : Moving pio_data, pio, mmio_fault_cr2 to arch.

2007-12-14 Thread Avi Kivity
Carsten Otte wrote: Zhang, Xiantao wrote: diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index 530c391..2d2ff55 100644 --- a/drivers/kvm/kvm_main.c +++ b/drivers/kvm/kvm_main.c @@ -670,7 +670,7 @@ static int kvm_vcpu_fault(struct vm_area_struct *vma, struct vm_fault *vmf)

Re: [kvm-devel] [PATCH] align gdbstub with QEMU

2007-12-14 Thread Avi Kivity
Jan Kiszka wrote: BTW, are there plans to merge the kvm branch into qemu at some point and continue development unitedly with the qemu people? There is the intent, but no concrete plans. What is missing is someone to prepare a suitable patchset for qemu-devel; that's no small amount of

Re: [kvm-devel] [PATCH] align gdbstub with QEMU

2007-12-14 Thread Avi Kivity
Jan Kiszka wrote: Jan Kiszka wrote: We've noticed some problems with current gdbstub in kvm's qemu: # qemu-system-x86_64 -hda myimage -S -s # gdb (gdb) tar re :1234 Remote debugging using :1234 Remote 'g' packet reply is too long: [...] This

Re: [kvm-devel] [PATCH][0/22] Patches to use arch concept to hold arch-speicif fileds for kvm_vcpu and kvm strucuture.

2007-12-14 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi As you know, we have to change to kvm_vcpu_arch concept since meet various issues about #includes. This patches enables it. I also prepared a series of patches to split kvm with similar idea. Now, kvm.h includes x86.h by default. X86.c needs includes kvm.h,

Re: [kvm-devel] [PATCH] x86_64: fix problems due to use of outb to port 80 on some AMD64x2 laptops, etc.

2007-12-14 Thread Avi Kivity
David P. Reed wrote: Replace use of outb to unused diagnostic port 0x80 for time delay with udelay based time delay on x86_64 architecture machines. Fix for bugs 9511 and 6307 in bugzilla, plus bugs reported in bugzilla.redhat.com. Derived from suggestion (that didn't compile) by Pavel

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-14 Thread Avi Kivity
Theodore Tso wrote: BTW, there were changes between 2.6.24-rc3 and -rc5 such that there are merge conflicts when I tried to do a git pull from kvm/master unto Linus's git mainline. In general I merge regularly and resolve conflicts. Currently kvm.git is based on 2.6.24-rc5. -- Any

Re: [kvm-devel] PATCH vmx.c: add printk_ratelimit in vmx_intr_assist

2007-12-14 Thread Avi Kivity
Ryan Harper wrote: Add printk_ratelimit check in front of printk. This prevents spamming of the message during 32-bit ubuntu 6.06server install. Previously, it would hang during the partition formatting stage. Applied, but this is worrying. Do you know whether this is a regression? --

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-13 Thread Avi Kivity
Arnd Bergmann wrote: On Tuesday 11 December 2007, Avi Kivity wrote: Heiko Carstens wrote: On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: arch/*/kvm/ arch dependent kvm code Maybe arch/*/virt/ ? No need to add an own directory for each

Re: [kvm-devel] [PATCH] Fix SMP shadow instantiation race

2007-12-13 Thread Avi Kivity
Marcelo Tosatti wrote: There is a race where VCPU0 is shadowing a pagetable entry while VCPU1 is updating it, which results in a stale shadow copy. Fix that by comparing the contents of the cached guest pte with the current guest pte after write-protecting the guest pagetable. Applied,

Re: [kvm-devel] [PATCH] Fix a typo for MAX_BIOS_SIZE

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: Thank Young for reporting it. From: Zhang Xiantao [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 08:22:19 +0800 Subject: [PATCH] kvm: qemu : Fix a typo. A typo for defieing max_bios_size. Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Applied, thanks. -- error

Re: [kvm-devel] [PATCH] LAPIC: minor debugging compile fix

2007-12-13 Thread Avi Kivity
Joerg Roedel wrote: This patch fixes a compile error of the LAPIC code with APIC debugging enabled. Applied, thanks. -- error compiling committee.c: too many arguments to function - SF.Net email is sponsored by:

Re: [kvm-devel] [PATCH] emulated cmpxchg8b should be atomic on i386

2007-12-13 Thread Avi Kivity
Marcelo Tosatti wrote: Emulate cmpxchg8b atomically on i386. This is required to avoid a guest pte walker from seeing a splitted write. Applied, thanks. -- error compiling committee.c: too many arguments to function

[kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
This restores live migration support which has been broken for a couple of releases. Also, if you had Java problems please test kvm-56, as it has some nx related permission fixes. Changes from kvm-55: - Generalize exception handling mechanism - fix x86 emulator eflags handling - avoid exit to

Re: [kvm-devel] [3/6][PATCH] kvm: kvm structure split into common fileds and arch-dependent ones

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 20:47:56 +0800 Subject: [PATCH] kvm: kvm structure split. Using macro KVM_COMM to hold kvm common fields as kvm_vcpu does. And, every arch defines its kvm structure separately. + struct kvm_vm_stat

Re: [kvm-devel] [2/6][PATCH] kvm: Moving memslot_id to x86.h

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 20:45:48 +0800 Subject: [PATCH] kvm: Moving memslot_id to x86.h Since it is not called in kvm_main.c, and it also will block kvm structure split, so moved it out. memslot_id() is not x86 specific. Why

Re: [kvm-devel] [2/6][PATCH] kvm: Moving memslot_id to x86.h

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: Avi Kivity wrote: Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 20:45:48 +0800 Subject: [PATCH] kvm: Moving memslot_id to x86.h Since it is not called in kvm_main.c, and it also will block kvm structure split, so moved

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
Pelle wrote: I get the following error when modprobing the new module: WARNING: Error inserting kvm (/lib/modules/2.6.22-14-generic/extra/kvm.ko): Unknown symbol in module, or unknown parameter (see dmesg) kvm: Unknown symbol cmpxchg64 Ubuntu 7.10 32-bits, C2D E6300 Please try the

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
Alexey Eremenko wrote: Hi Pelle! Yes, You're right, KVM-56 doesn't compiles on 32-bit systems. (tested on openSUSE 10.3, 32-bit) It compiles on 32-bit systems. It doesn't compile on 32-bit non-pae systems. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
Pelle wrote: Patch applied, rebuild (twice) but still the same error. Sorry, there was a type in the patch. Please change cpmxchg64 to cmpxchg64 in kernel/external-module-compat.h, or apply the attached corrected patch on a clean kvm-56. Avi Kivity wrote: Pelle wrote: I get

Re: [kvm-devel] [PATCH] VMX: inject high priority interrupts first

2007-12-13 Thread Avi Kivity
Dong, Eddie wrote: This is not necessary, vector doesn;t mean priority. Remember I ever had a talk with Avi that user level irqchip could only support one vector pending in kernel like you mentioned too. On the other hand, if we have multiple pending vectors, we will lose priority. The point

Re: [kvm-devel] [PATCH][5/22] kvm portability: Moving apic and apic_base to kvm_vcpu arch.

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Fri, 14 Dec 2007 00:33:56 +0800 Subject: [PATCH] kvm portability: Moving apic and apic_base to kvm_vcpu arch. This patches moving apic and apic_base to kvm_vcpu_arch. And use a macro apic(v) to simplifily get apic from vcpu.

Re: [kvm-devel] [PATCH][0/22] Patches to use arch concept to hold arch-speicif fileds for kvm_vcpu and kvm strucuture.

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi As you know, we have to change to kvm_vcpu_arch concept since meet various issues about #includes. This patches enables it. I also prepared a series of patches to split kvm with similar idea. Now, kvm.h includes x86.h by default. X86.c needs includes kvm.h,

[kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
KVM is due to receive support for multiple architectures (ppc, ia64, and s390, in addition to the existing x86), hopefully in time for the 2.6.25 merge window. It is awkward to place the new arch support in drivers/kvm/, so I'd like to propose the following new layout: virt/

Re: [kvm-devel] [PATCH][0/24] Patches to enable ia64 support in userspace.

2007-12-11 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi This series of patches are used to make kvm/ia64 userspace work in a clean way. In these patches, we have very few code for current source, except some necessary changes for ia64 target. Current ia64 support doesn't include processor and memory emulation

Re: [kvm-devel] [KVM/qemu] check page size of qemu and host at intialization time

2007-12-11 Thread Avi Kivity
Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 18:54:27 +0800 Subject: [PATCH] kvm: qemu: Check page size at initialization time. Currently, we assume Qemu target page size = HOST page size, this patch check them. if not equal, print error info and exit.

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Christian Borntraeger wrote: Am Dienstag, 11. Dezember 2007 schrieb Avi Kivity: KVM is due to receive support for multiple architectures (ppc, ia64, and s390, in addition to the existing x86), hopefully in time for the 2.6.25 merge window. It is awkward to place the new arch support

Re: [kvm-devel] [PATCH] SVM: support writing 0 to K8 performance counter control registers

2007-12-11 Thread Avi Kivity
Joerg Roedel wrote: This patch is a slightly improved version of a previously submitted patch. It lets SVM ignore writes of the value 0 to the performance counter control registers. Thus enabling them will still fail in the guest. This is required to boot Windows Vista 64bit.

Re: [kvm-devel] [PATCH] SVM: support writing 0 to K8 performance counter control registers

2007-12-11 Thread Avi Kivity
Joerg Roedel wrote: This patch is a slightly improved version of a previously submitted patch. It lets SVM ignore writes of the value 0 to the performance counter control registers. Thus enabling them will still fail in the guest. This is required to boot Windows Vista 64bit. Applied,

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Heiko Carstens wrote: On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: KVM is due to receive support for multiple architectures (ppc, ia64, and s390, in addition to the existing x86), hopefully in time for the 2.6.25 merge window. It is awkward to place the new arch support

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Sam Ravnborg wrote: On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: KVM is due to receive support for multiple architectures (ppc, ia64, and s390, in addition to the existing x86), hopefully in time for the 2.6.25 merge window. It is awkward to place the new arch support

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Sam Ravnborg wrote: So use arch/*/virt/kvm/ if kvm really requires a subdirectory of it own. Preferably not. A handful of files named kvm* does not warrant their own subdirectory IMO. We'll have 5-6 x86 specific files. Where do you suggest we place them? /arch/x86/virt/

Re: [kvm-devel] kvm-55 and ne2k-pci

2007-12-10 Thread Avi Kivity
Jerry Geis wrote: The extra -net user did the trick for redhat 9. THanks, I'll try redhat 7 now. The network seemed slow. ethtool eth0 reports 100m full. when copying all my files over it was slow. THese were source files (text) not big files at all. -net user is quite slow. Try -net

Re: [kvm-devel] [PATCH] Fix SMP shadow instantiation race

2007-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: On Mon, Dec 10, 2007 at 07:07:54PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: There is a race where VCPU0 is shadowing a pagetable entry while VCPU1 is updating it, which results in a stale shadow copy. Fix that by comparing the contents of the cached

Re: [kvm-devel] [PATCH] emulated cmpxchg8b should be atomic on i386

2007-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: Emulate cmpxchg8b atomically on i386. This is required to avoid a guest pte walker from seeing a splitted write. Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] diff --git a/drivers/kvm/x86.c b/drivers/kvm/x86.c index 9db4e32..d58d795 100644 --- a/drivers/kvm/x86.c

Re: [kvm-devel] [PATCH] Use cmpxchg for pte updates on walk_addr()

2007-12-09 Thread Avi Kivity
Marcelo Tosatti wrote: Oops! Updated patch: Applied, thanks. #define PT_LEVEL_BITS PT64_LEVEL_BITS #ifdef CONFIG_X86_64 #define PT_MAX_FULL_LEVELS 4 + #define CMPXCHG cmpxchg #else + #define CMPXCHG cmpxchg64 #define PT_MAX_FULL_LEVELS 2

Re: [kvm-devel] [PATCH] Use cmpxchg for pte updates on walk_addr()

2007-12-09 Thread Avi Kivity
Marcelo Tosatti wrote: On Fri, Dec 07, 2007 at 07:06:26AM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: Right, patch at end of the message restarts the process if the pte changes under the walker. The goto is pretty ugly, but I fail to see any elegant way of doing that. Ideas

Re: [kvm-devel] [PATCH] fix -kernel option

2007-12-09 Thread Avi Kivity
Anthony Liguori wrote: Glauber de Oliveira Costa wrote: Currently, the -kernel option is not working. Reason is, because we're registering chunks for regions 0-0xa and 0x10-ram_size, the phys_ram_addr + PA is broken. I think this patch is a reasonable work-around but

Re: [kvm-devel] [PATCH] svm: exit to userspace if write to cr8 and not using in-kernel apic

2007-12-09 Thread Avi Kivity
Joerg Roedel wrote: With this patch KVM on SVM will exit to userspace if the guest writes to CR8 and the in-kernel APIC is disabled. Applied, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] RPM building from tarball

2007-12-09 Thread Avi Kivity
Dan Kenigsberg wrote: Building RPMs using the published tarball is currently broken. On Fedora 8, there's an additional requirement of passing --build-id to ld. Applied both, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH] Move CONFIG_X86 decleration tobe x86 specificin configure script

2007-12-09 Thread Avi Kivity
Zhang, Xiantao wrote: Yes, That is also what I did in my patch. Been attached in privious mail :) Ok, applied that one. -- error compiling committee.c: too many arguments to function - SF.Net email is sponsored by:

Re: [kvm-devel] [PATCH] [0/1] simplify kvm-userspace to qemu-kvm callback structure

2007-12-07 Thread Avi Kivity
Christian Ehrhardt wrote: Well no response might mean that there is nothing to be said against this simplification ;-) I did respond, see http://article.gmane.org/gmane.comp.emulators.kvm.devel/10467. -- Any sufficiently difficult bug is indistinguishable from a feature.

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Avi Kivity
Dong, Eddie wrote: It is not a small change, I still need to study the whole patch :( If I can get some question clarified earlier, that helps a lot. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Avi Kivity Sent: 2007年12月4日 17:44 To: kvm

Re: [kvm-devel] KVM Test result, kernel 51727a1.. , userspace 6a385c9..

2007-12-06 Thread Avi Kivity
Izik Eidus wrote: [Yunfeng] Yes, it may not be a recent regression, and it may be a platform related issue. Before we used Harwitch /paxville to do the test, and in a period the installation test could pass without any problem. But after we switched the test machine to Dempsey/Woodcrest,

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Avi Kivity
Dong, Eddie wrote: Mmm, how can you know if it is injected successfully? From the patch, it looks like you know this by checking IDT_Vectoring in next VM Exit. That means the virtual interrupt controller state in memory is incorrect temply. If the injection success we can get VM Exit

Re: [kvm-devel] KVM Test result, kernel 51727a1.. , userspace 6a385c9..

2007-12-06 Thread Avi Kivity
Dong, Eddie wrote: How do u disable TPR? Remove the patch, or just remove the setting? Just put 'return 0' in cpu_has_tpr_shadow() (or however it is called). -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-06 Thread Avi Kivity
Dong, Eddie wrote: What I mean is we pre-load 2 pages where the stack are in, the logic may be: If (real mode) get 2 pages. enter critical path VM Resume. put these 2 pages. handle VM Exit normally. With 2nd thinking, We can cache these 2 pages. Something like: if

Re: [kvm-devel] [PATCH] RFC: simplify kvm-userspace to qemu-kvm callback structure

2007-12-06 Thread Avi Kivity
Christian Ehrhardt wrote: Background: In our ppc code for the demo we only needed a call to cpu_physical_memory_rw to handle all kind of mmio we needed. Looking at all the callback pointers for read/write mmio in kvm_callbacks I wondered if this can be simplified with

Re: [kvm-devel] [PATCH] Use cmpxchg for pte updates on walk_addr()

2007-12-06 Thread Avi Kivity
Marcelo Tosatti wrote: In preparation for multi-threaded guest pte walking, use cmpxchg() when updating guest pte's. This guarantees that the assignment of the dirty bit can't be lost if two CPU's are faulting the same address simultaneously. In case of pte update via write emulation, no

Re: [kvm-devel] [PATCH] x86: emulate read/write access to cr8

2007-12-06 Thread Avi Kivity
Joerg Roedel wrote: This patch adds code to emulate the access to the cr8 register to the x86 instruction emulator in kvm. Applied, thanks. -- error compiling committee.c: too many arguments to function - SF.Net

Re: [kvm-devel] KVM Test result, kernel 51727a1.. , userspace 6a385c9..

2007-12-06 Thread Avi Kivity
Izik Eidus wrote: Avi Kivity wrote: Izik Eidus wrote: [Yunfeng] Yes, it may not be a recent regression, and it may be a platform related issue. Before we used Harwitch /paxville to do the test, and in a period the installation test could pass without any problem. But after we

Re: [kvm-devel] [PATCH] x86: emulate read/write access to cr8

2007-12-06 Thread Avi Kivity
Joerg Roedel wrote: From: Joerg Roedel [EMAIL PROTECTED] This patch adds code to emulate the access to the cr8 register to the x86 instruction emulator in kvm. I wrote a unit test for 'mov cr8', and it passes! Seems we aren't trapping cr8 access at all for svm. -- error compiling

Re: [kvm-devel] [PATCH] x86: emulate read/write access to cr8

2007-12-06 Thread Avi Kivity
Avi Kivity wrote: Joerg Roedel wrote: From: Joerg Roedel [EMAIL PROTECTED] This patch adds code to emulate the access to the cr8 register to the x86 instruction emulator in kvm. I wrote a unit test for 'mov cr8', and it passes! Seems we aren't trapping cr8 access at all

Re: [kvm-devel] performance specs on VT-x vmenter/exit

2007-12-06 Thread Avi Kivity
Dan wrote: Greetings Honorable KVM Devs! I am doing research on the performance characteristics of the Intel VMX instructions, specifically with respect to KVM. I need to count the cycles for a VMENTER and VMEXIT instruction under various conditions. (But getting it to work at all would be

Re: [kvm-devel] performance specs on VT-x vmenter/exit

2007-12-06 Thread Avi Kivity
Anthony Liguori wrote: Have a look at user/test/x86/vmexit.c, which does exactly that. That only gives you the combined count of a vmenter and vmexit. Right; furthermore it measures kvm overhead and not just instruction latency. -- Any sufficiently difficult bug is indistinguishable

Re: [kvm-devel] [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

2007-12-06 Thread Avi Kivity
Jerone Young wrote: Hi, Young Are you sure it works for you? Seems in script, it can't recognize +=. Anyway, I also have a fix about it in my patch queue, when I do ia64 porting. Really? Hmmm.. that is valid bash syntax. Seems to work fine when I do it on the command line.

Re: [kvm-devel] [PATCH] Use cmpxchg for pte updates on walk_addr()

2007-12-06 Thread Avi Kivity
Marcelo Tosatti wrote: Right, patch at end of the message restarts the process if the pte changes under the walker. The goto is pretty ugly, but I fail to see any elegant way of doing that. Ideas? goto is fine for that. But there's a subtle livelock here: suppose vcpu 0 is in guest mode

Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-05 Thread Avi Kivity
Hollis Blanchard wrote: Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] Applied, thanks. Note that there is free advertising space between the summary and the signoff that you can use to explain the change. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] Strange network behaviour

2007-12-05 Thread Avi Kivity
Mike wrote: Now I noticed a strange behaviour. I have a gameserver running in a guest os. No problems on performance side, really fast. The only thing, when I make a ping test after unspecific time periods I get this: (this peaks are even there if the gameserver isn't running) As you can

Re: [kvm-devel] [PATCH 0 of 3] Portability: allow for non-x86 headers

2007-12-05 Thread Avi Kivity
Hollis Blanchard wrote: These patches allow us to stop unconditionally including x86 headers, which allows us to provide alternative definitions. The first two just split things out to avoid circular header dependencies. Applied all three, thanks. -- error compiling committee.c: too

Re: [kvm-devel] [patch 05/18] kvm: nopage

2007-12-05 Thread Avi Kivity
[EMAIL PROTECTED] wrote: Convert KVM from nopage to fault. @@ -3111,27 +3105,21 @@ out: return r; } -static struct page *kvm_vm_nopage(struct vm_area_struct *vma, - unsigned long address, - int *type) +static int

Re: [kvm-devel] Strange network behaviour

2007-12-05 Thread Avi Kivity
Mike wrote: You can download the requested trace at http://www.eliteserver.biz/trace.tar.gz the peaks were around 12:04:30 Can you rerun, this time with additional options '-x -s 80' to strace (so I can identify the pings from random broadcast noise on the network). Also please run

Re: [kvm-devel] KVM Test result, kernel 51727a1.. , userspace 6a385c9..

2007-12-05 Thread Avi Kivity
Zhao, Yunfeng wrote: One regression: 1. Cannot install 64bit vista guests. https://sourceforge.net/tracker/?funcÞtailatid‰3831aid36905group_id05 99 Internal testing here confirms, but this is not a recent regression. When was the last time Vista x64 installed reliably

Re: [kvm-devel] How to handle kvm-abi-10 case for other archs.

2007-12-05 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: #ifdef is okay for this. Actually we can probably remove abi 10 support since the F7 kernel now supports the modern ABI (I don't think anybody else uses abi 10, which is pre 2.6.22 when we announced ABI compatibility. ubuntu feisty uses kernel

Re: [kvm-devel] KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

2007-12-05 Thread Avi Kivity
Hollis Blanchard wrote: diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig index 6569206..4086080 100644 --- a/drivers/kvm/Kconfig +++ b/drivers/kvm/Kconfig @@ -3,7 +3,7 @@ # menuconfig VIRTUALIZATION bool Virtualization -depends on X86 +depends on ARCH_SUPPORTS_KVM

Re: [kvm-devel] Strange network behaviour

2007-12-05 Thread Avi Kivity
Mike wrote: Avi Kivity schrieb: Mike wrote: Now I noticed a strange behaviour. I have a gameserver running in a guest os. No problems on performance side, really fast. The only thing, when I make a ping test after unspecific time periods I get this: (this peaks are even

Re: [kvm-devel] Strange network behaviour

2007-12-05 Thread Avi Kivity
Pelle wrote: Hi, Is there a fast and simple way to tell the version of the binary? I think I remember something about that on this mailing list, but I can't find it in 'qemu-system-x86_64 -h' Right now, only the kernel module (see dmesg). kvm-56's qemu will also report its version number.

Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-05 Thread Avi Kivity
Carsten Otte wrote: Avi Kivity wrote: What about merging kvm_cpu_has_interrupt() into _runnable()? My feeling is that we can keep it separated. On s390 there is a difference between has_interrupt and not runnable: CPUs can be in stopped state, and they can be in enabled wait

Re: [kvm-devel] [ANNOUNCE] kvm-55 release

2007-12-05 Thread Avi Kivity
Ryan Harper wrote: * Cam Macdonell [EMAIL PROTECTED] [2007-12-04 13:08]: Hi Avi, I'm having a problem with unifdef target in the kvm-userspace/kernel/Makefile: [EMAIL PROTECTED]:~/src/KVM/kvm-userspace$ make -C kernel sync LINUX=~/src/KVM/kvm make: Entering directory

Re: [kvm-devel] [PATCH][4/5] kvm: libkvm: Moving set and get shadow pages functions to arch x86

2007-12-04 Thread Avi Kivity
Zhang, Xiantao wrote: From: Zhang Xiantao [EMAIL PROTECTED] Date: Mon, 3 Dec 2007 22:06:04 +0800 Subject: [PATCH] kvm: libkvm. Moving set and get shadow pages to x86 arch. Move kvm_setget_shadow_pages to arch-x86 for libkvm Signed-off-by: Zhang Xiantao [EMAIL PROTECTED] Please put a

Re: [kvm-devel] [PATCH][0/5] kvm:libkvm : KVM/IA64 libkvmfor ia64

2007-12-04 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi These patches enable libkvm built successfully for ia64. This is the preparation support for kvm/ia64. It will help us to reduce the maintain effor once check-in. I will send the subsequent patches to enable ia64 userspace support. [1/5] Update

[kvm-devel] [PATCH 4/7] KVM: Use generalized exception queue for injecting #UD

2007-12-04 Thread Avi Kivity
Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/svm.c | 12 ++-- drivers/kvm/vmx.c | 11 +-- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c index b896614..8b1cc60 100644 --- a/drivers/kvm/svm.c +++ b/drivers

Re: [kvm-devel] [PATCH] [0/10]Patches to split qemu-kvm.c

2007-12-04 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi This series of patches are introduced to split qemu-kvm.c, and make it arch-independent. In these patches, one file called qemu-kvm-x86.c is created. For arch-specific stuff, I also use kvm_arch prefix to hold arch-specific code. Tested on x86 and x86_64

[kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-04 Thread Avi Kivity
The current irq and exception injection infrastructure is quite complex and has been the source of a number of bugs in the past. This patchset simplifies irq and exception injection: - Much more work is carried out in common code rather than vmx/svm specific code. Information is kept in C

[kvm-devel] [PATCH 3/7] KVM: Replace #GP injection by the generalized exception queue

2007-12-04 Thread Avi Kivity
Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/svm.c | 17 ++--- drivers/kvm/vmx.c | 18 ++ drivers/kvm/x86.c | 43 +++ drivers/kvm/x86.h |7 +-- drivers/kvm

[kvm-devel] [PATCH 1/7] KVM: Generalize exception injection mechanism

2007-12-04 Thread Avi Kivity
Instead of each subarch doing its own thing, add an API for queuing an injection, and manage failed exception injection centerally (i.e., if an inject failed due to a shadow page fault, we need to requeue it). Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/svm.c | 21

[kvm-devel] [PATCH 6/7] KVM: Move tpr threshold calculation into common code

2007-12-04 Thread Avi Kivity
This moves the tpr shadow processing into the local apic code from the vmx interrupt injection path. This will allow decoupling the irq injection path from normal execution (which needs to update the tpr threshold even when no irq is being injected). Signed-off-by: Avi Kivity [EMAIL PROTECTED

[kvm-devel] [PATCH 7/7] KVM: Ack interrupts only after they have successfully been injected

2007-12-04 Thread Avi Kivity
() will attempt to inject the interrupt, and -interrupt_injected() will check whether this actually succeeded (upon which common code will ack the interrupt). This allows much simpler management of pending interrupts. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/svm.c | 113

[kvm-devel] [PATCH 5/7] KVM: Add explicit acks to interrupt controller model

2007-12-04 Thread Avi Kivity
-ack() - acknowledge interrupt Which allows acking only after the core has accepted the interrupt. Currently we use the new model with the old semantics by calling ack() immediately after we see a pending interrupt. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm

Re: [kvm-devel] [PATCH] RFC: Use CONFIG_HAS_IOPORT around vcpu-pio_data

2007-12-04 Thread Avi Kivity
Hollis Blanchard wrote: Actually, (now that I try to build with it :) this doesn't work for PowerPC, which defines (or rather, doesn't not define) CONFIG_HAS_IOPORT. So I guess a callout to arch code will do. I'll send a patch sometime. We can also have a CONFIG_KVM_HAS_PIO and

[kvm-devel] [ANNOUNCE] kvm-55 release

2007-12-04 Thread Avi Kivity
The cr3 reload optimization in kvm-54 killed Solaris, so here is a fix. Changes from kvm-54: - remove old hypercall driver (Anthony Liguori) - disable dirty page logging for main memory (Izik Eidus) - fix incorrect page count calculation for dirty logging (Izik Eidus) - improve testsuite 'make

Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-04 Thread Avi Kivity
Carsten Otte wrote: Hollis Blanchard wrote: Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] Acked-by: Carsten Otte [EMAIL PROTECTED] We'll need this too on big iron. What about merging kvm_cpu_has_interrupt() into _runnable()? My feeling is that we can keep it separated. -- error

Re: [kvm-devel] [PATCH 0/7] Rework irq injection infrastructure

2007-12-04 Thread Avi Kivity
Joerg Roedel wrote: On Tue, Dec 04, 2007 at 11:44:07AM +0200, Avi Kivity wrote: The patchset is also necessary for integrating the tpr optimization branch and for injecting interrupts in big real mode. Interesting work. Do you have an updated tpr optimization patch which applys

Re: [kvm-devel] How to handle kvm-abi-10 case for other archs.

2007-12-04 Thread Avi Kivity
Zhang, Xiantao wrote: Jeremy Katz wrote: On Sat, 2007-12-01 at 12:10 +0200, Avi Kivity wrote: Zhang, Xiantao wrote: I think new archs for kvm doesn't need to care about kvm-abi case in their code, since current abi is bigger than 10. But in current libkvm.c, we can see

Re: [kvm-devel] [PATCH] Refactor hypercall infrastructure (v2)

2007-12-03 Thread Avi Kivity
or DstMem, but have a ModR/M byte with Mod = 3. It fixes (at least) the lmsw and smsw instructions on an AMD64 CPU, which are needed for FreeBSD. Signed-off-by: Aurelien Jarno [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] diff --git a/drivers/kvm/x86_emulate.c b

Re: [kvm-devel] [stable] [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable)

2007-12-03 Thread Avi Kivity
Greg KH wrote: On Sun, Dec 02, 2007 at 01:18:37PM +0200, Avi Kivity wrote: The following patchset fixes some bugs in KVM for the next 2.6.23.y stable release. Please apply. I'm guessing that all of these are already upstream in Linus's tree? Yes, except one, which has been

Re: [kvm-devel] [stable] [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable)

2007-12-03 Thread Avi Kivity
Greg KH wrote: 1 a012e65aee48379a7a87eadafa74f878b61522b9 2 4e62417bf317504c0b85e0d7abd236f334f54eaf 3 651a3e29b3d19418d7a8a9787906061f9be7cc5f 4 cf5a94d1331b411b84414c13e43f578260942d6b 5 00b2ef475d4728ca53a2bc788c7978042907e354 6 N/A 7 404fb881b82cf0cf6981832f8d31a7484e4dee81 8

Re: [kvm-devel] [PATCH] [0/10]Patches to split qemu-kvm.c

2007-12-03 Thread Avi Kivity
Zhang, Xiantao wrote: Hi, Avi This series of patches are introduced to split qemu-kvm.c, and make it arch-independent. In these patches, one file called qemu-kvm-x86.c is created. For arch-specific stuff, I also use kvm_arch prefix to hold arch-specific code. Tested on x86 and x86_64

Re: [kvm-devel] [PATCH] Remove KVM specific defines for MSR_EFER from svm.c

2007-12-02 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: This patch removes the KVM specific defines for MSR_EFER that were being used in the svm support file and migrates all references to use instead the ones from the kernel headers that are used everywhere else and that have the same values. Applied,

[kvm-devel] [PATCH 04/10] KVM: SVM: Intercept the 'invd' and 'wbinvd' instructions

2007-12-02 Thread Avi Kivity
'invd' can destroy host data, and 'wbinvd' allows the guest to induce long (milliseconds) latencies. Noted by Ben Serebrin. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/svm.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/svm.c b/drivers

[kvm-devel] [PATCH 10/10] KVM: VMX: Reset mmu context when entering real mode

2007-12-02 Thread Avi Kivity
on entering real mode. Signed-off-by: Yaozu (Eddie) Dong [EMAIL PROTECTED] Signed-off-by: Qing He [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/mmu.c |1 + drivers/kvm/vmx.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/mmu.c b

[kvm-devel] [PATCH 08/10] KVM: Skip pio instruction when it is emulated, not executed

2007-12-02 Thread Avi Kivity
emulation. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm_main.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index 504e81d..b58fdf3 100644 --- a/drivers/kvm/kvm_main.c +++ b/drivers/kvm/kvm_main.c

[kvm-devel] [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable)

2007-12-02 Thread Avi Kivity
access registers for instructions with ModR/M byte and Mod = 3 Avi Kivity (4): KVM: x86 emulator: invd instruction KVM: SVM: Intercept the 'invd' and 'wbinvd' instructions KVM: Skip pio instruction when it is emulated, not executed KVM: VMX: Force vm86 mode if setting flags

[kvm-devel] [PATCH 09/10] KVM: VMX: Force vm86 mode if setting flags during real mode

2007-12-02 Thread Avi Kivity
When resetting from userspace, we need to handle the flags being cleared even after we are in real mode. Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/vmx.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index 80628f6

[kvm-devel] [PATCH 07/10] KVM: SVM: Fix FPU leak while emulating clts

2007-12-02 Thread Avi Kivity
From: Amit Shah [EMAIL PROTECTED] The clts code didn't use set_cr0 properly, so our lazy FPU processing wasn't being done by the clts instruction at all. (this isn't called on Intel as the hardware does the decode for us) Signed-off-by: Amit Shah [EMAIL PROTECTED] Signed-off-by: Avi Kivity

[kvm-devel] [PATCH 06/10] KVM: Fix hang on uniprocessor

2007-12-02 Thread Avi Kivity
-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/kvm_main.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index cd05579..b514dfb 100644 --- a/drivers/kvm/kvm_main.c +++ b/drivers/kvm/kvm_main.c @@ -273,6 +273,11 @@ void

[kvm-devel] [PATCH 03/10] KVM: x86 emulator: invd instruction

2007-12-02 Thread Avi Kivity
Emulate the 'invd' instruction (opcode 0f 08). Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c index 08cd4a3..14ad4b4 100644 --- a/drivers

[kvm-devel] [PATCH 05/10] KVM: x86 emulator: Use emulator_write_emulated and not emulator_write_std

2007-12-02 Thread Avi Kivity
From: Amit Shah [EMAIL PROTECTED] emulator_write_std() is not implemented, and calling write_emulated should work just as well in place of write_std. Fixes emulator failures with the push r/m instruction. Signed-off-by: Amit Shah [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED

[kvm-devel] [PATCH 02/10] KVM: x86 emulator: fix access registers for instructions with ModR/M byte and Mod = 3

2007-12-02 Thread Avi Kivity
. Signed-off-by: Aurelien Jarno [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c index 804e86c..08cd4a3 100644

[kvm-devel] [PATCH 01/10] KVM: x86 emulator: implement 'movnti mem, reg'

2007-12-02 Thread Avi Kivity
From: Sheng Yang [EMAIL PROTECTED] Implement emulation of instruction: movnti m32/m64, r32/r64 opcode: 0x0f 0xc3 Needed to support Linux 2.6.16 as guest (used for mmio). Signed-off-by: Sheng Yang [EMAIL PROTECTED] Signed-off-by: Avi Kivity [EMAIL PROTECTED] --- drivers/kvm

<    10   11   12   13   14   15   16   17   18   19   >