[kvm-devel] [PATCH 06/50] KVM: emulate_instruction() calls now x86_decode_insn() and x86_emulate_insn()

2007-12-23 Thread Avi Kivity
From: Laurent Vivier <[EMAIL PROTECTED]> emulate_instruction() calls now x86_decode_insn() and x86_emulate_insn(). x86_emulate_insn() is x86_emulate_memop() without the decoding part. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]>

[kvm-devel] [PATCH 02/50] KVM: Refactor hypercall infrastructure (v3)

2007-12-23 Thread Avi Kivity
rspace hypercalls. [avi: fix #ud injection on vmx] Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |8 +- drivers/kvm/kvm_main.c| 156 +--- drivers/kvm/sv

[kvm-devel] [PATCH 00/50] KVM patch queue review for 2.6.25 merge window (part I)

2007-12-23 Thread Avi Kivity
Following is the first part of the 2.6.25 merge window submission. Since there are 238 patches in the queue (and a few more expected), they'll be sent in five batches of around 50 each. - This SF.net email is sponsored by: Mi

[kvm-devel] [PATCH 03/50] KVM: x86 emulator: remove unused functions

2007-12-23 Thread Avi Kivity
From: Laurent Vivier <[EMAIL PROTECTED]> Remove #ifdef functions never used Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 39 --- 1 files changed, 0

[kvm-devel] [PATCH 01/50] KVM: x86 emulator: Add vmmcall/vmcall to x86_emulate (v3)

2007-12-23 Thread Avi Kivity
From: Anthony Liguori <[EMAIL PROTECTED]> Add vmmcall/vmcall to x86_emulate. Future patch will implement functionality for these instructions. Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x8

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Andrew Morton wrote: > On Sun, 23 Dec 2007 12:35:30 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > > >> Andrew Morton wrote: >> >>> On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: >>> >>> >>>

Re: [kvm-devel] [Virtio-for-kvm] [PATCH 7/7] userspace virtio

2007-12-23 Thread Avi Kivity
Dor Laor wrote: > From f244bcad756c4f761627557bb7f315b1d8f22fb2 Mon Sep 17 00:00:00 2001 > From: Dor Laor <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 13:26:30 +0200 > Subject: [PATCH] [VIRTIO-NET] Rx performance improvement > The current performance are not good enough, the problem lies > in qe

Re: [kvm-devel] [Virtio-for-kvm] [PATCH 0/7] userspace virtio

2007-12-23 Thread Avi Kivity
Dor Laor wrote: > This patchset updates kvm repository with Anthony's virtio > implementation along > with rx performance improvements and guest reset handling. > The original code was sent to qemu devel list 2 weeks ago. > It contains support for network & block devices. > > Using the performance

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Andrew Morton wrote: > On Sun, 23 Dec 2007 10:59:22 +0200 Avi Kivity <[EMAIL PROTECTED]> wrote: > > >> Avi Kivity wrote: >> >>> Avi Kivity wrote: >>> >>> >>>> Exactly. But it is better to be explicit about it an

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Avi Kivity wrote: > Avi Kivity wrote: > >> Exactly. But it is better to be explicit about it and pass the page >> directly like you did before. I hate to make you go back-and-fourth, >> but I did not understand the issue completely before. >> >> &g

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-23 Thread Avi Kivity
Avi Kivity wrote: > > Exactly. But it is better to be explicit about it and pass the page > directly like you did before. I hate to make you go back-and-fourth, > but I did not understand the issue completely before. > btw, the call to gfn_to_page() can happen in page_fau

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > Hi Avi, > > Andrew, please see the comments on the need for a atomic get_user_pages() > below. > > On Sat, Dec 22, 2007 at 09:42:27PM +0200, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> In preparation for a mmu

Re: [kvm-devel] [PATCH] kvm/qemu: Fix ia64 build broken.

2007-12-22 Thread Avi Kivity
Amit Shah wrote: > On Friday 21 December 2007 20:28:23 Zhang, Xiantao wrote: > >> Hi, Avi >> Due to last merge with Qemu upstream, some interfaces are changed, and >> leads to build fail >> , this patch fixed them. >> Xiantao >> > > I've not checked the patch yet; but a curiosity question:

Re: [kvm-devel] external module sched_in event

2007-12-22 Thread Avi Kivity
Izik Eidus wrote: >> This fixes my longstanding KVM instability and "-smp 2" now works >> flawlessy with svm too! -smp 2 -snapshot crashes in qemu userland but >> that's not kernel related, must be some thread mutex lock recursion or >> lock inversion in the qcow cow code. Removing -snapshot make -

Re: [kvm-devel] [PATCH] external module: remove tmp directory once done with sync

2007-12-22 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > This patch complements 684c6426c5d58f01f45cd45420df96c837d0feb4 by > deleting the tmp directory once the merge is completed so that it > doesn't get included by mistake in the release package > Applied, thanks. -- Do not meddle in the internals of kernels,

Re: [kvm-devel] mailman setup for kvm-devel (was Re: external module sched_in event)

2007-12-22 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > On Fri, Dec 21, 2007 at 07:22:57PM +0100, Andrea Arcangeli wrote: > >> On Fri, Dec 21, 2007 at 07:52:52PM +0200, Izik Eidus wrote: >> >>> oh, it was sent to the list, dont trust (in case you did) the source forge >>> site for the mails >>> >> But

Re: [kvm-devel] [PATCH] kvm/qemu: Fix ia64 build broken.

2007-12-22 Thread Avi Kivity
Zhang, Xiantao wrote: > Hi, Avi > Due to last merge with Qemu upstream, some interfaces are changed, and > leads to build fail > , this patch fixed them. > Xiantao > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 22:47:52 +0800 > Subject: [PATCH] kvm: qemu : Fix ia64 build on late

Re: [kvm-devel] Oops on 2.6.23.11 with KVM 57

2007-12-22 Thread Avi Kivity
Guido Guenther wrote: > Hi, > I got the Oops below on an Dual CPU Dual-Core AMD Opteron(tm) Processor > 2220 running a 32bit kernel. Kernel is 2.6.23.11, kvm version 57. > Doesn't happen all the time but usually right at VM startup. Seems to be > easier to trigger when starting up several VMs in ro

Re: [kvm-devel] [PATCH 0/9] qemu: missing definitions from qemu-cvs merge

2007-12-22 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch series fixes compilation warnings from kvm 57 triggered > by 25a2e04e5689af63d104de2dea755f30bf643afd : > > PATCH 1/9 : fix definition for vmchannel_init in qemu/vl.c > PATCH 2/9 : fix definition for migrate_incoming in qemu/vl.c > PATCH

Re: [kvm-devel] [patch 0/5] KVM shadow scalability enhancements

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > The following patchset increases KVM shadow scalability by allowing concurrent > guest walking, allocation and instruction emulation. > Thanks; the split patchset it _much_ easier to review, and hopefully to bisect in case the review misses something. I believe we can

Re: [kvm-devel] [patch 4/5] KVM: export follow_page()

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > follow_page() is required by KVM to find the struct page which maps > to a given address in spinlock protected code. > > Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> > > Index: kvm.quilt/mm/memory.c > ===

Re: [kvm-devel] [patch 3/5] KVM: add kvm_follow_page()

2007-12-22 Thread Avi Kivity
Marcelo Tosatti wrote: > In preparation for a mmu spinlock, avoid schedules in mmu_set_spte() > by using follow_page() instead of get_user_pages(). > > The fault handling work by get_user_pages() now happens outside the lock. > > Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> > > Index: kvm.qui

Re: [kvm-devel] external module sched_in event

2007-12-22 Thread Avi Kivity
Andrea Arcangeli wrote: [snip] > So in short with the below fix applied, after a write_tsc(0,0), the > UP guest never return any error anymore. Previously it would return > frequent errors because sched_in wasn't properly invoked by svm.c and > it would crash at boot every single time after a writ

Re: [kvm-devel] [PATCH] Export three symbols for kvm use.

2007-12-20 Thread Avi Kivity
Christoph Hellwig wrote: > On Thu, Dec 20, 2007 at 01:57:01PM +0800, Zhang, Xiantao wrote: > >> Hi Tony, >> In order to build kvm source successfully, we need to export >> three symbols for kvm use. Please review. Maybe Avi can check-in to >> kvm.git upstream first. >> >> Thanks >> Xiantao

Re: [kvm-devel] [PATCH] align gdbstub with QEMU

2007-12-20 Thread Avi Kivity
Jan Kiszka wrote: > The qemu update did take place for -57, but a bit too mechanically. > Please merge this patch to finally fix the gdbstub. > > Thanks, applied. -- error compiling committee.c: too many arguments to function -

Re: [kvm-devel] [PATCH] kvm/qemu : Enable coms init, since rtc added back

2007-12-20 Thread Avi Kivity
Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 19:30:56 +0800 > Subject: [PATCH] kvm: qemu: Enable cmos, since rtc has been added back. > > Enable cmos, since code is mature and rtc added back > Applied this and the next patch; thanks. -- error compil

Re: [kvm-devel] [Qemu-devel] [PATCH 2/2] Option ROM for booting from SCSI/PV disks

2007-12-20 Thread Avi Kivity
Anthony Liguori wrote: > Hi, > > The attached patch is an option ROM that allows x86 guests to boot > from any block device supported by QEMU (and the guest kernel). It > works by hijacking the BIOS int13 function and then uses a very simply > protocol to communicate all block requests to QEMU. >

Re: [kvm-devel] remove redundant VM Exit for non-aligned guest pte write or part of pte write.

2007-12-20 Thread Avi Kivity
Dong, Eddie wrote: > I observed 1-2 seconds faster in Windows XPSP2 ACPI bootup with total of > 23 seconds. > I can;t say it is exactly caused by this patch, but anyway it simplifies > the logic and > code w/o any additional complexity. > thx,eddie > > > Patch looks good, but will delay so tha

Re: [kvm-devel] [PATCH] kvm: external module: Remove 'include/asm' before execute 'ln'

2007-12-20 Thread Avi Kivity
Yang, Sheng wrote: > From 33d84813131809e962a4cd8cae9b66a9062fa8db Mon Sep 17 00:00:00 2001 > From: Sheng Yang <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 14:22:18 +0800 > Subject: [PATCH] kvm: external module: Remove 'include/asm' before > execute 'ln' > > We use 'ln -sf' to refresh the symbolic

Re: [kvm-devel] [RFC] concurrent guest walker and instruction emulation

2007-12-19 Thread Avi Kivity
Marcelo Tosatti wrote: > Updated patch, now feature complete. Changes from last version: > > - Use __gfn_to_page in cmpxchg_pte() to avoid potential deadlock > - Add kvm_read_guest_inatomic() and use it in fetch() > - Make prefetch_page() use copy_from_user_inatomic() > - Pass grabbed page down to

Re: [kvm-devel] [PATCH 0/2] qemu: IDE/ATAPI emulation fixes

2007-12-19 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch series implements fixes to the IDE/ATAPI emulation > in qemu which affects access to the CD-ROM device preventing installation > of OpenSolaris guests because of an incorrect implementation of the MMC6 > GET_CONFIGURATION command when it was e

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernelsprior to tsc sync cleanup

2007-12-19 Thread Avi Kivity
Dor Laor wrote: >> > > >> > > vmx (and svm) allow us to add an offset to the physical tsc. We >> set it >> > > on startup to -tsc (so that an rdtsc on boot would return 0), and >> > > massage it on vcpu migration so that guest rdtsc is monotonic. >> > > >> > > The net effect is that tsc on a vcpu

Re: [kvm-devel] [ANNOUNCE] kvm-57 release

2007-12-19 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > On Tue, Dec 18, 2007 at 06:15:07PM +0200, Avi Kivity wrote: > >> The major focus for this release is a qemu-cvs merge, which brings many >> new features, some introduced by kvm developers. >> > > but didn't include

Re: [kvm-devel] [PATCH][UPDATE] kvm-userspace: simplify mmio callback

2007-12-19 Thread Avi Kivity
Christian Ehrhardt wrote: > Subject: [PATCH][UPDATE] kvm-userspace: simplify mmio callback > From: Christian Ehrhardt <[EMAIL PROTECTED]> > > Merging the read[bwlq]/write[bwlq] callback callback pointers to > mmio_read/write functions simplifies the callback interface. > On the qemu side it now us

Re: [kvm-devel] [PATCH] external module: remove dependency on

2007-12-19 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > Complements f2601fd2874b94d14dfcb21a3e1b84d7f3262b17 which made obsolete > the use of io_apic provided defines that were not being included for x86 > when the host kernel didn't have IO_APIC support. > > Reverts : > 5d6ea6b370ff9aae1dd7671b71e89351749fbeee >

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-19 Thread Avi Kivity
Glauber de Oliveira Costa wrote: > Changes in rate does not sound good. It's possibly what's screwing up > my paravirt clock implementation in smp. > You should renew the timebase on vcpu migration, and hook cpufreq so that changes in frequency are reflected in the timebase. > Since the host

Re: [kvm-devel] [PATCH] [RESEND] libkvm: NULL pointer dereference in kvm_destroy_phys_mem as used in kvm-56

2007-12-19 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > so just to be clear on this?, would you rather have these changes in a patch > series, or as unrelated patches with the second one fixing a formatting issue > that the first one triggered? > Oh, I misunderstood. The changes are related and should be in one

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-19 Thread Avi Kivity
Ingo Molnar wrote: > try this test perhaps in an SMP guest: > > http://people.redhat.com/mingo/time-warp-test/time-warp-test.c > > you can ignore TSC warps - but no GTOD or CLOCK warps should occur. > > On a broken guest kernel, I see gtod and clock warps. On a good guest kernel, I do not, p

Re: [kvm-devel] [PATCH] x86_64: fix problems due to use of "outb" to port 80 on some AMD64x2 laptops, etc.

2007-12-19 Thread Avi Kivity
David P. Reed wrote: > Avi Kivity wrote: >> kvm will forward a virtual machine's writes to port 0x80 to the real >> port. The reason is that the write is much faster than exiting and >> emulating it; the difference is measurable when compiling kernels. >> >&

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-19 Thread Avi Kivity
Ingo Molnar wrote: > * Avi Kivity <[EMAIL PROTECTED]> wrote: > > >> Avi Kivity wrote: >> >>> Testing shows wrmsr and rdtsc function normally. >>> >>> I'll try pinning the vcpus to cpus and see if that helps. >>> >

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-19 Thread Avi Kivity
Avi Kivity wrote: > > Testing shows wrmsr and rdtsc function normally. > > I'll try pinning the vcpus to cpus and see if that helps. > It does. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-19 Thread Avi Kivity
Avi Kivity wrote: > Ingo Molnar wrote: > >>> While the change mentions that it fixes a time warp bug, it also says >>> it should be rare. So clearly kvm smp tsc handing is buggy. >>> Ingo/Thomas, (or anybody else), do you have any insight as to what kvm

Re: [kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-18 Thread Avi Kivity
Ingo Molnar wrote: >> While the change mentions that it fixes a time warp bug, it also says >> it should be rare. So clearly kvm smp tsc handing is buggy. >> Ingo/Thomas, (or anybody else), do you have any insight as to what kvm >> can be doing wrong to trigger this behavior? >> > > hm. T

Re: [kvm-devel] KVM Test result, kernel 5ca24d9.., userspace 120e0c8..

2007-12-18 Thread Avi Kivity
Zhao, Yunfeng wrote: > Retested it on KVM-57. > It has been fixed already. > Actually, the fix is post kvm-57. What kvm-userspace.git commit did you test? -- error compiling committee.c: too many arguments to function -

[kvm-devel] Guest kernel hangs in smp kvm for older kernels prior to tsc sync cleanup

2007-12-18 Thread Avi Kivity
Booting RHEL 5 i386 in kvm with -no-kvm-irqchip -smp 4 will hang in udev. I bisected this to a change in the _guest_ kernel: > commit 95492e4646e5de8b43d9a7908d6177fb737b61f0 > Author: Ingo Molnar <[EMAIL PROTECTED]> > Date: Fri Feb 16 01:27:34 2007 -0800 > > [PATCH] x86: rewrite SMP TSC s

Re: [kvm-devel] [PATCH][UPDATE] kvm-userspace: sync icache for more architectures

2007-12-18 Thread Avi Kivity
Christian Ehrhardt wrote: > Subject: [PATCH][UPDATE] kvm-userspace: sync icache for more architectures > From: Christian Ehrhardt <[EMAIL PROTECTED]> > > A ia64 patch introduced kvm_sync_icache within a ifdef __ia64__, but the > concept of split caches is not bound to ia64. This patch replaces the

Re: [kvm-devel] [RFC] external module: compatibility with older kernels (SMP and non SMP)

2007-12-18 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch (which is composed of 3 different patches from a series) > has been validated to solve compilation issues observed with kvm-56 in x86 > with kernels older than 2.6.21 and are posted here for testing and debate. > > The main points accomplished

Re: [kvm-devel] PATCH vmx.c: add printk_ratelimit in vmx_intr_assist

2007-12-18 Thread Avi Kivity
Ryan Harper wrote: > * Ryan Harper <[EMAIL PROTECTED]> [2007-12-14 09:36]: > >> * Avi Kivity <[EMAIL PROTECTED]> [2007-12-14 08:49]: >> >>> Ryan Harper wrote: >>> >>>> Add printk_ratelimit check in front of printk. Thi

Re: [kvm-devel] [PATCH] [RESEND] libkvm: NULL pointer dereference in kvm_destroy_phys_mem as used in kvm-56

2007-12-18 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch eliminates the uninitialized mem pointer, using > instead the corresponding entry from the slots array to fix : > > libkvm.c:580: warning: 'mem' is used uninitialized in this function > > Also changes the formatting type for phys_addr to lo

Re: [kvm-devel] KVM Test result, kernel 5ca24d9.., userspace 120e0c8..

2007-12-18 Thread Avi Kivity
Zhao, Yunfeng wrote: > Save/restore still passes on IA32e host but fails on IA32 host. > This is now fixed. -- error compiling committee.c: too many arguments to function - SF.Net email is sponsored by: Check out the n

[kvm-devel] [ANNOUNCE] kvm-57 release

2007-12-18 Thread Avi Kivity
The major focus for this release is a qemu-cvs merge, which brings many new features, some introduced by kvm developers. Examples are improved usb support and the new -drive qemu option. While we've tested this carefully, this is a big merge so please handle this release with care and report

Re: [kvm-devel] [RFC] concurrent guest walker and instruction emulation

2007-12-18 Thread Avi Kivity
Marcelo Tosatti wrote: > Hi, > > The following is an improvement on top of an earlier patch by Izik. It > increases pagefault scalability for SMP guests by allowing concurrent > guest walking, allocation and instruction emulation on the fault path. > > The test being used is pft, which starts a nu

Re: [kvm-devel] merge kvm_flush_remote_tlbs when modifing shadow pte

2007-12-18 Thread Avi Kivity
Dong, Eddie wrote: >> Dong, Eddie wrote: >> >>> host side TLB flush can be merged together if multiple >>> spte need to be write-protected. >>> >>> Signed-off-by: Yaozu (Eddie) Dong <[EMAIL PROTECTED]> >>> >>> diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c >>> index 92ac0d1..749db46 100644

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-17 Thread Avi Kivity
Rusty Russell wrote: > On Wednesday 12 December 2007 23:54:00 Dor Laor wrote: > >> commit 763769621d271d92204ed27552d75448587c1ac0 >> Author: Dor Laor <[EMAIL PROTECTED]> >> Date: Wed Dec 12 14:52:00 2007 +0200 >> >> [virtio-net][PATCH] Don't arm tx hrtimer with a constant 50us each >> tra

Re: [kvm-devel] merge kvm_flush_remote_tlbs when modifing shadow pte

2007-12-17 Thread Avi Kivity
Dong, Eddie wrote: > host side TLB flush can be merged together if multiple > spte need to be write-protected. > > Signed-off-by: Yaozu (Eddie) Dong <[EMAIL PROTECTED]> > > diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c > index 92ac0d1..749db46 100644 > --- a/drivers/kvm/mmu.c > +++ b/drivers/k

Re: [kvm-devel] [PATCH] Make ioapic structure in irqchip seen by ia64

2007-12-17 Thread Avi Kivity
Zhang, Xiantao wrote: > Attached. > From: [EMAIL PROTECTED] <[EMAIL PROTECTED]> > Date: Mon, 17 Dec 2007 20:27:27 +0800 > Subject: [PATCH] kvm: make ioapic structure in irqchip seen by ia64 > > IA64 also needs to see ioapic structure in irqchip. > Applied, thanks. -- error compiling committe

Re: [kvm-devel] [PATCH] Make ioapic structure in irqchip seen by ia64

2007-12-17 Thread Avi Kivity
Zhang, Xiantao wrote: > From: [EMAIL PROTECTED] <[EMAIL PROTECTED]> > Date: Mon, 17 Dec 2007 20:27:27 +0800 > Subject: [PATCH] kvm: make ioapic structure in irqchip seen by ia64 > > IA64 also needs to see ioapic structure in irqchip. > Patch doesn't apply due to whitespace corruption. -- err

Re: [kvm-devel] [PATCH] No reason to disallow (phys_ram_alloc_offset + size) = phys_ram_size in qemu_ram_alloc

2007-12-17 Thread Avi Kivity
Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Mon, 17 Dec 2007 16:43:24 +0800 > Subject: [PATCH] kvm: qemu: No reason to disallow (phys_ram_alloc_offset > + size) = phys_ram_size > > No reason to disallow (phys_ram_alloc_offset + size) = phys_ram_size. > Applied, thanks

Re: [kvm-devel] [PATCH] [0/3] Make ioapic.c independent of x86 header files V2

2007-12-17 Thread Avi Kivity
Zhang, Xiantao wrote: > According to Avi's comments, Updated the patches. > [1/3] Create ioapic.h and lapic.h to hold their declarations. > [2/3] Moving ioapic{.h,.c} back to common directory. > [3/3] Moving out kvm_vcpu_kick from irq.c > Applied all, thanks. -- error compiling committee.

Re: [kvm-devel] [PATCH] Moving ioapic.h and ioapic.c back to common directory

2007-12-16 Thread Avi Kivity
Zhang, Xiantao wrote: > common-objs = $(addprefix ../../../virt/kvm/, kvm_main.o) > +common-objs += $(addprefix ../../../virt/kvm/, ioapic.o) > Just add ioapic.o behind kvm_main.o; it's a list. -- Any sufficiently difficult bug is indistinguishable from a feature.

Re: [kvm-devel] [PATCH] Make ioapic.c independent of x86 header files

2007-12-16 Thread Avi Kivity
Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Sun, 16 Dec 2007 23:41:50 +0800 > Subject: [PATCH] kvm: Split irq.h into two parts, and make ioapic > independent of > X86 header files. > > This patch splits irq.h into two parts, and make ioapic independent of > X86 header fi

Re: [kvm-devel] question on #UD emulation

2007-12-16 Thread Avi Kivity
Dong, Eddie wrote: > > >> Since we don't emulate 3Dnow instructions, a #UD will be >> injected instead. >> >> > OK, how many architecture specific instructiosn are emulated now? > Just vmcall/vmmcall (which is emulated once, then patched). > Or what is planed to be implemented? If

Re: [kvm-devel] question on #UD emulation

2007-12-16 Thread Avi Kivity
Dong, Eddie wrote: > A little bit suspicion for the usage model too :( > The CPUID feature list can't be changed dynamically, so I doutb > if a real user will give up performance at beginning when he/she > starts the guest for "maybe" future migration cross host platform. > > A VT or SVM enabled ma

Re: [kvm-devel] [PATCH] external module: include apicdef.h for kernel < 2.6.21

2007-12-16 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > The following patch fixes building the kvm module for kernels older than > 2.6.21 and which were missing an include to in > resulting in the following error : > > include/asm/io_apic.h:61: error: 'MAX_IO_APICS' undeclared here (not in a > function) > >

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-16 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: > On Thu, Dec 13, 2007 at 03:32:46PM +0200, Avi Kivity wrote: > >> Notes: >> If you use the modules bundled with kvm-56, you can use any version >> of Linux from 2.6.9 upwards. >> > > the external module (once

Re: [kvm-devel] question on #UD emulation

2007-12-16 Thread Avi Kivity
Dong, Eddie wrote: > Avi/Anthony: > Following commit added #UD trap in KVM and do emulation in KVM. > It is good to avoid the mis hypercall instruction issue, but I am not > sure if it will have any serious side effect. I am blind to AMD > instruction, I assume, for example, AMD 3D now instru

Re: [kvm-devel] [PATCH] x86_64: fix problems due to use of "outb" to port 80 on some AMD64x2 laptops, etc.

2007-12-14 Thread Avi Kivity
David P. Reed wrote: > Replace use of outb to "unused" diagnostic port 0x80 for time delay > with udelay based time delay on x86_64 architecture machines. Fix for > bugs 9511 and 6307 in bugzilla, plus bugs reported in > bugzilla.redhat.com. > > Derived from suggestion (that didn't compile) by Pav

Re: [kvm-devel] PATCH vmx.c: add printk_ratelimit in vmx_intr_assist

2007-12-14 Thread Avi Kivity
Ryan Harper wrote: > Add printk_ratelimit check in front of printk. This prevents spamming > of the message during 32-bit ubuntu 6.06server install. Previously, it > would hang during the partition formatting stage. > Applied, but this is worrying. Do you know whether this is a regression?

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-14 Thread Avi Kivity
Theodore Tso wrote: > BTW, there were changes between 2.6.24-rc3 and -rc5 such that there > are merge conflicts when I tried to do a git pull from kvm/master unto > Linus's git mainline. > > In general I merge regularly and resolve conflicts. Currently kvm.git is based on 2.6.24-rc5. -- Any

Re: [kvm-devel] [PATCH][0/22] Patches to use arch concept to hold arch-speicif fileds for kvm_vcpu and kvm strucuture.

2007-12-14 Thread Avi Kivity
Zhang, Xiantao wrote: > Hi, Avi > As you know, we have to change to kvm_vcpu_arch concept since meet > various issues about #includes. > This patches enables it. I also prepared a series of patches to split > kvm with similar idea. > Now, kvm.h includes x86.h by default. X86.c needs includes kvm.

Re: [kvm-devel] [PATCH] align gdbstub with QEMU

2007-12-14 Thread Avi Kivity
Jan Kiszka wrote: > BTW, are there plans to merge the kvm branch into qemu at some point and > continue development unitedly with the qemu people? > There is the intent, but no concrete plans. What is missing is someone to prepare a suitable patchset for qemu-devel; that's no small amount of

Re: [kvm-devel] [PATCH] align gdbstub with QEMU

2007-12-14 Thread Avi Kivity
Jan Kiszka wrote: > Jan Kiszka wrote: > >> We've noticed some problems with current gdbstub in kvm's qemu: >> >> # qemu-system-x86_64 -hda myimage -S -s & >> # gdb >> (gdb) tar re :1234 >> Remote debugging using :1234 >> Remote 'g' packet reply is too long: >> 000

Re: [kvm-devel] [PATCH][10/22] kvm: Portability : Moving pio_data, pio, mmio_fault_cr2 to arch.

2007-12-14 Thread Avi Kivity
Carsten Otte wrote: > Zhang, Xiantao wrote: >> diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c >> index 530c391..2d2ff55 100644 >> --- a/drivers/kvm/kvm_main.c >> +++ b/drivers/kvm/kvm_main.c >> @@ -670,7 +670,7 @@ static int kvm_vcpu_fault(struct vm_area_struct >> *vma, struct vm_faul

Re: [kvm-devel] [PATCH][0/22] Patches to use arch concept to hold arch-speicif fileds for kvm_vcpu and kvm strucuture.

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: > Hi, Avi > As you know, we have to change to kvm_vcpu_arch concept since meet > various issues about #includes. > This patches enables it. I also prepared a series of patches to split > kvm with similar idea. > Now, kvm.h includes x86.h by default. X86.c needs includes kvm.

Re: [kvm-devel] [PATCH][5/22] kvm portability: Moving apic and apic_base to kvm_vcpu arch.

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Fri, 14 Dec 2007 00:33:56 +0800 > Subject: [PATCH] kvm portability: Moving apic and apic_base to kvm_vcpu > arch. > > This patches moving apic and apic_base to kvm_vcpu_arch. > And use a macro apic(v) to simplifily get apic fro

Re: [kvm-devel] [PATCH] VMX: inject high priority interrupts first

2007-12-13 Thread Avi Kivity
Dong, Eddie wrote: > This is not necessary, vector doesn;t mean priority. > > Remember I ever had a talk with Avi that user level irqchip could only support > one vector pending in kernel like you mentioned too. On the other hand, > if we have multiple pending vectors, we will lose priority. The po

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
Pelle wrote: Patch applied, rebuild (twice) but still the same error. Sorry, there was a type in the patch. Please change cpmxchg64 to cmpxchg64 in kernel/external-module-compat.h, or apply the attached corrected patch on a clean kvm-56. Avi Kivity wrote: Pelle wrote: I get the

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
Alexey Eremenko wrote: > > Hi Pelle! > > Yes, You're right, KVM-56 doesn't compiles on 32-bit systems. (tested > on openSUSE 10.3, 32-bit) > It compiles on 32-bit systems. It doesn't compile on 32-bit non-pae systems. -- error compiling committee.c: too many arguments to function -

Re: [kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
Pelle wrote: I get the following error when modprobing the new module: WARNING: Error inserting kvm (/lib/modules/2.6.22-14-generic/extra/kvm.ko): Unknown symbol in module, or unknown parameter (see dmesg) kvm: Unknown symbol cmpxchg64 Ubuntu 7.10 32-bits, C2D E6300 Please try the atta

Re: [kvm-devel] [2/6][PATCH] kvm: Moving memslot_id to x86.h

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: > Avi Kivity wrote: > >> Zhang, Xiantao wrote: >> >>> From: Zhang Xiantao <[EMAIL PROTECTED]> >>> Date: Tue, 11 Dec 2007 20:45:48 +0800 >>> Subject: [PATCH] kvm: Moving memslot_id to x86.h >>> >>>

Re: [kvm-devel] [3/6][PATCH] kvm: kvm structure split into common fileds and arch-dependent ones

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 20:47:56 +0800 > Subject: [PATCH] kvm: kvm structure split. > > Using macro KVM_COMM to hold kvm common fields > as kvm_vcpu does. And, every arch defines its kvm structure > separately. > > + struct k

Re: [kvm-devel] [2/6][PATCH] kvm: Moving memslot_id to x86.h

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 20:45:48 +0800 > Subject: [PATCH] kvm: Moving memslot_id to x86.h > > Since it is not called in kvm_main.c, and it also will block > kvm structure split, so moved it out. > memslot_id() is not x86 specific.

[kvm-devel] [ANNOUNCE] kvm-56 release

2007-12-13 Thread Avi Kivity
This restores live migration support which has been broken for a couple of releases. Also, if you had Java problems please test kvm-56, as it has some nx related permission fixes. Changes from kvm-55: - Generalize exception handling mechanism - fix x86 emulator eflags handling - avoid exit to u

Re: [kvm-devel] [PATCH] LAPIC: minor debugging compile fix

2007-12-13 Thread Avi Kivity
Joerg Roedel wrote: > This patch fixes a compile error of the LAPIC code with APIC debugging > enabled. > > Applied, thanks. -- error compiling committee.c: too many arguments to function - SF.Net email is sponsored b

Re: [kvm-devel] [PATCH] Fix a typo for MAX_BIOS_SIZE

2007-12-13 Thread Avi Kivity
Zhang, Xiantao wrote: > Thank Young for reporting it. > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 08:22:19 +0800 > Subject: [PATCH] kvm: qemu : Fix a typo. > > A typo for defieing max_bios_size. > Signed-off-by: Zhang Xiantao <[EMAIL PROTECTED]> > Applied, thanks. -

Re: [kvm-devel] [PATCH] emulated cmpxchg8b should be atomic on i386

2007-12-13 Thread Avi Kivity
Marcelo Tosatti wrote: > Emulate cmpxchg8b atomically on i386. This is required to avoid a guest > pte walker from seeing a splitted write. > Applied, thanks. -- error compiling committee.c: too many arguments to function -

Re: [kvm-devel] [PATCH] Fix SMP shadow instantiation race

2007-12-13 Thread Avi Kivity
Marcelo Tosatti wrote: > There is a race where VCPU0 is shadowing a pagetable entry while VCPU1 > is updating it, which results in a stale shadow copy. > > Fix that by comparing the contents of the cached guest pte with the > current guest pte after write-protecting the guest pagetable. > > App

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-13 Thread Avi Kivity
Arnd Bergmann wrote: > On Tuesday 11 December 2007, Avi Kivity wrote: > >> Heiko Carstens wrote: >> >>> On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: >>> >>> >>>> arch/*/kvm/ arch dependent kvm code >>&

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Sam Ravnborg wrote: > >>> So use arch/*/virt/kvm/ if kvm really requires >>> a subdirectory of it own. Preferably not. >>> A handful of files named kvm* does not warrant their own >>> subdirectory IMO. >>> >>> >>> >> We'll have 5-6 x86 specific files. >> >> Where do you suggest we place th

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Sam Ravnborg wrote: > On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: > >> KVM is due to receive support for multiple architectures (ppc, ia64, and >> s390, in addition to the existing x86), hopefully in time for the 2.6.25 >> merge window. It is awkwa

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Heiko Carstens wrote: > On Tue, Dec 11, 2007 at 11:47:39AM +0200, Avi Kivity wrote: > >> KVM is due to receive support for multiple architectures (ppc, ia64, and >> s390, in addition to the existing x86), hopefully in time for the 2.6.25 >> merge window. It is awkwa

Re: [kvm-devel] [PATCH] SVM: support writing 0 to K8 performance counter control registers

2007-12-11 Thread Avi Kivity
Joerg Roedel wrote: > This patch is a slightly improved version of a previously submitted patch. It > lets SVM ignore writes of the value 0 to the performance counter control > registers. Thus enabling them will still fail in the guest. This is required > to boot Windows Vista 64bit. > > Signed-o

Re: [kvm-devel] [PATCH] SVM: support writing 0 to K8 performance counter control registers

2007-12-11 Thread Avi Kivity
Joerg Roedel wrote: > This patch is a slightly improved version of a previously submitted patch. It > lets SVM ignore writes of the value 0 to the performance counter control > registers. Thus enabling them will still fail in the guest. This is required > to boot Windows Vista 64bit. > > Appl

Re: [kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
Christian Borntraeger wrote: > Am Dienstag, 11. Dezember 2007 schrieb Avi Kivity: > >> KVM is due to receive support for multiple architectures (ppc, ia64, and >> s390, in addition to the existing x86), hopefully in time for the 2.6.25 >> merge window. It is awkwa

Re: [kvm-devel] [KVM/qemu] check page size of qemu and host at intialization time

2007-12-11 Thread Avi Kivity
Zhang, Xiantao wrote: > From: Zhang Xiantao <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 18:54:27 +0800 > Subject: [PATCH] kvm: qemu: Check page size at initialization time. > > Currently, we assume Qemu target page size = HOST page > size, this patch check them. if not equal, print error > info an

Re: [kvm-devel] [PATCH][0/24] Patches to enable ia64 support in userspace.

2007-12-11 Thread Avi Kivity
Zhang, Xiantao wrote: > Hi, Avi > This series of patches are used to make kvm/ia64 userspace work > in a clean way. In these patches, we have very few code for current > source, except some necessary changes for ia64 target. Current ia64 > support doesn't include processor and memory emulatio

[kvm-devel] [RFC] Proposed new directory layout for kvm and virtualization

2007-12-11 Thread Avi Kivity
KVM is due to receive support for multiple architectures (ppc, ia64, and s390, in addition to the existing x86), hopefully in time for the 2.6.25 merge window. It is awkward to place the new arch support in drivers/kvm/, so I'd like to propose the following new layout: virt/ top-leve

Re: [kvm-devel] [PATCH] emulated cmpxchg8b should be atomic on i386

2007-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: > Emulate cmpxchg8b atomically on i386. This is required to avoid a guest > pte walker from seeing a splitted write. > > Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> > > diff --git a/drivers/kvm/x86.c b/drivers/kvm/x86.c > index 9db4e32..d58d795 100644 > --- a/drivers/k

Re: [kvm-devel] [PATCH] Fix SMP shadow instantiation race

2007-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: > On Mon, Dec 10, 2007 at 07:07:54PM +0200, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> There is a race where VCPU0 is shadowing a pagetable entry while VCPU1 >>> is updating it, which results in a stale shadow cop

Re: [kvm-devel] [PATCH] Fix SMP shadow instantiation race

2007-12-10 Thread Avi Kivity
Marcelo Tosatti wrote: > There is a race where VCPU0 is shadowing a pagetable entry while VCPU1 > is updating it, which results in a stale shadow copy. > > Fix that by comparing the contents of the cached guest pte with the > current guest pte after write-protecting the guest pagetable. > > Attache

<    11   12   13   14   15   16   17   18   19   20   >