Re: [kvm-devel] [PATCH] Abort if gcc4 was used to compile qemu and kvm is not enabled

2007-10-09 Thread Avi Kivity
Byron Stanoszek wrote: > Even when I first started using > KVM, I had no positive feedback that KVM was even working properly (was the > device node created? am I using a cpu with the correct extensions? etc). I > eventually figured out that if 'lsmod' showed kvm-intel.ko usage > 0, then I > knew i

Re: [kvm-devel] [PATCH] Abort if gcc4 was used to compile qemu and kvm is not enabled

2007-10-09 Thread Anthony Liguori
Carlo Marcelo Arenas Belon wrote: > On Mon, Oct 08, 2007 at 02:29:32PM -0500, Anthony Liguori wrote: > > 3) We do nothing, add a warning to the compilation for the users to read at > compile time (most of them not aware that they should be using gcc-3.x instead > as they are used to see all the

Re: [kvm-devel] [PATCH] Abort if gcc4 was used to compile qemu and kvm is not enabled

2007-10-08 Thread Carlo Marcelo Arenas Belon
On Mon, Oct 08, 2007 at 02:29:32PM -0500, Anthony Liguori wrote: > > Eventually, KVM will merge with upstream QEMU. In that case, many > people will be using QEMU without the desiring to use KVM. We don't > want to introduce behavior in QEMU that is unmergable with upstream QEMU > b/c that wi

Re: [kvm-devel] [PATCH] Abort if gcc4 was used to compile qemu and kvm is not enabled

2007-10-08 Thread Anthony Liguori
Byron Stanoszek wrote: > On Mon, 8 Oct 2007, Anthony Liguori wrote: >> >> If you're going to do anything, a firm warning when compiling with a >> GCC4 override would be the best thing. > > I disagree with the compile warning. There have been times in the past > when > I've forgotten to "insmod kvm

Re: [kvm-devel] [PATCH] Abort if gcc4 was used to compile qemu and kvm is not enabled

2007-10-08 Thread Byron Stanoszek
On Mon, 8 Oct 2007, Anthony Liguori wrote: > Carlo Marcelo Arenas Belon wrote: >> Using gcc4 to compile qemu will generate broken code for its cpu emulation >> but should be fine if using kvm only. >> >> This will allow users that have no access to gcc4 on their platforms to at >> least get kvm co

Re: [kvm-devel] [PATCH] Abort if gcc4 was used to compile qemu and kvm is not enabled

2007-10-08 Thread Anthony Liguori
Carlo Marcelo Arenas Belon wrote: > Using gcc4 to compile qemu will generate broken code for its cpu emulation > but should be fine if using kvm only. > > This will allow users that have no access to gcc4 on their platforms to at > least get kvm compiled and use it while preventing them to run a br

[kvm-devel] [PATCH] Abort if gcc4 was used to compile qemu and kvm is not enabled

2007-10-08 Thread Carlo Marcelo Arenas Belon
Using gcc4 to compile qemu will generate broken code for its cpu emulation but should be fine if using kvm only. This will allow users that have no access to gcc4 on their platforms to at least get kvm compiled and use it while preventing them to run a broken qemu if kvm is not available. This is