Luca,
One more comment on your patch: the logic in the following condition
does not fit the comment bellow it.
On Mon, Aug 13, 2007 at 10:37:41PM +0200, Luca Tettamanti wrote:
> +if (use_dynamic_ticks() && dynticks_create_timer()) {
> +/* dynticks disabled or failed to create
>> I like it ;) I have some comments (and a reworked patch at the end):
>>
>
>And thanks a lot for that.
>
>>
>> Plus, in this way you change the behaviour from "always try RTC under
>> Linux" to "don't use RTC is dynticks is enabled".
>> Is this what you really want?
>
>I don't know whether this i
On Mon, Aug 13, 2007 at 10:37:41PM +0200, Luca Tettamanti wrote:
>
> I like it ;) I have some comments (and a reworked patch at the end):
>
And thanks a lot for that.
>
> Plus, in this way you change the behaviour from "always try RTC under
> Linux" to "don't use RTC is dynticks is enabled".
>
Thank you (Luca and Thiemo) for your prompt review and comments!
On Tue, Aug 14, 2007 at 12:06:20AM +0100, Thiemo Seufer wrote:
> Luca Tettamanti wrote:
> [snip]
> > I've implemented some of my suggestions in the following patch - rebased
> > to kvm-userspace current git since it's easier to test
Il Mon, Aug 13, 2007 at 05:42:55PM +0300, Dan Kenigsberg ha scritto:
> "Dynamic ticks" in Qemu: have a SIGALRM generated only when it is
> needed, instead of every 1 millisecond. This patch requires that the
> host supports high resolution timers, since it arms a POSIX timer to the
> nearest Qemu
"Dynamic ticks" in Qemu: have a SIGALRM generated only when it is
needed, instead of every 1 millisecond. This patch requires that the
host supports high resolution timers, since it arms a POSIX timer to the
nearest Qemu timer's expiry time (which might be rather near).
I tried to send a previous