[kvm-devel] [PATCH] KVM: VMX cannot yet handle migration-after-preemption, so disable it

2007-07-24 Thread Gregory Haskins
This patch applies to the preempt-hooks branch to enable KVM to function properly on VMX. With preemption enabled, the KVM context can get scheduled out at arbitrary points. The preempt-hooks allow us to correctly restore the host state while being preemptible, but preemption causes problems on

Re: [kvm-devel] [PATCH] KVM: VMX cannot yet handle migration-after-preemption, so disable it

2007-07-24 Thread Avi Kivity
Gregory Haskins wrote: This patch applies to the preempt-hooks branch to enable KVM to function properly on VMX. With preemption enabled, the KVM context can get scheduled out at arbitrary points. The preempt-hooks allow us to correctly restore the host state while being preemptible, but

Re: [kvm-devel] [PATCH] KVM: VMX cannot yet handle migration-after-preemption, so disable it

2007-07-24 Thread Gregory Haskins
On Wed, 2007-07-25 at 06:20 +0300, Avi Kivity wrote: I'd rather wait for the real fix, especially as this is an experimental branch. Can you provide details of the issue? Sure. Keep in mind I am working with the RT kernel, so things might be tighter and/or different than the vanilla

Re: [kvm-devel] [PATCH] KVM: VMX cannot yet handle migration-after-preemption, so disable it

2007-07-24 Thread Gregory Haskins
On Wed, 2007-07-25 at 07:13 +0300, Avi Kivity wrote: Preemption disabled yes, but interrupts? How do you think I found this? ;) From smp_call_function_single in -rt: WARN_ON(irqs_disabled()); IIRC I picked the place where sched_in is called to have interrupts enabled, but maybe -rt