Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-10 Thread Greg KH
On Sun, Mar 09, 2008 at 12:51:15PM +0530, Balaji Rao wrote: On Sunday 09 March 2008 12:33:07 pm Greg KH wrote: snip Hi, This patch does not fix it all! The problem is in fact more involved. I also get these BUG reports when I reload kvm-intel. BUG kmalloc-8:

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-10 Thread Balaji Rao
On Monday 10 March 2008 09:22:00 pm Greg KH wrote: On Sun, Mar 09, 2008 at 12:51:15PM +0530, Balaji Rao wrote: On Sunday 09 March 2008 12:33:07 pm Greg KH wrote: snip Hi, This patch does not fix it all! The problem is in fact more involved. I also get these BUG

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-10 Thread Greg KH
On Sun, Mar 09, 2008 at 11:49:26AM +0100, Mikael Pettersson wrote: Balaji Rao writes: Yes the idea works. One more memset is needed in sysdev_register. Here's the final patch. diff --git a/drivers/base/sys.c b/drivers/base/sys.c index 2f79c55..7c839d9 100644 ---

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-10 Thread Greg KH
On Mon, Mar 10, 2008 at 09:35:56PM +0530, Balaji Rao wrote: On Monday 10 March 2008 09:22:00 pm Greg KH wrote: On Sun, Mar 09, 2008 at 12:51:15PM +0530, Balaji Rao wrote: On Sunday 09 March 2008 12:33:07 pm Greg KH wrote: snip Hi, This patch does not fix it all! The

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-09 Thread Mikael Pettersson
Balaji Rao writes: Yes the idea works. One more memset is needed in sysdev_register. Here's the final patch. diff --git a/drivers/base/sys.c b/drivers/base/sys.c index 2f79c55..7c839d9 100644 --- a/drivers/base/sys.c +++ b/drivers/base/sys.c @@ -133,6 +133,7 @@ int

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-08 Thread Balaji Rao
On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: snip Where exactly in the code does that happen? kobjects should not be reused as that implies that they are static, and

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-08 Thread Balaji Rao
On Sunday 09 March 2008 10:36:49 am Greg KH wrote: On Sun, Mar 09, 2008 at 03:37:16AM +0530, Balaji Rao wrote: On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: snip

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-08 Thread Balaji Rao
On Sunday 09 March 2008 12:03:08 pm Greg KH wrote: On Sun, Mar 09, 2008 at 03:37:16AM +0530, Balaji Rao wrote: On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: snip

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-08 Thread Greg KH
On Sun, Mar 09, 2008 at 12:06:02PM +0530, Balaji Rao wrote: On Sunday 09 March 2008 12:03:08 pm Greg KH wrote: On Sun, Mar 09, 2008 at 03:37:16AM +0530, Balaji Rao wrote: On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote:

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-08 Thread Balaji Rao
On Sunday 09 March 2008 12:33:07 pm Greg KH wrote: snip Hi, This patch does not fix it all! The problem is in fact more involved. I also get these BUG reports when I reload kvm-intel. BUG kmalloc-8: Object already free [ 74.696570]

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-07 Thread Avi Kivity
Greg KH wrote: and is on my TODO list, slowly getting closer to the top... Strange. On my TODO list, things slowly get pushed to the bottom. -- Any sufficiently difficult bug is indistinguishable from a feature. -

[kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-06 Thread Balaji Rao
Hi greg, When I remove only the kvm-intel module without removing the kvm module itself, I get an error saying that a kobject is trying to be reinitialized. Its because of the fact that kvm reuses a kobject in kvm_init when calling sysdev_register. This patch fixes kobject_cleanup by marking

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-06 Thread Greg KH
On Thu, Mar 06, 2008 at 10:23:18PM +0530, Balaji Rao wrote: Hi greg, When I remove only the kvm-intel module without removing the kvm module itself, I get an error saying that a kobject is trying to be reinitialized. Its because of the fact that kvm reuses a kobject in kvm_init when calling

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-06 Thread Balaji Rao
On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: snip Where exactly in the code does that happen? kobjects should not be reused as that implies that they are static, and not dynamically allocated, right? Which kobject is this? Yes, its static. Here's the code from virt/kvm_main.c:1269

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

2008-03-06 Thread Greg KH
On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: snip Where exactly in the code does that happen? kobjects should not be reused as that implies that they are static, and not dynamically allocated, right? Which kobject is