Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-05 Thread Avi Kivity
Hollis Blanchard wrote: > Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> > Applied, thanks. Note that there is free advertising space between the summary and the signoff that you can use to explain the change. -- error compiling committee.c: too many arguments to function --

Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-05 Thread Avi Kivity
Carsten Otte wrote: > Avi Kivity wrote: > >> What about merging kvm_cpu_has_interrupt() into _runnable()? >> >> My feeling is that we can keep it separated. >> > On s390 there is a difference between has_interrupt and not runnable: > CPUs can be in stopped state, and they can be in enabled

Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-05 Thread Carsten Otte
Avi Kivity wrote: > What about merging kvm_cpu_has_interrupt() into _runnable()? > > My feeling is that we can keep it separated. On s390 there is a difference between has_interrupt and not runnable: CPUs can be in stopped state, and they can be in enabled wait (enabled for interrupts, similar t

Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-04 Thread Avi Kivity
Carsten Otte wrote: > Hollis Blanchard wrote: >> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> > Acked-by: Carsten Otte <[EMAIL PROTECTED]> > > We'll need this too on big iron. What about merging kvm_cpu_has_interrupt() into _runnable()? My feeling is that we can keep it separated. -- err

Re: [kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-04 Thread Carsten Otte
Hollis Blanchard wrote: > Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> Acked-by: Carsten Otte <[EMAIL PROTECTED]> We'll need this too on big iron. - SF.Net email is sponsored by: The Future of Linux Business White Pape

[kvm-devel] [PATCH] RFC: Create kvm_arch_vcpu_runnable() function

2007-12-03 Thread Hollis Blanchard
Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- vcpu->mp_state looks like an arch-specific field, so what do we think about this patch? It might make sense to fold the kvm_cpu_has_interrupt() test inside kvm_arch_vcpu_runnable() as well. 2 files changed, 9 insertions(+), 3 deletions(-) dri