Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-10 Thread Anthony Liguori
Avi Kivity wrote: > Anthony Liguori wrote: >>> QEMU uses an array for PIO but a table for MMIO. I figured it would be best to just use the same table. >>> >>> Or the same array? >> >> Indexed by the address or just sorted and searchable? MMIO addresses >> are rather sparse so the

Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-10 Thread Avi Kivity
Anthony Liguori wrote: >> >>> >>> QEMU uses an array for PIO but a table for MMIO. I figured it would >>> be best to just use the same table. >> >> Or the same array? > > Indexed by the address or just sorted and searchable? MMIO addresses > are rather sparse so the former seems like the only s

Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-10 Thread Anthony Liguori
Avi Kivity wrote: > Anthony Liguori wrote: >> Avi Kivity wrote: >>> Anthony Liguori wrote: >>> This patch attempts to clean up kvmctl so that it can be more easily made to work for multiple architectures and to support more emulation. It introduces a io dispatch mechanis

Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-10 Thread Avi Kivity
Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >> >>> This patch attempts to clean up kvmctl so that it can be more easily >>> made to >>> work for multiple architectures and to support more emulation. >>> >>> It introduces a io dispatch mechanism. This mechanism supports

Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-10 Thread Anthony Liguori
Avi Kivity wrote: > Anthony Liguori wrote: > >> This patch attempts to clean up kvmctl so that it can be more easily made to >> work for multiple architectures and to support more emulation. >> >> It introduces a io dispatch mechanism. This mechanism supports subpage >> granularity but is optim

Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-10 Thread Avi Kivity
Anthony Liguori wrote: > This patch attempts to clean up kvmctl so that it can be more easily made to > work for multiple architectures and to support more emulation. > > It introduces a io dispatch mechanism. This mechanism supports subpage > granularity but is optimized to efficiently cover regi

Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-09 Thread Hollis Blanchard
On Tue, 2007-10-09 at 16:40 -0500, Anthony Liguori wrote: > This patch attempts to clean up kvmctl so that it can be more easily made to > work for multiple architectures and to support more emulation. > > It introduces a io dispatch mechanism. This mechanism supports subpage > granularity but is

Re: [kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-09 Thread Anthony Liguori
This patch won't apply with the previous two patches applied. I was meant to be independently reviewable. I have a merged patch that I'll send out tomorrow but please still comment on this version :-) Regards, Anthony Liguori Anthony Liguori wrote: > This patch attempts to clean up kvmctl so

[kvm-devel] [PATCH] Use a table to dispatch IO requests in kvmctl

2007-10-09 Thread Anthony Liguori
This patch attempts to clean up kvmctl so that it can be more easily made to work for multiple architectures and to support more emulation. It introduces a io dispatch mechanism. This mechanism supports subpage granularity but is optimized to efficiently cover regions of pages too. It's a 64-bit