Re: [kvm-devel] [PATCH] add virtio disk geometry feature

2008-04-17 Thread Ryan Harper
* Anthony Liguori <[EMAIL PROTECTED]> [2008-04-16 16:33]: > Rusty Russell wrote: > >On Thursday 17 April 2008 04:56:37 Ryan Harper wrote: > > > >>From: Ryan Harper <[EMAIL PROTECTED]> > >> > >>Rather than faking up some geometry, allow the backend to push the disk > >>geometry via virtio pci conf

Re: [kvm-devel] [PATCH] add virtio disk geometry feature

2008-04-16 Thread Hollis Blanchard
On Wednesday 16 April 2008 16:32:30 Anthony Liguori wrote: > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > --- a/drivers/block/virtio_blk.c > > +++ b/drivers/block/virtio_blk.c > > @@ -157,10 +157,25 @@ static int virtblk_ioctl(struct inode *i > >  /* We provide getgeo

Re: [kvm-devel] [PATCH] add virtio disk geometry feature

2008-04-16 Thread Anthony Liguori
Rusty Russell wrote: > On Thursday 17 April 2008 04:56:37 Ryan Harper wrote: > >> From: Ryan Harper <[EMAIL PROTECTED]> >> >> Rather than faking up some geometry, allow the backend to push the disk >> geometry via virtio pci config option. Keep the old geo code around for >> compatibility. >>

Re: [kvm-devel] [PATCH] add virtio disk geometry feature

2008-04-16 Thread Rusty Russell
On Thursday 17 April 2008 04:56:37 Ryan Harper wrote: > From: Ryan Harper <[EMAIL PROTECTED]> > > Rather than faking up some geometry, allow the backend to push the disk > geometry via virtio pci config option. Keep the old geo code around for > compatibility. Hi Ryan, Looks good! Some brief

[kvm-devel] [PATCH] add virtio disk geometry feature

2008-04-16 Thread Ryan Harper
From: Ryan Harper <[EMAIL PROTECTED]> Rather than faking up some geometry, allow the backend to push the disk geometry via virtio pci config option. Keep the old geo code around for compatibility. Signed-off-by: Ryan Harper <[EMAIL PROTECTED]> Reviewed-by: Anthony Liguori <[EMAIL PROTECTED]> di