Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v3)

2008-02-24 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, I'm sorry for messing up the last patch, I shouldn't work that late... I added the changes to pc.h (VGA_RAM_SIZE) and split up the patch in a qemu part and a vgabios part. Applied, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-22 Thread Arne Brutschy
Hi all, On Fr, 2008-02-22 at 03:11 +0100, Andreas Winkelbauer wrote: I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The crash was caused by a really _dirty_ hack in a kvm specific part of vga.c (it took me at least an hour to find this amazing piece of code... at least

[kvm-devel] [PATCH] fix widescreen resolution issues (v3)

2008-02-22 Thread Andreas Winkelbauer
hi, I'm sorry for messing up the last patch, I shouldn't work that late... I added the changes to pc.h (VGA_RAM_SIZE) and split up the patch in a qemu part and a vgabios part. cheers, Andi --- kvm-61.orig/qemu/hw/vga_int.h 2008-02-19 15:58:28.0 +0100 +++ kvm-61/qemu/hw/vga_int.h

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-22 Thread Andreas Winkelbauer
hi, @Arne: Could you please test the patch with your setup? I hope it works this time... Yesno. It does (at least kvm does not crash), but it shows the same dialog problems as reported by Leslie: I'm quite sure that this issue isn't related to the widescreen fixes. This visual bug seems to

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. in vgabios/vbetables-gen.c I changed the video memory from 8MB to 16MB which is sufficient for resolutions up to 2560x1600. I've also added some more video modes

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Izik Eidus
On Thu, 2008-02-21 at 11:29 +0100, Arne Brutschy wrote: Hi, On Mi, 2008-02-20 at 22:16 +0100, Andreas Winkelbauer wrote: the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. I would appreciate any suggestions, comments and of course testing.

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Arne Brutschy
Hi, On Mi, 2008-02-20 at 22:16 +0100, Andreas Winkelbauer wrote: the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. I would appreciate any suggestions, comments and of course testing. Thanks for the patch, Andreas! You found the magic limitation to

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Arne Brutschy
On Do, 2008-02-21 at 10:56 +0200, Avi Kivity wrote: What about VGA_RAM_SIZE in qemu/hw/pc.h? On Do, 2008-02-21 at 12:40 +0200, Izik Eidus wrote: there is a DEFINE name VGA_RAM_SIZE or something like that D'oh. Must have missed it. :\ Thanks! Unfortunately, it still does not work. Qemu crashes

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Andreas Winkelbauer
hi, What about VGA_RAM_SIZE in qemu/hw/pc.h? I already tried changing the VGA_RAM_SIZE value in pc.h to 16 * 1024 * 1024 (16MB), but then kvm crashes when the guest os switches to graphics mode. Changing VGA_RAM_SIZE in pc.h to 16MB works when I use the latest cvs snapshot of qemu (didn't

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Andreas Winkelbauer
hi, D'oh. Must have missed it. :\ Thanks! Unfortunately, it still does not work. Qemu crashes now as windows switches to graphics mode. Safe mode does not work either.. For now I'd suggest trying the following: * download the latest qemu cvs snapshot cvs -z3 -d:pserver:[EMAIL

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Andreas Winkelbauer
hi, * copy the modified vgabios.bin to the qemu dir wget http://www.wina.at/vgabios.bin # cp vgabios.bin /usr/local/qemu-cvs/share/qemu (as root; change to target path according to the prefix you used above) I'm guess I've uploaded to wrong vgabios.bin, so if you don't want to compile it

[kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-21 Thread Andreas Winkelbauer
hi, I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The crash was caused by a really _dirty_ hack in a kvm specific part of vga.c (it took me at least an hour to find this amazing piece of code... at least the HACK ALERT was a good hint ;-) ). I've attached the patch. It

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-21 Thread Leslie Mann
Andreas Winkelbauer andreas.winkelbauer at gmx.at writes: hi, I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The crash was caused by a really _dirty_ hack in a kvm specific part of vga.c (it took me at least an hour to find this amazing piece of code... at least

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-21 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The crash was caused by a really _dirty_ hack in a kvm specific part of vga.c (it took me at least an hour to find this amazing piece of code... at least the HACK ALERT was a good hint ;-)

[kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-20 Thread Andreas Winkelbauer
hi, the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. in vgabios/vbetables-gen.c I changed the video memory from 8MB to 16MB which is sufficient for resolutions up to 2560x1600. I've also added some more video modes (up to 2560x1600) with 16, 24,