Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-09 Thread Marcelo Tosatti
On Wed, Jan 09, 2008 at 11:06:21AM +0100, Andrea Arcangeli wrote: > On Tue, Jan 08, 2008 at 09:42:13AM -0600, Anthony Liguori wrote: > > Instead of allocating a node for each page, you could use page->private > > page->lru is probably better for this so splice still works > etc... (the struct pag

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-09 Thread Andrea Arcangeli
On Tue, Jan 08, 2008 at 09:42:13AM -0600, Anthony Liguori wrote: > Instead of allocating a node for each page, you could use page->private page->lru is probably better for this so splice still works etc... (the struct page isn't visible to the guest VM so it's free to use) --

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Rusty Russell
On Wednesday 09 January 2008 03:18:13 Avi Kivity wrote: > Marcelo Tosatti wrote: > > Do you have any suggestion on how to retrieve the IRQ of the virtio > > device, or some other notification mechanism? Unfortunately, irqs are logically assigned to virtio queues, not devices. Yet configuration in

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Anthony Liguori
Avi Kivity wrote: > Anthony Liguori wrote: >> BTW, I don't think the target should be a config value. You don't >> gain anything from it being in the config space and it's somewhat >> unnatural for a virtio device. It makes more sense as a message to >> the guest. >> > > I disagree. The tar

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Avi Kivity
Anthony Liguori wrote: > BTW, I don't think the target should be a config value. You don't gain > anything from it being in the config space and it's somewhat unnatural > for a virtio device. It makes more sense as a message to the guest. > I disagree. The target is state, not an individual

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Avi Kivity
Marcelo Tosatti wrote: >> Why is it taking over the irq? This is very, very wrong. A virtio >> device cannot be dependent on being used on top of the virtio-pci backend. >> > > A notification is necessary whenever the host changes the target value > in the config space. So right now thi

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Anthony Liguori
Marcelo Tosatti wrote: > On Tue, Jan 08, 2008 at 09:42:13AM -0600, Anthony Liguori wrote: > >> Marcelo Tosatti wrote: >> >>> Following patch introduces a KVM guest balloon driver. Communication >>> to/from the host is performed via virtio. >>> >>> > > I'll address the other comments.

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Marcelo Tosatti
On Tue, Jan 08, 2008 at 09:42:13AM -0600, Anthony Liguori wrote: > Marcelo Tosatti wrote: > >Following patch introduces a KVM guest balloon driver. Communication > >to/from the host is performed via virtio. > > I'll address the other comments. > >+virtballoon.dev = vdev; > >+init_waitqueu

Re: [kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Anthony Liguori
Marcelo Tosatti wrote: > Following patch introduces a KVM guest balloon driver. Communication > to/from the host is performed via virtio. > > Next patch implements the QEMU driver and handling. > > Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> > > Index: linux-2.6-nv/drivers/virtio/Kconfig > =

[kvm-devel] [PATCH] kvm guest balloon driver

2008-01-08 Thread Marcelo Tosatti
Following patch introduces a KVM guest balloon driver. Communication to/from the host is performed via virtio. Next patch implements the QEMU driver and handling. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: linux-2.6-nv/drivers/virtio/Kconfig ==