Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-18 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: >> Avi Kivity wrote: >> >>> Laurent Vivier (Bull) wrote: >>> > Not being able to emulate is sometimes legitimate. In the case of > writing to a write-protected guest page table, we simply > un-write-protect it and go back to the guest (wh

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-17 Thread Avi Kivity
Laurent Vivier wrote: > Avi Kivity wrote: > >> Laurent Vivier (Bull) wrote: >> Not being able to emulate is sometimes legitimate. In the case of writing to a write-protected guest page table, we simply un-write-protect it and go back to the guest (which should now execute >>

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-17 Thread Laurent Vivier (Bull)
Avi Kivity wrote: > Laurent Vivier wrote: >> Avi Kivity wrote: ... >>> Interesting. I don't see how an instruction fetch can fail on >>> uniprocessor. Can you give details of the failure? >>> >>> Instruction fetches can fail on SMP so a fix is certainly needed. >>> >> OK, I spoke too fast

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-17 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier (Bull) wrote: >> > >> > Not being able to emulate is sometimes legitimate. In the case of >> > writing to a write-protected guest page table, we simply >> > un-write-protect it and go back to the guest (which should now execute >> > the instruction natively). >>

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-17 Thread Avi Kivity
Laurent Vivier (Bull) wrote: > > > > Not being able to emulate is sometimes legitimate. In the case of > > writing to a write-protected guest page table, we simply > > un-write-protect it and go back to the guest (which should now execute > > the instruction natively). > > > > Perhaps the logic th

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-17 Thread Avi Kivity
Laurent Vivier wrote: > Avi Kivity wrote: > >> Laurent Vivier wrote: >> >>> Avi Kivity wrote: >>> >>> Laurent Vivier wrote: > These patches split the emulator in two parts: one to decode the > instruction, > the other to execute it. The dec

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-17 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: >> Avi Kivity wrote: >> >>> Laurent Vivier wrote: >>> These patches split the emulator in two parts: one to decode the instruction, the other to execute it. The decode part is then called only when needed. >>>

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-14 Thread Avi Kivity
Laurent Vivier wrote: > Avi Kivity wrote: > >> Laurent Vivier wrote: >> >>> These patches split the emulator in two parts: one to decode the >>> instruction, >>> the other to execute it. The decode part is then called only when needed. >>> >>> >>> >> Patchset looks good, but fails

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-14 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: >> These patches split the emulator in two parts: one to decode the >> instruction, >> the other to execute it. The decode part is then called only when needed. >> >> > > Patchset looks good, but fails booting FC6 x86-64 on Intel. It may be a > merge e

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-12 Thread Avi Kivity
Laurent Vivier wrote: > Avi Kivity wrote: > >> Laurent Vivier wrote: >> >>> These patches split the emulator in two parts: one to decode the >>> instruction, >>> the other to execute it. The decode part is then called only when needed. >>> >>> >>> >> Patchset looks good, but fails

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-12 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: >> These patches split the emulator in two parts: one to decode the >> instruction, >> the other to execute it. The decode part is then called only when needed. >> >> > > Patchset looks good, but fails booting FC6 x86-64 on Intel. It may be a > merge e

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-09 Thread Avi Kivity
Laurent Vivier wrote: > These patches split the emulator in two parts: one to decode the instruction, > the other to execute it. The decode part is then called only when needed. > > Patchset looks good, but fails booting FC6 x86-64 on Intel. It may be a merge error (did not apply cleanly due

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-09-01 Thread Avi Kivity
Andi Kleen wrote: > On Wednesday 29 August 2007 18:39:45 Laurent Vivier wrote: > >> These patches split the emulator in two parts: one to decode the instruction, >> the other to execute it. The decode part is then called only when needed. >> > > Is the same change done to the Xen version? I

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-08-31 Thread Andi Kleen
On Wednesday 29 August 2007 18:39:45 Laurent Vivier wrote: > These patches split the emulator in two parts: one to decode the instruction, > the other to execute it. The decode part is then called only when needed. Is the same change done to the Xen version? It might be better to make it easier to

[kvm-devel] [PATCH 0/5] Split the emulator: decode & execute

2007-08-29 Thread Laurent Vivier
These patches split the emulator in two parts: one to decode the instruction, the other to execute it. The decode part is then called only when needed. [PATCH 1/5] x86_emulate-remove_unused, some cleanup: remove unused functions [PATCH 2/5] x86_emulate-context, move all x86_emulate_memop() common