Re: [kvm-devel] [PATCH 1/3] Refactor AIO interface to allow other AIO implementations

2008-04-17 Thread Anthony Liguori
Daniel P. Berrange wrote: > If QEMU can't discover cases where it won't work, what criteria should > the end user use to decide between the impls, or for that matter, what > criteria should a management api/app like libvirt use ? If the only decision > logic is 'try it & benchmark your VM' then it

Re: [kvm-devel] [PATCH 1/3] Refactor AIO interface to allow other AIO implementations

2008-04-17 Thread Daniel P. Berrange
On Thu, Apr 17, 2008 at 02:41:32PM -0500, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >On Thu, Apr 17, 2008 at 02:26:50PM -0500, Anthony Liguori wrote: > > > >>Posix AIO, especially as used by QEMU, is not very efficient for disk IO. > >>This patch introduces an AIO abstract to allow mul

Re: [kvm-devel] [PATCH 1/3] Refactor AIO interface to allow other AIO implementations

2008-04-17 Thread Anthony Liguori
Daniel P. Berrange wrote: > On Thu, Apr 17, 2008 at 02:26:50PM -0500, Anthony Liguori wrote: > >> Posix AIO, especially as used by QEMU, is not very efficient for disk IO. >> This patch introduces an AIO abstract to allow multiple AIO implements to be >> used. We can't simply replace posix-aio

Re: [kvm-devel] [PATCH 1/3] Refactor AIO interface to allow other AIO implementations

2008-04-17 Thread Daniel P. Berrange
On Thu, Apr 17, 2008 at 02:26:50PM -0500, Anthony Liguori wrote: > Posix AIO, especially as used by QEMU, is not very efficient for disk IO. > This patch introduces an AIO abstract to allow multiple AIO implements to be > used. We can't simply replace posix-aio by linux-aio because linux-aio only

[kvm-devel] [PATCH 1/3] Refactor AIO interface to allow other AIO implementations

2008-04-17 Thread Anthony Liguori
Posix AIO, especially as used by QEMU, is not very efficient for disk IO. This patch introduces an AIO abstract to allow multiple AIO implements to be used. We can't simply replace posix-aio by linux-aio because linux-aio only works on some filesystems and only with files opened with O_DIRECT. Th