Re: [kvm-devel] [PATCH 10/10] Use standard CR8 flags, and fix TPR definition

2007-07-18 Thread Avi Kivity
H. Peter Anvin wrote: > Rusty Russell wrote: > >> Intel manual (and KVM definition) say it's TPR is 4 bits wide. Also fix >> CR8_RESEVED_BITS typo. >> >> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> >> > > Indeed it is. > > Acked-by: H. Peter Anvin <[EMAIL PROTECTED]> > > Applied-b

Re: [kvm-devel] [PATCH 10/10] Use standard CR8 flags, and fix TPR definition

2007-07-17 Thread H. Peter Anvin
Avi Kivity wrote: > > X86_CR8_TPR is not used in the kernel. But is this meant to be a mask, > or something else? > Yes, a mask. And no, it's not used, except for KVM... -hpa - This SF.net email is sponsored by D

Re: [kvm-devel] [PATCH 10/10] Use standard CR8 flags, and fix TPR definition

2007-07-17 Thread H. Peter Anvin
Rusty Russell wrote: > Intel manual (and KVM definition) say it's TPR is 4 bits wide. Also fix > CR8_RESEVED_BITS typo. > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Indeed it is. Acked-by: H. Peter Anvin <[EMAIL PROTECTED]> -hpa

Re: [kvm-devel] [PATCH 10/10] Use standard CR8 flags, and fix TPR definition

2007-07-17 Thread Avi Kivity
Rusty Russell wrote: > Intel manual (and KVM definition) say it's TPR is 4 bits wide. Also fix > CR8_RESEVED_BITS typo. > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> > diff -r 6ef0b4c0d6f7 include/asm-i386/processor-flags.h > --- a/include/asm-i386/processor-flags.h Tue Jul 17 18:07:48

[kvm-devel] [PATCH 10/10] Use standard CR8 flags, and fix TPR definition

2007-07-17 Thread Rusty Russell
Intel manual (and KVM definition) say it's TPR is 4 bits wide. Also fix CR8_RESEVED_BITS typo. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 6ef0b4c0d6f7 drivers/kvm/kvm_main.c --- a/drivers/kvm/kvm_main.cTue Jul 17 18:07:48 2007 +1000 +++ b/drivers/kvm/kvm_main.cTue Jul 17 18