Re: [kvm-devel] [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Jeremy Fitzhardinge
Keir Fraser wrote: > volatile prevents the asm from being 'moved significantly', according to the > gcc manual. I take that to mean that reordering is not allowed. > That phrase doesn't appear in the gcc manual; in fact, it specifically says that reordering can happen: The `volatile' keywo

Re: [kvm-devel] [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Keir Fraser escreveu: > On 1/11/07 15:30, "Jeremy Fitzhardinge" <[EMAIL PROTECTED]> wrote: > >> Glauber de Oliveira Costa wrote: >>> I in fact have seen bugs with mixed reads and writes to the same cr, >>> (cr4), but adding the volatile >>> flag to th

Re: [kvm-devel] [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Keir Fraser
On 1/11/07 15:30, "Jeremy Fitzhardinge" <[EMAIL PROTECTED]> wrote: > Glauber de Oliveira Costa wrote: >> I in fact have seen bugs with mixed reads and writes to the same cr, >> (cr4), but adding the volatile >> flag to the read function seemed to fix it. > > Well, volatile will make a read be rep

Re: [kvm-devel] [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > I in fact have seen bugs with mixed reads and writes to the same cr, > (cr4), but adding the volatile > flag to the read function seemed to fix it. Well, volatile will make a read be repeated rather than caching the previous value, but it has no effect on orderin

Re: [kvm-devel] [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremy Fitzhardinge escreveu: > Glauber de Oliveira Costa wrote: >> This patch introduces, and patch callers when needed, native >> versions for read/write_crX functions, clts and wbinvd. >> >> Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED

Re: [kvm-devel] [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-10-31 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > This patch introduces, and patch callers when needed, native > versions for read/write_crX functions, clts and wbinvd. > > Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> > Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> > Acked-by: Jeremy Fitzhardi

[kvm-devel] [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-10-31 Thread Glauber de Oliveira Costa
This patch introduces, and patch callers when needed, native versions for read/write_crX functions, clts and wbinvd. Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> Acked-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> --- arch/x86/mm/pag