Re: [kvm-devel] [PATCH 3/3] Stop dropping so many RX packets in tap (v2)

2008-05-04 Thread Anthony Liguori
Dor Laor wrote: > On Sun, 2008-05-04 at 15:21 -0500, Anthony Liguori wrote: > > Patchset looks good and reduces some nasty hacks. It probably also > improves other devices like e1000 et al. > Yeah, we just need to make sure they have proper can_receive handlers. I took a quick look at the

Re: [kvm-devel] [PATCH 3/3] Stop dropping so many RX packets in tap (v2)

2008-05-04 Thread Dor Laor
On Sun, 2008-05-04 at 15:21 -0500, Anthony Liguori wrote: > Normally, tap always reads packets and simply lets the client drop them if it > cannot receive them. For virtio-net, this results in massive packet loss and > about an 80% performance loss in TCP throughput. > > This patch modifies qemu

[kvm-devel] [PATCH 3/3] Stop dropping so many RX packets in tap (v2)

2008-05-04 Thread Anthony Liguori
Normally, tap always reads packets and simply lets the client drop them if it cannot receive them. For virtio-net, this results in massive packet loss and about an 80% performance loss in TCP throughput. This patch modifies qemu_send_packet() to only deliver a packet to a VLAN client if it doesn'