Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Gregory Haskins
>>> On Tue, May 8, 2007 at 4:26 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: >> >>> Hopefully not by setting the >>> signal number, bit by making the vcpu fd writable (userspace can attach >>> a signal to the fd if it wishes). >>> >>

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Avi Kivity
Gregory Haskins wrote: On Tue, May 8, 2007 at 4:13 AM, in message <[EMAIL PROTECTED]>, > Avi Kivity <[EMAIL PROTECTED]> wrote: > >> Gregory Haskins wrote: >> >>> I am perhaps being a bit overzealous here. What I found in practice is >>> that >>> >> the LVTT ca

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Gregory Haskins
>>> On Tue, May 8, 2007 at 4:13 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: >> >> I am perhaps being a bit overzealous here. What I found in practice is that > the LVTT can screw things up on shutdown, so I was being pretty conservative >

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Avi Kivity
Gregory Haskins wrote: > >> Hopefully not by setting the >> signal number, bit by making the vcpu fd writable (userspace can attach >> a signal to the fd if it wishes). >> > > Can you provide an example of what you would like here? I am not quite sure > what you mean by making the fd wr

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Avi Kivity
Gregory Haskins wrote: >> >>> >>> vcpu- >cpu = - 1; >>> vcpu- >kvm = kvm; >>> @@ - 366,13 +370,20 @@ static void free_pio_guest_pages(struct kvm_vcpu >>> *vcpu) >>> >>> static void kvm_free_vcpu(struct kvm_vcpu *vcpu) >>> { >>> + unsigned long irqsave; >>> + >>

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-07 Thread Gregory Haskins
Oops... missed one: >>> On Mon, May 7, 2007 at 5:57 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > > > This needs to be fixed prior to merging. Agreed. > Hopefully not by setting the > signal number, bit by making the vcpu fd writable (userspace can attach > a

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-07 Thread Gregory Haskins
>>> On Mon, May 7, 2007 at 5:57 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: >> The VCPU executes synchronously w.r.t. userspace today, and therefore >> interrupt injection is pretty straight forward. However, we will soon need >> to be able

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-07 Thread Avi Kivity
Gregory Haskins wrote: > The VCPU executes synchronously w.r.t. userspace today, and therefore > interrupt injection is pretty straight forward. However, we will soon need > to be able to inject interrupts asynchronous to the execution of the VCPU > due to the introduction of SMP, paravirtualized

[kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-02 Thread Gregory Haskins
The VCPU executes synchronously w.r.t. userspace today, and therefore interrupt injection is pretty straight forward. However, we will soon need to be able to inject interrupts asynchronous to the execution of the VCPU due to the introduction of SMP, paravirtualized drivers, and asynchronous hyper