Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1 of 3] Move x86 kvmcallback structure to kvmctl-x86.h header

2007-10-29 Thread Anthony Liguori
Hollis Blanchard wrote: On Sun, 2007-10-28 at 22:50 -0500, Anthony Liguori wrote: You could certainly get even more clever and have the arch backend register the appropriate tables based on the as type but that's merely an implementation detail. The key observation, that I believe is

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1 of 3] Move x86 kvmcallback structure to kvmctl-x86.h header

2007-10-29 Thread Avi Kivity
Hollis Blanchard wrote: Also, can't x86 rep instructions go beyond 64 bits? I guess that must be handled in the arch-specific caller of io_write(), which would call it multiple times. 'rep' has special support in the ABI (it's N accesses of M bits, not an NxM bit access). -- Any

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1 of 3] Move x86 kvmcallback structure to kvmctl-x86.h header

2007-10-28 Thread Hollis Blanchard
On Sun, 2007-10-28 at 21:11 -0500, Anthony Liguori wrote: int (*io_write)(void *opaque, int as, uint64_t addr, uint64_t data, int size); Where as is a #define representing the address space (on x86, there is the PIO and MMIO address spaces, on PPC, there is just MMIO). So the

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1 of 3] Move x86 kvmcallback structure to kvmctl-x86.h header

2007-10-28 Thread Anthony Liguori
Hollis Blanchard wrote: On Sun, 2007-10-28 at 21:11 -0500, Anthony Liguori wrote: int (*io_write)(void *opaque, int as, uint64_t addr, uint64_t data, int size); Where as is a #define representing the address space (on x86, there is the PIO and MMIO address spaces, on PPC, there is just

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1 of 3] Move x86 kvmcallback structure to kvmctl-x86.h header

2007-10-28 Thread Hollis Blanchard
On Sun, 2007-10-28 at 22:50 -0500, Anthony Liguori wrote: You could certainly get even more clever and have the arch backend register the appropriate tables based on the as type but that's merely an implementation detail. The key observation, that I believe is correct, is that all