Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-11 Thread Marcelo Tosatti
On Wed, Mar 05, 2008 at 07:50:14AM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > >Add monitor command to hot-add PCI devices (nic and drive). > > > > > > A drive is not a pci device. One would hot-plug a scsi controller, and > then hot-plug a device to that controller. Changed the synta

Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-04 Thread Avi Kivity
Marcelo Tosatti wrote: > Add monitor command to hot-add PCI devices (nic and drive). > > A drive is not a pci device. One would hot-plug a scsi controller, and then hot-plug a device to that controller. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-04 Thread Itamar Heim
ge.net; Marcelo Tosatti; Avi Kivity; Glauber Costa Subject: Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add On Tue, Mar 04, 2008 at 01:30:42PM -0600, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >On Tue, Mar 04, 2008 at 03:34:33PM -0300, Marcelo Tosatti wrote: > >>A

Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-04 Thread Daniel P. Berrange
On Tue, Mar 04, 2008 at 01:30:42PM -0600, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >On Tue, Mar 04, 2008 at 03:34:33PM -0300, Marcelo Tosatti wrote: > >>Add monitor command to hot-add PCI devices (nic and drive). > >[snip] > > > > > >>Index: kvm-userspace.hotplug/qemu/monitor.c > >>==

Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-04 Thread Anthony Liguori
Daniel P. Berrange wrote: > On Tue, Mar 04, 2008 at 03:34:33PM -0300, Marcelo Tosatti wrote: > >> Add monitor command to hot-add PCI devices (nic and drive). >> > > [snip] > > >> Index: kvm-userspace.hotplug/qemu/monitor.c >> ==

Re: [kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-04 Thread Daniel P. Berrange
On Tue, Mar 04, 2008 at 03:34:33PM -0300, Marcelo Tosatti wrote: > Add monitor command to hot-add PCI devices (nic and drive). [snip] > Index: kvm-userspace.hotplug/qemu/monitor.c > === > --- kvm-userspace.hotplug.orig/qemu/monitor.c

[kvm-devel] [patch 14/23] QEMU/KVM: device hot-add

2008-03-04 Thread Marcelo Tosatti
Add monitor command to hot-add PCI devices (nic and drive). Save QEMUMachine necessary for drive_init. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace.hotplug/qemu/Makefile.target === --- kvm-userspace.hotplu