Re: [kvm-devel] [patch 2/2] [PATCH] virtio-blk: virtio_pci_init can fail

2008-04-21 Thread Chris Wright
* Marcelo Tosatti ([EMAIL PROTECTED]) wrote: > > Looks good. Does SCSI handle pci_register_device() failure too? Yeah, but it missed actually checking the return value from lsi_scsi_init. Patch to follow. thanks, -chris -

Re: [kvm-devel] [patch 2/2] [PATCH] virtio-blk: virtio_pci_init can fail

2008-04-21 Thread Marcelo Tosatti
Looks good. Does SCSI handle pci_register_device() failure too? Acked-by: Marcelo Tosatti <[EMAIL PROTECTED]> On Mon, Apr 21, 2008 at 04:02:49PM -0700, Chris Wright wrote: > The pci_device_register() call in virtio_pci_init() can fail. > Handle this error condition instead of generating a SEGV.

[kvm-devel] [patch 2/2] [PATCH] virtio-blk: virtio_pci_init can fail

2008-04-21 Thread Chris Wright
The pci_device_register() call in virtio_pci_init() can fail. Handle this error condition instead of generating a SEGV. Cc: Marcelo Tosatti <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> --- qemu/hw/virtio-blk.c |2 ++ 1 file changed, 2 insertions(+) --- a/qemu/hw/virtio