Re: [kvm-devel] APIC_TMCCT register read bug]

2007-10-20 Thread Avi Kivity
Kevin Pedretti wrote: > On Mon, 2007-10-15 at 11:29 +0200, Avi Kivity wrote: > >> Patch looks good, but I'm missing a signed-off-by: line. >> >> Eddie, can you also take a look? >> > > I split the patch in two. The first one fixes the host OS kernel > divide by zero problem. The second cl

Re: [kvm-devel] APIC_TMCCT register read bug]

2007-10-17 Thread Dong, Eddie
[EMAIL PROTECTED] wrote: > On Mon, 2007-10-15 at 11:29 +0200, Avi Kivity wrote: >> Patch looks good, but I'm missing a signed-off-by: line. >> >> Eddie, can you also take a look? > > I split the patch in two. The first one fixes the host OS kernel > divide by zero problem. The second cleans up

Re: [kvm-devel] APIC_TMCCT register read bug]

2007-10-17 Thread Kevin Pedretti
On Mon, 2007-10-15 at 11:29 +0200, Avi Kivity wrote: > Patch looks good, but I'm missing a signed-off-by: line. > > Eddie, can you also take a look? I split the patch in two. The first one fixes the host OS kernel divide by zero problem. The second cleans up apic_get_tmcct() a bit. Both now incl

Re: [kvm-devel] APIC_TMCCT register read bug

2007-10-15 Thread Avi Kivity
Kevin Pedretti wrote: > Hi, > > While booting a non-Linux OS under kvm-46, I noticed that reading > APIC_TMCCT before initializing APIC_TDCR to something other than its > boot time value would lead to a host kernel divide by zero exception. > It's due to apic->timer.divide_count being set to 0 at b

[kvm-devel] APIC_TMCCT register read bug

2007-10-12 Thread Kevin Pedretti
Hi, While booting a non-Linux OS under kvm-46, I noticed that reading APIC_TMCCT before initializing APIC_TDCR to something other than its boot time value would lead to a host kernel divide by zero exception. It's due to apic->timer.divide_count being set to 0 at boot... it should be set to 2 sinc