Re: [kvm-devel] PATCH: dont call exit() from pci_nic_init(), let caller handle

2008-03-20 Thread Marcelo Tosatti
On Wed, Mar 19, 2008 at 07:19:51PM -0500, Ryan Harper wrote: While exploring the PCI hotplug code recently posted, I encountered a situation where I don't believe the current behavior is ideal. With hotplug, we can add additional pci-based nic devices like e1000 and rtl8139 from the qemu

[kvm-devel] PATCH: dont call exit() from pci_nic_init(), let caller handle

2008-03-19 Thread Ryan Harper
While exploring the PCI hotplug code recently posted, I encountered a situation where I don't believe the current behavior is ideal. With hotplug, we can add additional pci-based nic devices like e1000 and rtl8139 from the qemu monitor. If one mistakenly specifies model=ne2000 (the ISA version),