Re: [kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-13 Thread Avi Kivity
Carsten Otte wrote: > Avi Kivity wrote: >> I agree 100%, I'm just using the "keep the patch dead simple" excuse to >> delay the change. We can have a 'add kvm_ prefix' patch round later. >> Let's complete the separation first. > Okay, fine with me. > >> There are some bigger offenders too, like se

Re: [kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-12 Thread Carsten Otte
Avi Kivity wrote: > I agree 100%, I'm just using the "keep the patch dead simple" excuse to > delay the change. We can have a 'add kvm_ prefix' patch round later. > Let's complete the separation first. Okay, fine with me. > There are some bigger offenders too, like set_crX(), which don't even >

Re: [kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-11 Thread Avi Kivity
Carsten Otte wrote: > Avi Kivity wrote: >> Applied, thanks. I renamed kvm_vcpu_load() and kvm_vcpu_put() back >> to vcpu_load() and vcpu_put() in order to keep the patch small and >> simple, and because I'm emotionally attached to the original names. > Oh, I think I had a very good reason for rena

Re: [kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-11 Thread Carsten Otte
Avi Kivity wrote: > This is wrong -- kvm_main.c calls vmalloc() so this is needed. The fact > that it is included by something else doesn't mean we can remove it; we > don't want to depend on random #includes within header files. > > Only remove a #include if nothing within the including file d

Re: [kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-11 Thread Carsten Otte
Avi Kivity wrote: > Applied, thanks. I renamed kvm_vcpu_load() and kvm_vcpu_put() back to > vcpu_load() and vcpu_put() in order to keep the patch small and simple, > and because I'm emotionally attached to the original names. Oh, I think I had a very good reason for renaming it: it's no longer

Re: [kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-11 Thread Avi Kivity
Carsten Otte wrote: > This patch splits kvm_vcpu_ioctl into archtecture independent parts, and > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > > static inline int kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gva_t gva, > Index: kvm/drivers/kvm/kvm_main.c >

Re: [kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-11 Thread Avi Kivity
Carsten Otte wrote: > This patch splits kvm_vcpu_ioctl into archtecture independent parts, and > x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. > > Common ioctls for all architectures are: > KVM_RUN, KVM_GET/SET_(S-)REGS, KVM_TRANSLATE, KVM_INTERRUPT, > KVM_DEBUG_GUEST, KVM_SET_SIGNA

[kvm-devel] RFC/patch portability: split kvm_vcpu_ioctl v1

2007-10-11 Thread Carsten Otte
This patch splits kvm_vcpu_ioctl into archtecture independent parts, and x86 specific parts which go to kvm_arch_vcpu_ioctl in x86.c. Common ioctls for all architectures are: KVM_RUN, KVM_GET/SET_(S-)REGS, KVM_TRANSLATE, KVM_INTERRUPT, KVM_DEBUG_GUEST, KVM_SET_SIGNAL_MASK, KVM_GET/SET_FPU Note th