Re: [kvm-devel] mmu notifier #v14

2008-04-28 Thread Marcelo Tosatti
Hi Andrea, Looks good. Acked-by: Marcelo Tosatti <[EMAIL PROTECTED]> - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority

Re: [kvm-devel] mmu notifier #v14

2008-04-26 Thread Andrea Arcangeli
On Sat, Apr 26, 2008 at 08:54:23PM -0500, Anthony Liguori wrote: > Avi can correct me if I'm wrong, but I don't think the consensus of that > discussion was that we're going to avoid putting mmio pages in the rmap. My first impression on that discussion was that pci-passthrough mmio can't be sw

Re: [kvm-devel] mmu notifier #v14

2008-04-26 Thread Anthony Liguori
Andrea Arcangeli wrote: > On Sat, Apr 26, 2008 at 01:59:23PM -0500, Anthony Liguori wrote: > >>> +static void kvm_unmap_spte(struct kvm *kvm, u64 *spte) >>> +{ >>> + struct page *page = pfn_to_page((*spte & PT64_BASE_ADDR_MASK) >> >>> PAGE_SHIFT); >>> + get_page(page); >>> >>> >>

Re: [kvm-devel] mmu notifier #v14

2008-04-26 Thread Andrea Arcangeli
On Sat, Apr 26, 2008 at 01:59:23PM -0500, Anthony Liguori wrote: >> +static void kvm_unmap_spte(struct kvm *kvm, u64 *spte) >> +{ >> +struct page *page = pfn_to_page((*spte & PT64_BASE_ADDR_MASK) >> >> PAGE_SHIFT); >> +get_page(page); >> > > You should not assume a struct page exists fo

Re: [kvm-devel] mmu notifier #v14

2008-04-26 Thread Anthony Liguori
Andrea Arcangeli wrote: > Hello everyone, > > here it is the mmu notifier #v14. > > > http://www.kernel.org/pub/linux/kernel/people/andrea/patches/v2.6/2.6.25/mmu-notifier-v14/ > > Please everyone involved review and (hopefully ;) ack that this is > safe to go in 2.6.26, the most important i

[kvm-devel] mmu notifier #v14

2008-04-26 Thread Andrea Arcangeli
Hello everyone, here it is the mmu notifier #v14. http://www.kernel.org/pub/linux/kernel/people/andrea/patches/v2.6/2.6.25/mmu-notifier-v14/ Please everyone involved review and (hopefully ;) ack that this is safe to go in 2.6.26, the most important is to verify that this is a noop when