Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-03 Thread Avi Kivity
Li, Xin B wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Ulrich Drepper Sent: Friday, August 03, 2007 2:24 AM To: Nakajima, Jun Cc: kvm-devel@lists.sourceforge.net Subject: Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX -BEGIN

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-03 Thread Avi Kivity
Rusty Russell wrote: >> Rusty, what say you to a 'struct page *module_to_page(void *kaddr)' >> which does the right thing? Attached an implementation. >> > > Hi Avi, > > Arch-specific, unfortunately: modules do not need to be allocated with > vmalloc (and for small modules probably shoul

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Li, Xin B
>-Original Message- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On Behalf Of >Ulrich Drepper >Sent: Friday, August 03, 2007 2:24 AM >To: Nakajima, Jun >Cc: kvm-devel@lists.sourceforge.net >Subject: Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Rusty Russell
On Thu, 2007-08-02 at 15:39 +0300, Avi Kivity wrote: > He, Qing wrote: > >> > >> hmm. While there's nothing wrong with the patch, there is a simpler way > >> to do this: > >> > >>static unsigned long vmx_msr_bitmap[PAGE_SIZE / sizeof(unsigned > >> long)] __aligned(PAGE_SIZE); > >> > >> now the

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nakajima, Jun wrote: >> Looking at the Linux context switch code, it can bang on MSR_FS_BASE > and >> MSR_KERNEL_GS_BASE. A high context switch rate between threads (which >> use %gs or %fs) can show an improvement with this. Things like kbuild >> pro

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Nakajima, Jun
Avi Kivity wrote: > ron minnich wrote: > > On 8/2/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > > > > > Li, Xin B wrote: > > > > > > > > Did you see any performance improvements out of this? > > > > > > > > > > > > > > Acturally we don't expect any obviously performance because MSR > > > > access

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Avi Kivity
ron minnich wrote: > On 8/2/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > >> Li, Xin B wrote: >> Did you see any performance improvements out of this? >>> Acturally we don't expect any obviously performance because MSR accesses >>> are not frequent. >>> >>> >> W

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread ron minnich
On 8/2/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > Li, Xin B wrote: > >> Did you see any performance improvements out of this? > >> > > > > Acturally we don't expect any obviously performance because MSR accesses > > are not frequent. > > > > Well, why do this then? ah, see, you asked the question

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Li, Xin B
>-Original Message- >From: Avi Kivity [mailto:[EMAIL PROTECTED] >Sent: Thursday, August 02, 2007 10:50 PM >To: Li, Xin B >Cc: He, Qing; Rusty Russell; kvm-devel@lists.sourceforge.net >Subject: Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX > >Li, Xin

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Avi Kivity
Li, Xin B wrote: >> Did you see any performance improvements out of this? >> > > Acturally we don't expect any obviously performance because MSR accesses > are not frequent. > Well, why do this then? -- error compiling committee.c: too many arguments to function ---

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Li, Xin B
>Did you see any performance improvements out of this? Acturally we don't expect any obviously performance because MSR accesses are not frequent. -Xin - This SF.net email is sponsored by: Splunk Inc. Still grepping through lo

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Avi Kivity
Avi Kivity wrote: > However, I do see an issue with my proposal. To get the physical address > of the page, we need to use vmalloc_to_page(). But that won't work if > kvm is built into the kernel (and thus uses large pages for data). > Because of this issue, I'd like to apply the patch now and

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Avi Kivity
He, Qing wrote: >> >> hmm. While there's nothing wrong with the patch, there is a simpler way >> to do this: >> >>static unsigned long vmx_msr_bitmap[PAGE_SIZE / sizeof(unsigned >> long)] __aligned(PAGE_SIZE); >> >> now there's no need to allocate, error-check, free, or kmap the memory. >> The

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread He, Qing
>-Original Message- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On Behalf Of Avi Kivity >Sent: 2007年8月2日 19:00 >To: Yang, Sheng >Cc: kvm-devel@lists.sourceforge.net >Subject: Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX > >Yang, Sheng wrote

Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX

2007-08-02 Thread Avi Kivity
Yang, Sheng wrote: > Add MSR Bitmap support in VMX so that some execution of RDMSR or WRMSR > won't cause a VM exit. > > Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> > Signed-off-by: Qing He <[EMAIL PROTECTED]> > --- > drivers/kvm/vmx.c | 44 +++- > drive