Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-27 Thread Avi Kivity
Rusty Russell wrote: On Tuesday 13 November 2007 10:25:54 Anthony Liguori wrote: Dor Laor wrote: Anthony Liguori wrote: Dor Laor wrote: In general I think we need to add another feature or even version number ( I know you guys hate it). The reason is - Let's say

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-12 Thread Dor Laor
Anthony Liguori wrote: Dor Laor wrote: In general I think we need to add another feature or even version number ( I know you guys hate it). The reason is - Let's say you dont change functionality but change the irq protocol (for example the isr won't be zeroed on read), then an old

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-12 Thread Daniel P. Berrange
On Sat, Nov 10, 2007 at 09:20:36PM -0600, Anthony Liguori wrote: This patch implements a very naive virtio block device backend in QEMU. There's a lot of room for future optimization. We need to merge a -disk patch before we can provide a mechanism to expose this to users. The latest

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-12 Thread Avi Kivity
Daniel P. Berrange wrote: On Sat, Nov 10, 2007 at 09:20:36PM -0600, Anthony Liguori wrote: This patch implements a very naive virtio block device backend in QEMU. There's a lot of room for future optimization. We need to merge a -disk patch before we can provide a mechanism to expose

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-12 Thread Anthony Liguori
Avi Kivity wrote: Daniel P. Berrange wrote: On Sat, Nov 10, 2007 at 09:20:36PM -0600, Anthony Liguori wrote: This patch implements a very naive virtio block device backend in QEMU. There's a lot of room for future optimization. We need to merge a -disk patch before we can provide a

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-12 Thread Anthony Liguori
Dor Laor wrote: Anthony Liguori wrote: Dor Laor wrote: In general I think we need to add another feature or even version number ( I know you guys hate it). The reason is - Let's say you dont change functionality but change the irq protocol (for example the isr won't be zeroed on read),

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-12 Thread Rusty Russell
On Tuesday 13 November 2007 10:25:54 Anthony Liguori wrote: Dor Laor wrote: Anthony Liguori wrote: Dor Laor wrote: In general I think we need to add another feature or even version number ( I know you guys hate it). The reason is - Let's say you dont change functionality but change

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-11 Thread Dor Laor
Anthony Liguori wrote: This patch implements a very naive virtio block device backend in QEMU. There's a lot of room for future optimization. We need to merge a -disk patch before we can provide a mechanism to expose this to users. Signed-off-by: Anthony Liguori [EMAIL PROTECTED] diff

Re: [kvm-devel] [PATCH 2/6] virtio block driver for QEMU (v2)

2007-11-11 Thread Anthony Liguori
Dor Laor wrote: + +if (1) { +BlockDriverState *bs = bdrv_new(vda); +if (bdrv_open(bs, /home/anthony/images/linux.img, BDRV_O_SNAPSHOT)) +exit(1); Can you add a printf to the exit(1). I had to gdb the code to find why my qemu is not running no more (in earlier