Re: [kvm-devel] [PATCH 4/5] KVM: Local-APIC interface cleanup

2007-04-26 Thread Gregory Haskins
>>> On Tue, Apr 24, 2007 at 5:26 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: > > #include "diatribes/complexity.h" Hehe...ok, point taken. I will make the changes you recommended here: 1) leave cr8 state in VCPU 2) convert LAPIC abstractio

Re: [kvm-devel] [PATCH 4/5] KVM: Local-APIC interface cleanup

2007-04-24 Thread Avi Kivity
Gregory Haskins wrote: On Sun, Apr 22, 2007 at 4:54 AM, in message <[EMAIL PROTECTED]>, > Avi Kivity <[EMAIL PROTECTED]> wrote: > >> Gregory Haskins wrote: >> >>> Adds an abstraction to the LAPIC logic so that we can later substitute it >>> for an in- kernel model. >>>

Re: [kvm-devel] [PATCH 4/5] KVM: Local-APIC interface cleanup

2007-04-23 Thread Gregory Haskins
>>> On Sun, Apr 22, 2007 at 4:54 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: >> Adds an abstraction to the LAPIC logic so that we can later substitute it >> for an in- kernel model. >> >> > > This is overly abstracted. It's not like you

Re: [kvm-devel] [PATCH 4/5] KVM: Local-APIC interface cleanup

2007-04-22 Thread Avi Kivity
Gregory Haskins wrote: > Adds an abstraction to the LAPIC logic so that we can later substitute it > for an in-kernel model. > > This is overly abstracted. It's not like you can (on real hardware) wire your own lapic and plug it into the processor. It's well defined, and there are just thre