Re: [kvm-devel] Best practices for tracking KVM development

2007-05-08 Thread Avi Kivity
Wink Saville wrote: > Hello, > > Based on the initial feed back I'm going to start trying to implement > a PV block device that will use kshmem/ACE. What is the best > way to track KVM development. > > See http://kvm.qumranet.com/kvmwiki/Code. -- error compiling committee.c: too many argumen

Re: [kvm-devel] kshmem & ACE

2007-05-08 Thread Avi Kivity
Wink Saville wrote: >> >> Most paravirtual devices use atomic operations (or even just raw memory >> accesses and memory barriers), which don't need any special >> infrastructure. This effectively makes them message-passing protocols >> rather than shared memory protocol. I can't see offhand why

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Avi Kivity
Gregory Haskins wrote: >> >>> >>> vcpu- >cpu = - 1; >>> vcpu- >kvm = kvm; >>> @@ - 366,13 +370,20 @@ static void free_pio_guest_pages(struct kvm_vcpu >>> *vcpu) >>> >>> static void kvm_free_vcpu(struct kvm_vcpu *vcpu) >>> { >>> + unsigned long irqsave; >>> + >>

Re: [kvm-devel] [PATCH 4/4] KVM: Add support for in-kernel LAPIC model

2007-05-08 Thread Avi Kivity
Gregory Haskins wrote: > >>> + >>> +static struct kvm_irqdevice *get_irq_dev(struct kvm_kernint *s) >>> +{ >>> + struct kvm_irqdevice *dev; >>> + >>> + if (kvm_lapic_enabled(s- >vcpu)) >>> + dev = &s- >apic_irq; >>> + else >>> + dev = s- >ext_irq; >>> + >>> + if (!dev

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Avi Kivity
Gregory Haskins wrote: > >> Hopefully not by setting the >> signal number, bit by making the vcpu fd writable (userspace can attach >> a signal to the fd if it wishes). >> > > Can you provide an example of what you would like here? I am not quite sure > what you mean by making the fd wr

Re: [kvm-devel] Clarify old version messages and clean-up

2007-05-08 Thread Avi Kivity
Nguyen Anh Quynh wrote: > This patch clarifies some "old version" error message, and deletes > some unused functions in userspace code. > > Signed-off-by: Nguyen Anh Quynh <[EMAIL PROTECTED]> > Applied. Please send unrelated changes in different patches in the future. -- error compiling committ

Re: [kvm-devel] [PATCH] install kvm modules into drivers/kvm

2007-05-08 Thread Avi Kivity
Nguyen Anh Quynh wrote: > This patch installs kvm modules into drivers/kvm directory rather than > in extra/ > > Without this patch, I got a problem: after installing kvm (got from > git repo), modprobe always found and picked kvm modules in drivers/kvm > (ie old modules) instead the new ones (in

Re: [kvm-devel] [PATCH] configure qemu

2007-05-08 Thread Avi Kivity
Jeff Chua wrote: > Avi, > > Here's a little patch to silent ... > - sdl-config when SDK is compiled without static library > - texi2html when not found > > As this is just a cleanup, and not strictly necessary, please post it to qemu-devel so that we diverge as little as possible f

Re: [kvm-devel] Cursor release failures

2007-05-08 Thread Avi Kivity
Michael Ivanov wrote: > Avi Kivity пишет: > > >> Well, it's supposed to be fixed in kvm-22. Are you 100% certain you >> don't have leftover modules somewhere? Please load them with insmod >> instead of modprobe. >> > I loaded modules using insmod directly from kvm-22/kernel and retested

[kvm-devel] [PATCH][UPDATE] Shortcut MSR save/restore for lightweight VM Exit (was: RE: shortcut for lightweight VM Exit)

2007-05-08 Thread Dong, Eddie
[EMAIL PROTECTED] wrote: > BTW, I have another patch in hand to further reduce MSR > save/restore and > thus > improve performance more for lightweight VM Exit. Base on my > observation for FC5 32 bits > guest, 93% VM Exit will fall into the lightweight path. > This patch reduce the VM Exit handli

Re: [kvm-devel] [PATCH][UPDATE] Shortcut MSR save/restore for lightweight VM Exit

2007-05-08 Thread Avi Kivity
Dong, Eddie wrote: > [EMAIL PROTECTED] wrote: > >> BTW, I have another patch in hand to further reduce MSR >> save/restore and >> thus >> improve performance more for lightweight VM Exit. Base on my >> observation for FC5 32 bits >> guest, 93% VM Exit will fall into the lightweight path. >> >>

[kvm-devel] [ANNOUNCE] kvm-24 release

2007-05-08 Thread Avi Kivity
The recent performance enhancements caused another serious regression, namely an oops while loading kvm-intel.ko on i386. Changes from kvm-23: - fix oops loading kvm-intel module on i386 with highmem I will be traveling for the rest of this week and unable to introduce new regressions, so kvm-2

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Gregory Haskins
>>> On Tue, May 8, 2007 at 4:13 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: >> >> I am perhaps being a bit overzealous here. What I found in practice is that > the LVTT can screw things up on shutdown, so I was being pretty conservative >

Re: [kvm-devel] [PATCH][UPDATE] Shortcut MSR save/restore for lightweight VM Exit

2007-05-08 Thread Dong, Eddie
Avi Kivity wrote: > Dong, Eddie wrote: >> This patch reduce the VM Exit handling cost continuously >> for those lightweight VM Exit which occupies 93% of VM Exit in >> KB case if 64 bits OS has similar situation with 32 bits. In my old >> machine, I saw 20% performance increasement of KB within 64

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Avi Kivity
Gregory Haskins wrote: On Tue, May 8, 2007 at 4:13 AM, in message <[EMAIL PROTECTED]>, > Avi Kivity <[EMAIL PROTECTED]> wrote: > >> Gregory Haskins wrote: >> >>> I am perhaps being a bit overzealous here. What I found in practice is >>> that >>> >> the LVTT ca

Re: [kvm-devel] [PATCH 4/4] KVM: Add support for in-kernel LAPIC model

2007-05-08 Thread Gregory Haskins
>>> On Tue, May 8, 2007 at 4:19 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: > >> By "drop it", I assume you mean drop the abstraction and just use native > HRTIMER directly for now? >> >> > > Yes, we can worry about compatibility when

Re: [kvm-devel] [PATCH 3/4] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Gregory Haskins
>>> On Tue, May 8, 2007 at 4:26 AM, in message <[EMAIL PROTECTED]>, Avi Kivity <[EMAIL PROTECTED]> wrote: > Gregory Haskins wrote: >> >>> Hopefully not by setting the >>> signal number, bit by making the vcpu fd writable (userspace can attach >>> a signal to the fd if it wishes). >>> >>

Re: [kvm-devel] Cursor release failures

2007-05-08 Thread Michael Ivanov
Avi Kivity пишет: >> * ctrl alt does NOT release the pointer > > This is strange. Just tested it again with kvm-24 The pointer is not released on ctrl del. When the guest system reboots the system does not hang anymore though. Is it possible to turn on some kind of trace/debug output to figure

[kvm-devel] paravirtualization status

2007-05-08 Thread Omar Khan
hi, What is the status of paravirtualization? Also when Ingo released his paravirtualization patch and some results Avi noted that : "Very impressive! The gain probably comes not only from avoiding the vmentry/vmexit, but also from avoiding the flushing of the global page tlb entries." [htt

[kvm-devel] [PATCH 0/8] in-kernel APIC support "v1"

2007-05-08 Thread Gregory Haskins
Here is my latest series incorporating the feedback and numerous bugfixes. I did not keep an official change-log, so its difficult to say what changed off the top of my head without an interdiff. I will keep a changelog from here on out. Lets call this drop officially "v1". I will start trackin

[kvm-devel] [PATCH 1/8] KVM: Adds support for in-kernel mmio handlers

2007-05-08 Thread Gregory Haskins
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 60 +++ drivers/kvm/kvm_main.c | 94 ++-- 2 files changed, 142 insertions(+), 12 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/k

[kvm-devel] [PATCH 2/8] KVM: Add irqdevice object

2007-05-08 Thread Gregory Haskins
The current code is geared towards using a user-mode (A)PIC. This patch adds an "irqdevice" abstraction, and implements a "userint" model to handle the duties of the original code. Later, we can develop other irqdevice models to handle objects like LAPIC, IOAPIC, i8259, etc, as appropriate Signe

[kvm-devel] [PATCH 3/8] KVM: Adds ability to preempt an executing VCPU

2007-05-08 Thread Gregory Haskins
The VCPU executes synchronously w.r.t. userspace today, and therefore interrupt injection is pretty straight forward. However, we will soon need to be able to inject interrupts asynchronous to the execution of the VCPU due to the introduction of SMP, paravirtualized drivers, and asynchronous hyper

[kvm-devel] [PATCH 4/8] KVM: Adds ability to signal userspace using a file-descriptor

2007-05-08 Thread Gregory Haskins
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 + drivers/kvm/kvm_main.c | 82 2 files changed, 84 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h index 0f6cc32..b5bfc91 1006

[kvm-devel] [PATCH 5/8] KVM: Add support for in-kernel LAPIC model

2007-05-08 Thread Gregory Haskins
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> --- drivers/kvm/Makefile |2 drivers/kvm/kernint.c | 149 + drivers/kvm/kvm.h | 35 + drivers/kvm/kvm_main.c | 179 +- drivers/kvm/lapic.c| 1412 drivers/kvm/svm.c

[kvm-devel] [PATCH 7/8] KVM: Adds basic plumbing to support TPR shadow features

2007-05-08 Thread Gregory Haskins
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> --- drivers/kvm/irqdevice.h |3 +++ drivers/kvm/kvm.h |1 + drivers/kvm/lapic.c | 15 +++ 3 files changed, 19 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/irqdevice.h b/drivers/kvm/irqdevice.h index 097d

[kvm-devel] [PATCH 6/8] KVM: Adds support for real NMI injection on VMX processors

2007-05-08 Thread Gregory Haskins
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c | 63 + drivers/kvm/vmx.h |3 +++ 2 files changed, 61 insertions(+), 5 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index bee4831..1c99bc9 100644

[kvm-devel] [PATCH 8/8] KVM: Adds support for TPR shadowing under VMX processors

2007-05-08 Thread Gregory Haskins
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c | 32 ++-- 1 files changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index 1c99bc9..7745bb9 100644 --- a/drivers/kvm/vmx.c +++ b/drivers/kvm/vmx.c @@