Re: [kvm-devel] [PATCH 3/9] KVM: Add irqdevice object

2007-06-04 Thread Dong, Eddie
Greg: Can you explain a bit why we need to distinguish kvm_irqpin_extint from kvm_irqpin_localint? I am not in previous thread for this. I saw latest V09 has hole here such as handle_exception due to IRQ inject fail. I.e. IDT_VECTORING_INFO_FIELD only push localint back, but no extint.

Re: [kvm-devel] [PATCH 6/9] KVM: Adds support for real NMIinjectiononVMX processors

2007-06-04 Thread Dong, Eddie
[EMAIL PROTECTED] wrote: >>> Could you be more specific on whats left to be done? From >>> what I could read in the doc, this seemed complete. >>> >> >> This is a good start, and we also need to add a vmexit handler to >> handle exit reason 8, NMI pending. > > Ah, yes. Thank you for finding th

[kvm-devel] Online Banking Urgent Security Notice

2007-06-04 Thread Halifax Bank Plc
Dear Customer, Halifax Online Banking Security Department has been receiving complaints from our customers for unauthorised uses of the Halifax Online Banking accounts. As a result we are temporarily shutting down some selected Halifax Online Banking Accounts perceived vulnerable

Re: [kvm-devel] kvm-26 and Vista

2007-06-04 Thread Avi Kivity
Jorge Lucángeli Obes wrote: > On 6/3/07, Avi Kivity <[EMAIL PROTECTED]> wrote: >> Jorge Lucángeli Obes wrote: >> > Hi everyone. I'm again trying to get 32-bit Vista Ultimate to run as a >> > guest on my 64-bit Core 2 Duo T5600. I'm using Xubuntu Feisty with a >> > custom 2.6.20.3 kernel and kvm-26.

Re: [kvm-devel] [PATCH] memslot check before deferencing

2007-06-04 Thread Avi Kivity
Nguyen Anh Quynh wrote: > "memslot" in makr_page_dirty() should be verified before dereferencing > it (kvm_main.c) The patches still don't show up inlined. This makes them hard to review. Please fix this. > diff --git a/kernel/kvm_main.c b/kernel/kvm_main.c > index 84f95e4..da596fb 100644 > --

Re: [kvm-devel] [Xen-devel] Re: [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Avi Kivity
Rusty Russell wrote: > On Sun, 2007-06-03 at 14:39 +0300, Avi Kivity wrote: > >> Rusty Russell wrote: >> >>> Hmm... Perhaps I should move the used arrays into the "struct >>> virtio_device" and guarantee that the id (returned by add_*buf) is an >>> index into that. Then we can trivially ad

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Avi Kivity
Luca Tettamanti wrote: Hello, my kernel just exploded :) The host is running 2.6-git-current, with KVM modules from KVM-27 package. kernel is 32bit, SMP, with PREEMPT enabled, no HIGHMEM (but I'm using CONFIG_VMSPLIT_3G_OPT=y). The CPU is a Core2 (hence I'm using kvm-intel). Guest was a Fedora7

Re: [kvm-devel] [RFC] KVM guest page swap out support - take2

2007-06-04 Thread Avi Kivity
Shaohua Li wrote: > Hi, > This is a updated patch set of swap out kvm guest pages.Changes are: > 1. refresh against to kvm-26 > 2. clean up shadow page handling to make gfn_to_page not be called > within kmap_atomic/kunamp_atomic. > 3. variant bug fixing. Now the patch is quite stable in my test. >

Re: [kvm-devel] [Xen-devel] Re: [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Herbert Xu
On Mon, Jun 04, 2007 at 12:55:25PM +0300, Avi Kivity wrote: > > Networking hardware generally services descriptors in a FIFO manner. > virtio may not (for example, it may offload copies of larger packets to > a dma engine such as I/OAT, resulting in a delay, but copy smaller > packets immediat

Re: [kvm-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 12:55 +0300, Avi Kivity wrote: > Rusty Russell wrote: > > On Sun, 2007-06-03 at 14:39 +0300, Avi Kivity wrote: > > > >> Rusty Russell wrote: > >> > >>> Hmm... Perhaps I should move the used arrays into the "struct > >>> virtio_device" and guarantee that the id (returne

Re: [kvm-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Avi Kivity
Rusty Russell wrote: > >> Networking hardware generally services descriptors in a FIFO manner. >> > > Well, ethernet guarantees order. Not sure about others tho... > > OT: Does that hold for bonded interfaces too? >> virtio may not (for example, it may offload copies of larger packets

Re: [kvm-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 14:25 +0300, Avi Kivity wrote: > Rusty Russell wrote: > > > >> Networking hardware generally services descriptors in a FIFO manner. > >> > > > > Well, ethernet guarantees order. Not sure about others tho... > > OT: Does that hold for bonded interfaces too? Sorry, I

Re: [kvm-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Herbert Xu
On Mon, Jun 04, 2007 at 02:25:32PM +0300, Avi Kivity wrote: > > OT: Does that hold for bonded interfaces too? Yes. By default traffic to the same destination MAC always stick to one interface. You could select a layer3+4 hashing policy but even that guarantees a single flow will stick to one ph

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Carsten Otte
Rusty Russell wrote: > Is the noop scheduler significantly worse than hooking directly into > q->make_request_fn? The noop scheduler does do request merging, and has the same device plug latency as other schedulers. so long, Carsten ---

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Carsten Otte
Jens Axboe wrote: > On Fri, Jun 01 2007, Carsten Otte wrote: >> With regard to compute power needed, almost none. The penalty is >> latency, not overhead: A small request may sit on the request queue to >> wait for other work to arrive until the queue gets unplugged. This >> penality is compensa

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Jens Axboe
On Mon, Jun 04 2007, Carsten Otte wrote: > Jens Axboe wrote: > >On Fri, Jun 01 2007, Carsten Otte wrote: > >>With regard to compute power needed, almost none. The penalty is > >>latency, not overhead: A small request may sit on the request queue to > >>wait for other work to arrive until the queu

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 15:43 +0200, Jens Axboe wrote: > On Mon, Jun 04 2007, Carsten Otte wrote: > > Jens Axboe wrote: > > >On Fri, Jun 01 2007, Carsten Otte wrote: > > >>With regard to compute power needed, almost none. The penalty is > > >>latency, not overhead: A small request may sit on the req

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Jens Axboe
On Mon, Jun 04 2007, Rusty Russell wrote: > On Mon, 2007-06-04 at 15:43 +0200, Jens Axboe wrote: > > On Mon, Jun 04 2007, Carsten Otte wrote: > > > Jens Axboe wrote: > > > >On Fri, Jun 01 2007, Carsten Otte wrote: > > > >>With regard to compute power needed, almost none. The penalty is > > > >>lat

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Carsten Otte
Jens Axboe wrote: > Most people should not fiddle with it, the defaults are there for good > reason. I can provide a blk_queue_unplug_thresholds(q, depth, delay) > helper that you could use for the virtualized drivers, perhaps that > would be better for that use? Yea, we should'nt change the defaul

Re: [kvm-devel] [PATCH RFC 3/3] virtio infrastructure: example block driver

2007-06-04 Thread Jens Axboe
On Mon, Jun 04 2007, Carsten Otte wrote: > Jens Axboe wrote: > >Most people should not fiddle with it, the defaults are there for good > >reason. I can provide a blk_queue_unplug_thresholds(q, depth, delay) > >helper that you could use for the virtualized drivers, perhaps that > >would be better fo

Re: [kvm-devel] kvm-26 and Vista

2007-06-04 Thread Jorge Lucángeli Obes
> >> I'm at a loss to explain why this doesn't happen here. > > > > I'm now using kvm-27. This is the new 'kvm_readl': > > > > static int kvm_readl(void *opaque, uint64_t addr, uint32_t *data) > > { > >if (addr > 0x9fffc && addr < 0xa) return 0; > > > >*data = ldl_phys(addr); > >ret

Re: [kvm-devel] [PATCH 3/9] KVM: Add irqdevice object

2007-06-04 Thread Gregory Haskins
>>> "Dong, Eddie" <[EMAIL PROTECTED]> 06/04/07 3:13 AM >>> >Greg: > Can you explain a bit why we need to distinguish > kvm_irqpin_extint from kvm_irqpin_localint? They are both "vectored interrupts", but localint means "I have the vector" and extint means "someone else has the vector". The

Re: [kvm-devel] [PATCH 6/9] KVM: Adds support for real NMIinjectiononVMX processors

2007-06-04 Thread Gregory Haskins
>>> "Dong, Eddie" <[EMAIL PROTECTED]> 06/04/07 3:28 AM >>> [EMAIL PROTECTED] wrote: > >NMI can be injected even RFLAGS.IF=0, but it can be blocked by >previous NMI. If we want to handle NMI in this patch, we need to >add the logic of NMI block and unblock. With the exception of the missing exit-r

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Luca Tettamanti
Hi, Il Mon, Jun 04, 2007 at 12:35:37PM +0300, Avi Kivity ha scritto: > Luca Tettamanti wrote: > >Hello, > >my kernel just exploded :) > > > >The host is running 2.6-git-current, with KVM modules from KVM-27 > >package. kernel is 32bit, SMP, with PREEMPT enabled, no HIGHMEM (but I'm > >using CONFI

[kvm-devel] PIIX/IDE: ports disabled in PCI config space?

2007-06-04 Thread Luca Tettamanti
Hello, I'm testing the new Fedora7 under KVM. As you may know Fedora has migrated to the new libata drivers. ata_piix is unhappy with the PIIX IDE controller provided by QEmu/KVM: libata version 2.20 loaded. ata_piix :00:01.1: version 2.10ac1 PCI: Setting latency timer of device :00:01.1

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Avi Kivity
Luca Tettamanti wrote: > It turned out that it was somewhat reproducible with fedora installer. > With your patch it doesn't oops anymore. > > Ok, good. > While doing repeated tests with the installer I ran into another > (unrelated) problem. Sometimes the guest kernel hangs at boot at: > > NE

Re: [kvm-devel] [Xen-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Santos, Jose Renato G
> -Original Message- > From: Rusty Russell [mailto:[EMAIL PROTECTED] > Sent: Saturday, June 02, 2007 3:13 AM > To: Santos, Jose Renato G > Cc: kvm-devel; Xen Mailing List; virtualization; Jimi > Xenidis; Stephen Rothwell; [EMAIL PROTECTED]; Herbert > Xu; Christian Borntraeger; Suzanne

Re: [kvm-devel] [Xen-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Jeremy Fitzhardinge
Santos, Jose Renato G wrote: > It seems that we will still need specific devices drivers > for each different virtualization flavor. For example, > we will still need to have a specific Xen netfront > device that talks to a backend device in dom0, using > page grants, and other Xen speci

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Luca Tettamanti
Il Mon, Jun 04, 2007 at 11:51:10PM +0300, Avi Kivity ha scritto: > > While doing repeated tests with the installer I ran into another > > (unrelated) problem. Sometimes the guest kernel hangs at boot at: > > > > NET: Registered protocol family 2 > > > > with any kind of networking options (except

Re: [kvm-devel] [PATCH 3/9] KVM: Add irqdevice object

2007-06-04 Thread Dong, Eddie
>-Original Message- >From: Gregory Haskins [mailto:[EMAIL PROTECTED] >Sent: 2007年6月5日 1:23 >To: Dong, Eddie; kvm-devel@lists.sourceforge.net >Subject: RE: [kvm-devel] [PATCH 3/9] KVM: Add irqdevice object > "Dong, Eddie" <[EMAIL PROTECTED]> 06/04/07 3:13 AM >>> >>Greg: >> Can

Re: [kvm-devel] [PATCH 3/9] KVM: Add irqdevice object

2007-06-04 Thread Dong, Eddie
Correct a typo, ISR & PPR are all updated, not TPR. >-Original Message- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On Behalf Of >Dong, Eddie >Sent: 2007年6月5日 8:21 >To: Gregory Haskins; kvm-devel@lists.sourceforge.net >Subject: Re: [kvm-devel] [PATCH 3/9] KVM: Add irqdevice obje

Re: [kvm-devel] [Xen-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 21:14 +, Santos, Jose Renato G wrote: > Thanks for clarifying your thinking. This helped me understand > your goals better. > I agree it would be nice to reduce the number of drivers as it > improves mantainability. However I am not convinced that > adding an IO

Re: [kvm-devel] kvm-26 and Vista

2007-06-04 Thread Jorge Lucángeli Obes
On 6/4/07, Jorge Lucángeli Obes <[EMAIL PROTECTED]> wrote: > > >> I'm at a loss to explain why this doesn't happen here. > > > > > > I'm now using kvm-27. This is the new 'kvm_readl': > > > > > > static int kvm_readl(void *opaque, uint64_t addr, uint32_t *data) > > > { > > >if (addr > 0x9fffc &

Re: [kvm-devel] [Xen-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Santos, Jose Renato G
> -Original Message- > From: Jeremy Fitzhardinge [mailto:[EMAIL PROTECTED] > Sent: Monday, June 04, 2007 2:20 PM > To: Santos, Jose Renato G > Cc: Rusty Russell; Jimi Xenidis; Stephen Rothwell; Xen > Mailing List; [EMAIL PROTECTED]; Herbert Xu; kvm-devel; > virtualization; Christian B

Re: [kvm-devel] [Xen-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Rusty Russell
On Tue, 2007-06-05 at 02:05 +, Santos, Jose Renato G wrote: > > From: Jeremy Fitzhardinge [mailto:[EMAIL PROTECTED] > > The hope is that the Xen-specific elements of the driver will > > be restricted to Xen-specific things like grant tables, and > > the bulk of the driver and its logic can

Re: [kvm-devel] [Xen-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Santos, Jose Renato G
> -Original Message- > From: Rusty Russell [mailto:[EMAIL PROTECTED] > Sent: Monday, June 04, 2007 6:45 PM > To: Santos, Jose Renato G > Cc: kvm-devel; Xen Mailing List; virtualization; Jimi > Xenidis; Stephen Rothwell; [EMAIL PROTECTED]; Herbert > Xu; Christian Borntraeger; Suzanne M

Re: [kvm-devel] [Xen-devel] [PATCH RFC 1/3] virtio infrastructure

2007-06-04 Thread Santos, Jose Renato G
> -Original Message- > From: Rusty Russell [mailto:[EMAIL PROTECTED] > Sent: Monday, June 04, 2007 7:27 PM > To: Santos, Jose Renato G > Cc: Jeremy Fitzhardinge; Jimi Xenidis; Stephen Rothwell; Xen > Mailing List; [EMAIL PROTECTED]; Herbert Xu; kvm-devel; > virtualization; Christian B

Re: [kvm-devel] [PATCH] memslot check before deferencing

2007-06-04 Thread Nguyen Anh Quynh
So take this patch instead. It remove the verification for NULL value of memslot in mark_page_dirty(). I am trying to send patch in 2 format: .txt and .patch. If your mailer cannot see them as inline text, I guess that is my gmail problem , and there is nothing I can do. So tell me if .txt patch

Re: [kvm-devel] [kvm-commits] kvm: kvmctl: create secondary vcpus

2007-06-04 Thread Nguyen Anh Quynh
Hi Avi, Perhaps I miss something, but I dont see you initialize ncpus anywhere in the patch? Cheers, Quynh On 6/5/07, Avi Kivity <[EMAIL PROTECTED]> wrote: > repository: /home/avi/kvm > branch: master > commit 9d02d1c4345c77ffbc95136c12011a112a8d1c7e > Author: Avi Kivity <[EMAIL PROTECTED]> > Da