Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Thu, Mar 06, 2008 at 10:23:18PM +0530, Balaji Rao wrote: > Hi greg, > > When I remove only the kvm-intel module without removing the kvm > module itself, I get an error saying that a kobject is trying to be > reinitialized. Its because of the fact that kvm reuses a kobject in > kvm_init when ca

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: > On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: > > > Where exactly in the code does that happen? kobjects should not be > > "reused" as that implies that they are static, and not dynamically > &g

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Sun, Mar 09, 2008 at 03:37:16AM +0530, Balaji Rao wrote: > On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: > > On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: > > > On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: > > > > > > > Whe

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Sat, Mar 08, 2008 at 09:06:49PM -0800, Greg KH wrote: > On Sun, Mar 09, 2008 at 03:37:16AM +0530, Balaji Rao wrote: > > On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: > > > On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: > > > > On Thursday 06

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Sun, Mar 09, 2008 at 03:37:16AM +0530, Balaji Rao wrote: > On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: > > On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: > > > On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: > > > > > > > Whe

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Sun, Mar 09, 2008 at 12:06:02PM +0530, Balaji Rao wrote: > On Sunday 09 March 2008 12:03:08 pm Greg KH wrote: > > On Sun, Mar 09, 2008 at 03:37:16AM +0530, Balaji Rao wrote: > > > On Thursday 06 March 2008 11:35:59 pm Greg KH wrote: > > > > On Thu, Mar 06, 2008 a

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Sun, Mar 09, 2008 at 12:51:15PM +0530, Balaji Rao wrote: > On Sunday 09 March 2008 12:33:07 pm Greg KH wrote: > > > > > > Hi, > > > > > > > > > > This patch does not fix it all! The problem is in fact more involved. > > > >

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Sun, Mar 09, 2008 at 11:49:26AM +0100, Mikael Pettersson wrote: > Balaji Rao writes: > > Yes the idea works. One more memset is needed in sysdev_register. Here's > the final patch. > > > > diff --git a/drivers/base/sys.c b/drivers/base/sys.c > > index 2f79c55..7c839d9 100644 > > --- a/dri

Re: [kvm-devel] [PATCH] Mark kobjects as unitialized

On Mon, Mar 10, 2008 at 09:35:56PM +0530, Balaji Rao wrote: > On Monday 10 March 2008 09:22:00 pm Greg KH wrote: > > On Sun, Mar 09, 2008 at 12:51:15PM +0530, Balaji Rao wrote: > > > On Sunday 09 March 2008 12:33:07 pm Greg KH wrote: > > > > > > > > >

Re: [kvm-devel] [stable] [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable)

On Sun, Dec 02, 2007 at 01:18:37PM +0200, Avi Kivity wrote: > The following patchset fixes some bugs in KVM for the next 2.6.23.y stable > release. Please apply. I'm guessing that all of these are already upstream in Linus's tree? If so, can you give me the git commit ids for them all if you hap

Re: [kvm-devel] [stable] [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable)

On Mon, Dec 03, 2007 at 11:23:19AM +0200, Avi Kivity wrote: > Greg KH wrote: > > On Sun, Dec 02, 2007 at 01:18:37PM +0200, Avi Kivity wrote: > > > >> The following patchset fixes some bugs in KVM for the next 2.6.23.y stable > >> release. Please apply. > &

Re: [kvm-devel] [stable] [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable)

On Mon, Dec 03, 2007 at 03:11:03PM +0200, Avi Kivity wrote: > Greg KH wrote: > > > > >> 1 a012e65aee48379a7a87eadafa74f878b61522b9 > >> 2 4e62417bf317504c0b85e0d7abd236f334f54eaf > >> 3 651a3e29b3d19418d7a8a9787906061f9be7cc5f > >> 4

[kvm-devel] [patch 17/60] KVM: x86 emulator: implement movnti mem, reg

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Sheng Yang <[EMAIL PROTECTED]> patch a012e65aee48379a7a87eadafa74f878b61522b9 in mainline. Implement emulation of instruction: movnti m32/m64, r32/r64 opcode: 0x0f 0xc3 Needed to sup

[kvm-devel] [patch 18/60] KVM: x86 emulator: fix access registers for instructions with ModR/M byte and Mod = 3

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Aurelien Jarno <[EMAIL PROTECTED]> patch 4e62417bf317504c0b85e0d7abd236f334f54eaf in mainline. The patch belows changes the access type to register from memory for instructions that are decla

[kvm-devel] [patch 19/60] KVM: x86 emulator: invd instruction

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Avi Kivity <[EMAIL PROTECTED]> patch 651a3e29b3d19418d7a8a9787906061f9be7cc5f in mainline. Emulate the 'invd' instruction (opcode 0f 08). Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> Signed-

[kvm-devel] [patch 20/60] KVM: SVM: Intercept the invd and wbinvd instructions

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Avi Kivity <[EMAIL PROTECTED]> patch cf5a94d1331b411b84414c13e43f578260942d6b in mainline. 'invd' can destroy host data, and 'wbinvd' allows the guest to induce long (milliseconds) latencies.

[kvm-devel] [patch 24/60] KVM: Skip pio instruction when it is emulated, not executed

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Avi Kivity <[EMAIL PROTECTED]> patch 0967b7bf1c22b55777aba46ff616547feed0b141 in mainline. If we defer updating rip until pio instructions are executed, we have a problem with reset: a pio re

[kvm-devel] [patch 26/60] KVM: VMX: Reset mmu context when entering real mode

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Eddie Dong <[EMAIL PROTECTED]> patch 8668a3c468ed55d19514117a5a959d91d3d03823 in mainline. Resetting an SMP guest will force AP enter real mode (RESET) with paging enabled in protected mode.

[kvm-devel] [patch 22/60] KVM: Fix hang on uniprocessor

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Marko Kohtala <[EMAIL PROTECTED]> This is not in mainline, as it was fixed differently in that tree. first_cpu(cpus) returns the only CPU when NR_CPUS is 1 regardless of the cpus mask. Theref

[kvm-devel] [patch 21/60] KVM: x86 emulator: Use emulator_write_emulated and not emulator_write_std

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Amit Shah <[EMAIL PROTECTED]> patch 00b2ef475d4728ca53a2bc788c7978042907e354 in mainline. emulator_write_std() is not implemented, and calling write_emulated should work just as well in place

[kvm-devel] [patch 23/60] KVM: SVM: Fix FPU leak while emulating clts

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Amit Shah <[EMAIL PROTECTED]> patch 404fb881b82cf0cf6981832f8d31a7484e4dee81 in mainline. The clts code didn't use set_cr0 properly, so our lazy FPU processing wasn't being done by the clts in

[kvm-devel] [patch 25/60] KVM: VMX: Force vm86 mode if setting flags during real mode

2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Avi Kivity <[EMAIL PROTECTED]> patch 78f7826868da8e27d097802139a3fec39f47f3b8 in mainline. When resetting from userspace, we need to handle the flags being cleared even after we are in real mo

Re: [kvm-devel] [PATCH 3/3] virtio module alias support

On Mon, Sep 24, 2007 at 07:16:34PM +1000, Rusty Russell wrote: > This adds the logic to convert the virtio ids into module aliases, and > includes a modalias entry in sysfs. > > Unfortunately this does not seem sufficient to have the module > autoprobed at startup on my Ubuntu system. Greg? Am I

Re: [kvm-devel] [PATCH 3/3] virtio module alias support

On Tue, Sep 25, 2007 at 10:50:04AM +1000, Rusty Russell wrote: > On Mon, 2007-09-24 at 09:02 -0700, Greg KH wrote: > > On Mon, Sep 24, 2007 at 07:16:34PM +1000, Rusty Russell wrote: > > > This adds the logic to convert the virtio ids into module aliases, and > > > i

Re: [kvm-devel] [PATCH 3/3] virtio module alias support

On Tue, Sep 25, 2007 at 12:11:15PM +1000, Rusty Russell wrote: > On Mon, 2007-09-24 at 18:57 -0700, Greg KH wrote: > > On Tue, Sep 25, 2007 at 10:50:04AM +1000, Rusty Russell wrote: > > > Not sure why I need the modalias here when it's in sysfs. But, it > > > wo

[kvm-devel] [patch 05/33] KVM: MMU: Fix host memory corruption on i386 with >= 4GB ram

-stable review patch. If anyone has any objections, please let us know. -- From: Avi Kivity <[EMAIL PROTECTED]> PAGE_MASK is an unsigned long, so using it to mask physical addresses on i386 (which are 64-bit wide) leads to truncation. This can result in page->private of unrelate

[kvm-devel] [patch 04/33] KVM: MMU: Fix guest writes to nonpae pde

-stable review patch. If anyone has any objections, please let us know. -- From: Avi Kivity <[EMAIL PROTECTED]> KVM shadow page tables are always in pae mode, regardless of the guest setting. This means that a guest pde (mapping 4MB of memory) is mapped to two shadow pdes (mappi