The long return value of rmode_tss_base is truncated by its declared
return type of int.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
drivers/kvm/vmx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: kvm/drivers/kvm
On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote:
> >-static int rmode_tss_base(struct kvm* kvm)
> >+static unsigned long rmode_tss_base(struct kvm* kvm)
>
> Should use gpa_t instead.
Right you are, I didn't notice that type.
Will fix.
Jeff
--
Work ema
On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote:
> Some extra logic is needed on i386 with >= 4GB. Current code will
> wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not
> the answer since the processor will truncate it back to 32 bits (the
> return value is eventu
Add the hypercall number to kvm_run and initialize it. This might be
considered API-changing, so I kept it separate.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
drivers/kvm/kvm_main.c |1 +
include/linux/kvm.h|1 +
2 files changed, 2 insertions(+)
Index: kvm/drive
were some missing initializations of hardware_exit_reason with
KVM_EXIT_UNKNOWN, so I added those. One case had exit_reason = 0,
which I changed to KVM_EXIT_UNKNOWN.
I did a pass over all of the return 0 paths in the exit handler
callbacks, so this should cover everything.
Signed-off-by: Jeff Dike
It looks like kvm_hypercall is trying to match the system call
convention and mixed up the call number and first argument in the
32-bit case.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
drivers/kvm/kvm_main.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: kvm/d
On Tue, Jul 17, 2007 at 09:15:51AM -0500, Anthony Liguori wrote:
> I'm planning on breaking this interface again since the new hypercall
> API only takes 4 arguments instead of 6.
Is anything written anywhere about this hypercall interface?
The thing which would make me happy (which the current
On Tue, Jul 17, 2007 at 11:12:53AM +0300, Avi Kivity wrote:
> I believe that emulate_instruction will set run->mmio if it returns
> EMULATE_DO_MMIO.
Righto, forgot to check that. How about this patch instead?
Set exit_reason to KVM_EXIT_MMIO where run->mmio is initialized.
Signed-
On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote:
> Within the kernel right (VMCALL is only usable in ring 1).
Yup.
> Is it
> terribly important to be able to pass through the syscall arguments in
> registers verses packing them in a data structure and passing a pointer
> to t
On Mon, Jul 23, 2007 at 01:27:40PM +0300, Avi Kivity wrote:
> Having an address_space (like your patch does) is remarkably simple, and
> requires few hooks from the current vm. However using existing vmas
> mapped by the user has many advantages:
It's also needed for a SKAS-like UML client, whe
On Tue, Jul 24, 2007 at 08:22:53AM +0300, Avi Kivity wrote:
> Even in the current model, guest physical memory is mmap()ed into host
> userspace.
I want it to be identity-mapped, which a single address space would
guarantee. For things which change mappings, like vmalloc, I need to
be in the same
11 matches
Mail list logo
