Re: [kvm-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
the instructions in memory. Does the Qemu GDB stub advertise breakpoint support? If not, the only support needed in KVM would be to send all debug interrupts to qemu, and allow qemu to send them back down for in-guest breakpoints. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
On Wednesday 14 May 2008 14:10:06 Jan Kiszka wrote: Hollis Blanchard wrote: On Wednesday 14 May 2008 10:28:51 Jan Kiszka wrote: So gdb on power relies only on those few hw-breakpoints? With x86 you can perfectly run gdb (with soft BPs) in parallel with the gdbstub (currently based on hw

Re: [kvm-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
memory. - The stub doesn't care how the hardware registers were configured. All it needs to know is a) that a breakpoint was hit, and b) at what address. Does this make sense? -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
On Wednesday 14 May 2008 16:06:00 Hollis Blanchard wrote: In fact, in the case of soft breakpoints, KVM doesn't even know where all the set breakpoints are. Side note: I'm retract this sentence: I wrote it before I sketched out the pseudocode, and forgot to remove it. :) -- Hollis

Re: [kvm-devel] [kvm-ppc-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
On Wednesday 14 May 2008 16:11:39 Hollis Blanchard wrote: On Wednesday 14 May 2008 16:06:00 Hollis Blanchard wrote: In fact, in the case of soft breakpoints, KVM doesn't even know where all the set breakpoints are. Side note: I'm retract this sentence: I wrote it before I sketched out

Re: [kvm-devel] kvm trace support for ppc

2008-05-14 Thread Hollis Blanchard
, but at least it would be functional. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 2] [RESEND] [PowerPC] Fix setting memory for bamboo board model

2008-05-05 Thread Hollis Blanchard
that it can be something other then the hard coded memory size of 144MB. Signed-off-by: Jerone Young [EMAIL PROTECTED] Acked-by: Hollis Blanchard [EMAIL PROTECTED] Avi, please apply to kvm-userspace; thanks. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [PATCH] Handle vma regions with no backing page (v2)

2008-04-30 Thread Hollis Blanchard
Andrea's answered this, but for the record: I believe ioremap() will get you struct pages on PPC, but they don't automatically exist. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix kvm-userspace configure script so that cc=gcc

2008-04-30 Thread Hollis Blanchard
@@ prefix=/usr/local kerneldir=/lib/modules/$(uname -r)/build -cc=cc +cc=gcc ld=ld objcopy=objcopy want_module=1 To clarify: there is no such thing as ${cross_prefix}cc, so the configure script is currently broken for cross-compiling. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Update kernel/Makefile and remove x86 only entries

2008-04-30 Thread Hollis Blanchard
    hack-files-x86 = ... hack-files-ppc = ... hack-files = $(hack-files-$(ARCH_DIR)) Agreed; this is exactly what I had suggested previously. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 3] Add function dt_cell_multi to hw/device_tree.c

2008-04-29 Thread Hollis Blanchard
; Could you please be more careful with your whitespace? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still

[kvm-devel] Fwd: [kvm-ppc-devel] [PATCH] kvmppc: deliver INTERRUPT_FP_UNAVAIL to the guest

2008-04-29 Thread Hollis Blanchard
Acked-by: Hollis Blanchard [EMAIL PROTECTED] Avi, please apply for 2.6.26. -- Hollis Blanchard IBM Linux Technology Center ---BeginMessage--- From: Christian Ehrhardt [EMAIL PROTECTED] This patch adds the delivery of INTERRUPT_FP_UNAVAIL exceptions to the guest. It's needed if a guest uses ppc

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 3] Add PowerPC KVM guest wait handling support

2008-04-25 Thread Hollis Blanchard
[WE]. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 3] Add premption handlers properly wake sleeping guest

2008-04-25 Thread Hollis Blanchard
, because there is no other state that our guest can load into the hardware that is not handled by a regular context switch. If that's true, we should only need vcpu_load/put() on paths where we muck with the TLB behind the host's back, and that is only in the run path. -- Hollis Blanchard IBM

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 3] Fix guest eating 100% cpu when guest is idle on PowerPC

2008-04-25 Thread Hollis Blanchard
CPU *does* an idling guest consume? By the way, you don't explicitly *unset* MSR[WE]. I think this works implicitly because of the way we deliver interrupts; could you add a comment explaining that? -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] Moving kvm lists to kernel.org?

2008-04-24 Thread Hollis Blanchard
through the automated filters. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
definition. Anyways, we've already fallen into this situation with the virtio ring data itself, so we're really saying same endianness as the ring. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
, including the ring? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
On Tuesday 22 April 2008 16:05:38 Rusty Russell wrote: On Wednesday 23 April 2008 06:29:14 Hollis Blanchard wrote: On Tuesday 22 April 2008 09:31:35 Rusty Russell wrote: We may still regret not doing *everything* little-endian, but this doesn't make it worse. Hmm, why *don't* we just

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
On Tuesday 22 April 2008 17:13:01 Anthony Liguori wrote: Hollis Blanchard wrote: On Tuesday 22 April 2008 16:05:38 Rusty Russell wrote: On Wednesday 23 April 2008 06:29:14 Hollis Blanchard wrote: On Tuesday 22 April 2008 09:31:35 Rusty Russell wrote: We may still

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
On Tuesday 22 April 2008 17:13:01 Anthony Liguori wrote: Hollis Blanchard wrote: On Tuesday 22 April 2008 16:05:38 Rusty Russell wrote: On Wednesday 23 April 2008 06:29:14 Hollis Blanchard wrote: On Tuesday 22 April 2008 09:31:35 Rusty Russell wrote: We may still

[kvm-devel] [PATCH] [QEMU POWERPC] FPRs no longer live in kvm_vcpu

2008-04-18 Thread Hollis Blanchard
Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] diff --git a/qemu/qemu-kvm-powerpc.c b/qemu/qemu-kvm-powerpc.c --- a/qemu/qemu-kvm-powerpc.c +++ b/qemu/qemu-kvm-powerpc.c @@ -72,7 +72,6 @@ for (i = 0;i 32; i++){ regs.gpr[i] = env-gpr[i]; -regs.fpr[i] = env-fpr[i

[kvm-devel] [PATCH] [POWERPC KVM] Kconfig fixes

2008-04-17 Thread Hollis Blanchard
1 file changed, 5 insertions(+), 6 deletions(-) arch/powerpc/kvm/Kconfig | 11 +-- Don't allow building as a module (asm-offsets dependencies). Also, automatically select KVM_BOOKE_HOST until we better separate the guest and host layers. Signed-off-by: Hollis Blanchard [EMAIL

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1/5]Add some trace markers and exposeinterfaces in kernel for tracing

2008-04-17 Thread Hollis Blanchard
buffers. The header could be written in tip_open_output(), and update fs_size accordingly. Do you have any suggestions for the format of the metadata? I'm not sure how it should fit into the record format expected by kvmtrace_format. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [PATCH 1/2] kvm-s390: provide ge t/set_mp_state stubs to fix compile error

2008-04-16 Thread Hollis Blanchard
By the way Marcelo, it would be polite to provide these stubs yourself to avoid breaking the build on other architectures. It looks like IA64 is still broken because of this. -- Hollis Blanchard IBM Linux Technology Center On Wednesday 16 April 2008 09:06:34 Carsten Otte wrote: From

Re: [kvm-devel] [PATCH] add virtio disk geometry feature

2008-04-16 Thread Hollis Blanchard
we need explicit *_val[8,16,32,64]? Implicit byteswapping based on access size is the standard way of implementing accessors. In this case, reading each structure member individually will do the right implicit swapping, rather than trying to load the whole thing as a single access. -- Hollis

Re: [kvm-devel] [PATCH] [kvm-userspace] Make make sync in kernel dir work for multiple archs

2008-04-15 Thread Hollis Blanchard
over those? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code

Re: [kvm-devel] [PATCH] [kvm-userspace] Make make sync in kernel dir work for multiple archs

2008-04-15 Thread Hollis Blanchard
or break anything. Right, they are only used for x86. So as I said before, create arch-specific HACK_FILES and UNIFDEF_FILES variables, and use those instead. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] [v2 ][kvm-userspace] Make make sync in kern el dir work for multiple archs

2008-04-15 Thread Hollis Blanchard
$(ARCH_DIR) $1.orig $1; \ [ $$? -le 1 ] rm $1.orig This isn't going to work because you've changed -DCONFIG_X86 to -DCONFIG_x86 . -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored

Re: [kvm-devel] [PATCH 1/5]Add some trace markers and expose interfaces in kernel for tracing

2008-04-15 Thread Hollis Blanchard
need bitfields here? They are notoriously non-portable. Practically speaking, this will prevent me from copying a trace file from my big-endian target to my little-endian workstation for analysis, at least without some ugly hacking in the userland tool. -- Hollis Blanchard IBM Linux Technology

[kvm-devel] [PATCH] [KVM] Rename debugfs_dir to kvm_debugfs_dir

2008-04-15 Thread Hollis Blanchard
3 files changed, 7 insertions(+), 7 deletions(-) include/linux/kvm_host.h |2 +- virt/kvm/kvm_main.c |8 virt/kvm/kvm_trace.c |4 ++-- # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1208293411 18000 # Node ID

Re: [kvm-devel] [PATCH 1/5]Add some trace markers and exposeinterfaces in kernel for tracing

2008-04-15 Thread Hollis Blanchard
On Tuesday 15 April 2008 22:13:28 Liu, Eric E wrote: Hollis Blanchard wrote: On Wednesday 09 April 2008 05:01:36 Liu, Eric E wrote: +/* This structure represents a single trace buffer record. */ +struct kvm_trace_rec { +   __u32 event:28; +   __u32 extra_u32:3; +   __u32

Re: [kvm-devel] [PATCH 2 of 3] [KVM] Add DCR access information to struct kvm_run

2008-04-07 Thread Hollis Blanchard
On Monday 07 April 2008 20:11:28 David Gibson wrote: On Mon, Apr 07, 2008 at 03:53:33PM -0500, Hollis Blanchard wrote: 1 file changed, 7 insertions(+) include/linux/kvm.h |7 +++ Device Control Registers are essentially another address space found on PowerPC 4xx processors

Re: [kvm-devel] [PATCH 3 of 3] [KVM POWERPC] PowerPC 440 KVM implementation

2008-04-07 Thread Hollis Blanchard
On Monday 07 April 2008 21:12:40 Josh Boyer wrote: On Mon, 07 Apr 2008 15:53:34 -0500 Hollis Blanchard [EMAIL PROTECTED] wrote: Currently supports only PowerPC 440 Linux guests on 440 hosts. (Only tested with 440EP Bamboo guests so far, but with appropriate userspace support other SoC

Re: [kvm-devel] [PATCH 2 of 3] [KVM] Add DCR access information to struct kvm_run

2008-04-07 Thread Hollis Blanchard
On Monday 07 April 2008 22:54:41 David Gibson wrote: On Mon, Apr 07, 2008 at 10:25:32PM -0500, Hollis Blanchard wrote: On Monday 07 April 2008 20:11:28 David Gibson wrote: On Mon, Apr 07, 2008 at 03:53:33PM -0500, Hollis Blanchard wrote: 1 file changed, 7 insertions(+) include/linux

Re: [kvm-devel] [PATCH 3 of 3] [KVM POWERPC] PowerPC 440 KVM implementation

2008-04-07 Thread Hollis Blanchard
On Monday 07 April 2008 21:58:17 Arnd Bergmann wrote: On Monday 07 April 2008, Hollis Blanchard wrote: --- a/include/asm-powerpc/kvm.h +++ b/include/asm-powerpc/kvm.h @@ -1,6 +1,55 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms

Re: [kvm-devel] booting from virtio-blk

2008-04-01 Thread Hollis Blanchard
On Tue, 2008-04-01 at 09:46 -0500, Anthony Liguori wrote: Hollis Blanchard wrote: On Tue, 2008-04-01 at 14:08 +0200, Christian Ehrhardt wrote: bash-3.00# cat /proc/partitions major minor #blocks name [...] 254 0 22517998136852480 vda - ?broken? My guess

Re: [kvm-devel] [PATCH] Fix endianness for virtio-blk config space

2008-04-01 Thread Hollis Blanchard
= 128 - 2; +blkcfg.capacity = cpu_to_le64(capacity); +blkcfg.seg_max = cpu_to_le32(128 - 2); memcpy(config, blkcfg, sizeof(blkcfg)); } Fixes virtio-blk for PowerPC KVM. Acked-by: Hollis Blanchard [EMAIL PROTECTED] -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] booting from virtio-blk

2008-04-01 Thread Hollis Blanchard
to be little endian just like the PCI config space. The point is that a virtio device appears as a PCI device. Like all other PCI devices, it has config space. Unlike all other PCI devices, its config space is accessed with 1-byte reads. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] buliding and testing PowerPC KVM

2008-03-25 Thread Hollis Blanchard
On Tue, 2008-03-25 at 18:56 +0200, Avi Kivity wrote: Hollis Blanchard wrote: On Fri, 2008-03-21 at 13:02 +0200, Avi Kivity wrote: Other than that, and the few minor comments that popped up, this (very nice) patchset will be very easy to merge. IIRC you mentioned it is possible

Re: [kvm-devel] buliding and testing PowerPC KVM

2008-03-21 Thread Hollis Blanchard
). In the future we should be able to run 440 guests on e.g. POWER5 hosts, but we've already got our hands full without that. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all

Re: [kvm-devel] [PATCH][QEMU] Use a separate device for in-kernel PIT

2008-03-21 Thread Hollis Blanchard
... -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01

Re: [kvm-devel] [PATCH] Move kvm_get_pit to libkvm.c common code

2008-03-21 Thread Hollis Blanchard
is eroding my idealism.) The qemu breakage is fixed by Anthony's PIT patch that creates i8254-kvm.c. Don't compile kvm_*_pit() on architectures whose currently supported platforms do not contain a PIT. Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] diff --git a/libkvm/libkvm.h b/libkvm

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix undefined refrence of qemu_system_device_hot_add for non x86 archs

2008-03-19 Thread Hollis Blanchard
, }, }; Why would we build any of this code? This whole file should be disabled at the Makefile level (with a configure patch to ifdef in monitor.c). -- Hollis Blanchard IBM Linux Technology Center - This SF.net email

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-19 Thread Hollis Blanchard
On Wed, 2008-03-19 at 09:45 -0500, Jerone Young wrote: Add ability to specify ram on command line for bamboo board model I get the following output with this patch: ... Ram size passed is: 144 MB WARNING: -368 MB left over memory is ram ... -- Hollis Blanchard

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-18 Thread Hollis Blanchard
is ram\n, + bytes_to_mb((int)tmp_ram_size)); + ram_size -= tmp_ram_size; + } /* Setup CPU */ env = cpu_ppc_init(440); Remove tmp_ram_size completely. Just decrement ram_size in the loop and check if it's non-zero at the end. -- Hollis Blanchard

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uimage() gunzip support to uboot loader in Qemu

2008-03-18 Thread Hollis Blanchard
= tmp_loaded_image_size; + +if ( load_address != NULL) + *load_address = hdr-ih_load; Your whitespace in here is all over the place. Please fix. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 7] Add libfdt support to qemu

2008-03-18 Thread Hollis Blanchard
it in the patch description? Did you mean to fix this before committing? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation change uboot loader for PPC bamboo board model

2008-03-18 Thread Hollis Blanchard
; target_ulong initrd_base=0; - target_ulong initrd_size=0; + target_long initrd_size=0; + target_ulong dt_base=0; + void *fdt; + int ret; + + uint32_t cpu_freq; + uint32_t timebase_freq; Why is there an extra blank line here? -- Hollis Blanchard IBM Linux

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 7] Add libfdt support to qemu

2008-03-18 Thread Hollis Blanchard
OK, if that's acceptable to the qemu folks, could you put that in the patch description? -- Hollis Blanchard IBM Linux Technology Center On Tue, 2008-03-18 at 16:22 -0500, Jerone Young wrote: So this is the code Anthony asked for for probing libfdt. The problem is that if you do ./configure

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation change uboot loader for PPC bamboo board model

2008-03-18 Thread Hollis Blanchard
I can only assume that you will actually make the corrections that you didn't respond to in this mail. On Tue, 2008-03-18 at 16:35 -0500, Jerone Young wrote: On Tue, 2008-03-18 at 16:25 -0500, Hollis Blanchard wrote: +#define DT_PROC_INTERFACE_PATH /proc/device-tree + +/* FUNCTIONS

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uimage() gunzip support to uboot loader in Qemu

2008-03-18 Thread Hollis Blanchard
On Tue, 2008-03-18 at 16:46 -0500, Jerone Young wrote: On Tue, 2008-03-18 at 16:14 -0500, Hollis Blanchard wrote: On Tue, 2008-03-18 at 15:06 -0500, Jerone Young wrote: +tmp_loaded_image_size = hdr-ih_size; + +if (hdr-ih_comp == IH_COMP_GZIP) { + uncompressed_data

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source binary into qemu

2008-03-14 Thread Hollis Blanchard
There is no zImage, so those comments do not make sense. Filled in by loader would be more accurate. You left MAL0 and EMAC0 commented out; please remove them. You left PCI0 uncommented; please comment it out until qemu actually emulates the PCI controller. -- Hollis Blanchard IBM Linux

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-14 Thread Hollis Blanchard
] = 0x0; + ram_sizes[1] = ram_sticks[1]; Why keep a separate ram_sticks[] array? Just operate directly on ram_sizes[], and while you're at it stop hardcoding 2 entries: the SDRAM controller can emulate all 4. Also, ram_bases[1] here is very wrong; that definitely needs to be fixed. -- Hollis

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 7] [v2] PowerPC kvm-userspace patches

2008-03-14 Thread Hollis Blanchard
On Fri, 2008-03-14 at 12:09 -0500, Jerone Young wrote: This set address issues disscussed by Hollis on the first go around. As well as some minor fixes. Btw, please also update the description for patches 3 and 5 to rename load_uboot_l. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-12 Thread Hollis Blanchard
break if ram: print warning: %d left over % ram print reg -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1 of 7] Add libfdt to KVM userspace

2008-03-12 Thread Hollis Blanchard
of including it? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uboot() gunzip support to uboot loader in Qemu

2008-03-12 Thread Hollis Blanchard
is handled already. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source binary into qemu

2008-03-12 Thread Hollis Blanchard
-start = 0; + linux,initrd-end = 0; + bootargs = ; + }; +}; Why is bootargs filled with spaces? Also, do the initrd properties need to be present? I thought you figured out how to add them at runtime. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation change uboot loader for PPC bamboo board model

2008-03-12 Thread Hollis Blanchard
the path in from the caller. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 7] PowerPC kvm-userspace patches

2008-03-12 Thread Hollis Blanchard
our initrd troubles have anything to do with qemu, so I wouldn't worry about that here. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual

Re: [kvm-devel] [PATCH 3/6] kvm: qemu: Add option for enable/disable in kernel PIT

2008-03-11 Thread Hollis Blanchard
non-x86 architectures, since common code now calls functions defined only in libkvm-x86.c . -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R

Re: [kvm-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
into any codebase that needs it. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt

Re: [kvm-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
On Wed, 2008-02-27 at 17:48 +0100, Alexander Graf wrote: On Feb 27, 2008, at 5:34 PM, Avi Kivity wrote: Hollis Blanchard wrote: It is a centrally co-ordinated effort, but it is not a package a distro would carry. It is code shared by anything that needs to load a PowerPC Linux

Re: [kvm-devel] [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
On Wed, 2008-02-27 at 20:18 +0100, Alexander Graf wrote: On Feb 27, 2008, at 7:56 PM, Hollis Blanchard wrote: On Wed, 2008-02-27 at 17:48 +0100, Alexander Graf wrote: On Feb 27, 2008, at 5:34 PM, Avi Kivity wrote: Hollis Blanchard wrote: It is a centrally co-ordinated effort

Re: [kvm-devel] [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
On Wed, 2008-02-27 at 22:20 +0100, Alexander Graf wrote: On Feb 27, 2008, at 9:22 PM, Hollis Blanchard wrote: So again, we the potential users are qemu and dtc. Just while reading this I thought Hey cool, dtc is packaged in most distributions anyway. So why not modify dtc to provide

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix qemu PPC breakage in monitor.c

2008-02-27 Thread Hollis Blanchard
) qemu_system_cpu_hot_add(value, state); +#endif } static void do_info_jit(void) This should be submitted to qemu-devel too, no? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix PowerPC Qemu CPU initilization when using target-ppc/fake-exec.c

2008-02-26 Thread Hollis Blanchard
Acked-by: Hollis Blanchard [EMAIL PROTECTED] Avi, please apply. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http

Re: [kvm-devel] [PATCH] Using kzalloc to avoid allocating kvm_regs from kernel stack

2008-02-25 Thread Hollis Blanchard
On Mon, 2008-02-25 at 10:38 -0600, Hollis Blanchard wrote: On Mon, 2008-02-25 at 17:34 +0800, Zhang, Xiantao wrote: From: Xiantao Zhang [EMAIL PROTECTED] Date: Mon, 25 Feb 2008 17:11:43 +0800 Subject: [PATCH] kvm: Using kzalloc to avoid allocating kvm_regs from kernel stack. Since

Re: [kvm-devel] [PATCH] Using kzalloc to avoid allocating kvm_regs from kernel stack

2008-02-25 Thread Hollis Blanchard
(struct kvm_regs))) goto out; - r = kvm_arch_vcpu_ioctl_set_regs(vcpu, kvm_regs); + r = kvm_arch_vcpu_ioctl_set_regs(vcpu, kvm_regs); if (r) goto out; r = 0; Where is this freed? -- Hollis

Re: [kvm-devel] [kvm-ppc-devel] upstream PowerPC qemu breakage

2008-02-18 Thread Hollis Blanchard
On Sat, 2008-02-16 at 10:47 +0200, Avi Kivity wrote: Hollis Blanchard wrote: On Wed, 2008-02-13 at 08:58 +0200, Avi Kivity wrote: It'll need to be built against your kernel tree; please provide a URL. curl http://penguinppc.org/~hollisb/kvm/kvm-powerpc.mbox | git-am

Re: [kvm-devel] [kvm-ppc-devel] upstream PowerPC qemu breakage

2008-02-18 Thread Hollis Blanchard
On Mon, 2008-02-18 at 22:22 +0200, Avi Kivity wrote: Hollis Blanchard wrote: Unfortunately I wasn't able to get an F8 ppc rescue cd ISO to boot with qemu 0.9.0. Can you point me to a working combination? It's difficult to get anything booting with upstream PowerPC qemu, mostly

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching

2008-02-17 Thread Hollis Blanchard
that 'queue' is physically contiguous, which is not necessarily true one you cross a page boundary. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges

Re: [kvm-devel] [kvm-ppc-devel] upstream PowerPC qemu breakage

2008-02-15 Thread Hollis Blanchard
On Wed, 2008-02-13 at 08:58 +0200, Avi Kivity wrote: It'll need to be built against your kernel tree; please provide a URL. curl http://penguinppc.org/~hollisb/kvm/kvm-powerpc.mbox | git-am -- Hollis Blanchard IBM Linux Technology Center

[kvm-devel] KVM's signal masking

2008-02-14 Thread Hollis Blanchard
to be delivered? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01

Re: [kvm-devel] upstream PowerPC qemu breakage

2008-02-12 Thread Hollis Blanchard
On Tue, 2008-02-12 at 12:45 +0200, Avi Kivity wrote: Hollis Blanchard wrote: Long term, one option is to try to define a new qemu target that completely bypasses the code generation parts of qemu. Anthony did that for x86 once, but there are at least a couple sticking points; not sure how

[kvm-devel] upstream PowerPC qemu breakage

2008-02-11 Thread Hollis Blanchard
feasible. I guess merging with qemu while it's in a period of massive change wasn't the most opportune moment. Were there some device model changes you were eager to pick up? -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add print for PowerPC qemu for failed DCR read/writes

2008-02-06 Thread Hollis Blanchard
Yeah, rate-limiting makes sense. Maybe we could take it one step further and only print the warning the first time a particular unemulated DCR is accessed. I also agree about the captalization. :) -- Hollis Blanchard IBM Linux Technology Center On Wed, 2008-02-06 at 12:25 +0100, Christian

Re: [kvm-devel] [PATCH 0 of 3] RFC: creating a particular vcpu type

2008-02-05 Thread Hollis Blanchard
layout, and people do it in hardware (again, not running a single system image). VCPU type is a VCPU property, and I think the design should reflect that, and as you can see from the patch it's not at all difficult to do. -- Hollis Blanchard IBM Linux Technology Center On Tue, 2008-02-05 at 10:44

Re: [kvm-devel] [PATCH 0 of 3] RFC: creating a particular vcpu type

2008-02-05 Thread Hollis Blanchard
On Tue, 2008-02-05 at 12:05 -0600, Anthony Liguori wrote: Hollis Blanchard wrote: If it's the ioctl in the function name you object to, that's easily changed. It's not the name, it's what you're doing. You're introducing an architecture specific ioctl that essentially overrides

Re: [kvm-devel] [PATCH] Make non-x86 arch partially support make sync.

2008-02-04 Thread Hollis Blanchard
-rf tmp -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01

[kvm-devel] [PATCH 0 of 3] RFC: creating a particular vcpu type

2008-02-04 Thread Hollis Blanchard
These patches allow PowerPC to create vcpus of a particular type. Since we are actually emulating the core's supervisor mode, we can choose to emulate any type of core. However, since the core chosen will change the size of the vcpu structure (among other things), we need to know it at vcpu

[kvm-devel] [PATCH 1 of 3] Pass an opaque parameter through kvm_vm_ioctl_vcpu_create() to kvm_arch_vcpu_create()

2008-02-04 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1202189664 21600 # Node ID bede9476e203f5bf59d21cc3cd71a30de2ce2c44 # Parent dfb0e1d58b57dfdf76b3111565815599bd38b92d Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] --- 4 files changed, 9 insertions(+), 7 deletions(-) arch

[kvm-devel] [PATCH 3 of 3] [POWERPC] Implement an ioctl that creates a vcpu of a particular type

2008-02-04 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1202189668 21600 # Node ID e6e0239e8df55c6af4e0b2959350215aaa119254 # Parent 7dd50dab9096c8e0125792e3f48083c3f47fceab The ioctl accepts a core name as input and calls kvm_vm_ioctl_create_vcpu() with the corresponding guest

Re: [kvm-devel] [kvm-ppc-devel] [RFC PATCH] KVM for PowerPC: simpler TLB handling, better page management

2008-02-01 Thread Hollis Blanchard
On Fri, 2008-02-01 at 13:07 -0600, Nathan Lynch wrote: Hollis Blanchard wrote: --- a/arch/powerpc/kernel/asm-offsets.c +++ b/arch/powerpc/kernel/asm-offsets.c @@ -22,6 +22,7 @@ #include linux/mman.h #include linux/mm.h #include linux/suspend.h +#include linux/kvm_host.h #ifdef

Re: [kvm-devel] [PATCH] Remove unoptimal code from qemu dcr handles for powerpc

2008-01-29 Thread Hollis Blanchard
[EMAIL PROTECTED] Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http

Re: [kvm-devel] [PATCH] Cleanup extern declerations for now removed vcpu_env in Qemu

2008-01-29 Thread Hollis Blanchard
in Qemu This patch removes extern decleration for vcpu_env that was recently removed for PowerPC IA64 in KVM. Signed-off-by: Jerone Young [EMAIL PROTECTED] Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Clean up KVM/QEMU interaction

2008-01-29 Thread Hollis Blanchard
. Qemu seems to conform to the broken window theory... -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-29 Thread Hollis Blanchard
On Tue, 2008-01-29 at 18:22 -0500, Chris Lalancette wrote: Hollis Blanchard wrote: diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -67,7 +67,9 @@ void kvm_io_bus_register_dev(struct kvm_ struct

Re: [kvm-devel] [PATCH] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-29 Thread Hollis Blanchard
On Tue, 2008-01-29 at 18:22 -0500, Chris Lalancette wrote: Hollis Blanchard wrote: diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -67,7 +67,9 @@ void kvm_io_bus_register_dev(struct kvm_ struct

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches

2008-01-28 Thread Hollis Blanchard
the Bamboo setup will be useless to qemu until they get 440 support. That said, there are only 2 places that we make KVM-specific calls in this code, and those can easily be protected with kvm_allowed checks in the future. -- Hollis Blanchard IBM Linux Technology Center

[kvm-devel] [PATCH] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-28 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1201563731 21600 # Node ID 6a2f4869cf5da00fa0ccacc9188ea493459ce4cb # Parent a6dd6b5a597903a069cb9711f73ea1b5c4f0b764 This allows kvm_host.h to be #included even when struct preempt_notifier is undefined. This is needed

[kvm-devel] [PATCH 0 of 6] Enhance PowerPC unit tests

2008-01-18 Thread Hollis Blanchard
These patches create libcflat for PowerPC and allow testcases to communicate with kvmctl via MMIO. They culminate in a C testcase that returns an error code through kvmctl to the shell. The x86 Makefiles looked hairy enough that I didn't want to mess with them, but it should be fairly easy to

[kvm-devel] [PATCH 1 of 2] Define and use CONFIG_KVM_HAS_PIO so that we don't need pio_data in kvm_arch_vcpu

2008-01-18 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1200434310 21600 # Node ID 7fa5947a2da8c0c7424ebdcfaebcae624d6cf015 # Parent ee0c227fe3f6632f4b1b5fde3f7e05c8ea0a4378 Signed-off-by: Hollis Blanchard [EMAIL PROTECTED] Signed-off-by: Christian Ehrhardt [EMAIL PROTECTED] --- 2

Re: [kvm-devel] [PATCH 2 of 2] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-16 Thread Hollis Blanchard
On Wed, 2008-01-16 at 10:08 +0200, Avi Kivity wrote: Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1200434370 21600 # Node ID 9878c9cec5f831ff5e9b97539aabc5fa3d934501 # Parent 931a81e1002110be0e8bf5b335bf199d43534c2c This allows

Re: [kvm-devel] [kvm-ppc-devel] RFC: MMIO endianness flag

2008-01-15 Thread Hollis Blanchard
On Tue, 2008-01-15 at 16:57 +0200, Avi Kivity wrote: Hollis Blanchard wrote: btw, isn't passthrough better handled through the tlb? i.e. actually let the guest access the specially-configured memory? You can have qemu mmap /dev/mem and install it as a memslot, and things should work

Re: [kvm-devel] [kvm-ppc-devel] RFC: MMIO endianness flag

2008-01-14 Thread Hollis Blanchard
. -- Hollis Blanchard IBM Linux Technology Center On Mon, 2008-01-14 at 13:42 +0800, Xu, Anthony wrote: kvm_run-mmio.is_bigendian = vcpu-arch.some_register From your example code, I can know is_bigendian indicate whether guest is in bigendian mode when accessing MMIO. Qemu is responsible

Re: [kvm-devel] [kvm-ppc-devel] RFC: MMIO endianness flag

2008-01-14 Thread Hollis Blanchard
at offset address. Now here's the catch: what endianness does qemu use when doing the write? If qemu only does BE, then a LE access from the guest will be byte-reversed when presented to the real hardware. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] RFC: MMIO endianness flag

2008-01-11 Thread Hollis Blanchard
BIGENDIAN; If IA64 has reverse-endian load/store instructions like PowerPC, then you would also need to consider the particular instruction used as well as the guest state. -- Hollis Blanchard IBM Linux Technology Center On Fri, 2008-01-11 at 10:02 +0800, Xu, Anthony wrote: Hi all, That's

Re: [kvm-devel] RFC: MMIO endianness flag

2008-01-10 Thread Hollis Blanchard
-Reverse Indexed) does a little-endian 4-byte load. These instructions exist on all PowerPC, and they can be issued at any time and do not depend on MMU mappings. -- Hollis Blanchard IBM Linux Technology Center - Check out

  1   2   3   >