Re: [kvm-devel] [Qemu-devel] Re: [PATCH] Add support for a configuration file

2008-05-15 Thread Laurent Vivier
Le jeudi 15 mai 2008 à 15:04 +0300, Avi Kivity a écrit : Daniel P. Berrange wrote: On Thu, May 15, 2008 at 11:04:47AM +0300, Avi Kivity wrote: Daniel P. Berrange wrote: With this kind of syntax, now tools generating config files need to make up unique names for each drive. So

[kvm-devel] [PATCH 1/2][RFC][v2] kvm: Batch writes to MMIO

2008-05-15 Thread Laurent Vivier
-by: Laurent Vivier [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 172 include/asm-x86/kvm.h |7 ++ include/asm-x86/kvm_host.h | 23 ++ include/linux/kvm.h| 16 virt/kvm/kvm_main.c|3 + 5 files changed, 221

[kvm-devel] [PATCH 0/2][RFC][v2] Batch writes to MMIO

2008-05-15 Thread Laurent Vivier
- userspace part Signed-off-by: Laurent Vivier [EMAIL PROTECTED] - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01

[kvm-devel] [PATCH 2/2][RFC][v2] kvm-userspace: Batch writes to MMIO

2008-05-15 Thread Laurent Vivier
This patch is userspace part of the batch writes to MMIO patch. It defines delayed MMIO zone using kvm_set_mmio() (for VGA and e1000). It empties the ring buffer and process the MMIO accesses. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- libkvm/libkvm-x86.c | 18

Re: [kvm-devel] Protected mode transitions and big real mode... still an issue

2008-04-29 Thread Laurent Vivier
Le mardi 29 avril 2008 à 11:41 -0500, Anthony Liguori a écrit : Guillaume Thouvenin wrote: Hello, This patch should solve the problem observed during protected mode transitions that appears for example during the installation of openSuse-10.3. Unfortunately there is an issue that

Re: [kvm-devel] Protected mode transitions and big real mode... still an issue

2008-04-29 Thread Laurent Vivier
Le mardi 29 avril 2008 à 19:09 +0200, Laurent Vivier a écrit : Le mardi 29 avril 2008 à 11:41 -0500, Anthony Liguori a écrit : Guillaume Thouvenin wrote: Hello, This patch should solve the problem observed during protected mode transitions that appears for example during

[kvm-devel] [PATCH 2/2] kvm-userspace: Batch writes to MMIO

2008-04-23 Thread Laurent Vivier
-by: Laurent Vivier [EMAIL PROTECTED] --- libkvm/libkvm.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index 329f29f..be74477 100644 --- a/libkvm/libkvm.c +++ b/libkvm/libkvm.c @@ -864,6 +864,10 @@ int kvm_run(kvm_context_t kvm

[kvm-devel] [PATCH 0/2] Batch writes to MMIO

2008-04-23 Thread Laurent Vivier
compatibility with old userspace part. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] [PATCH 1/2] kvm: Batch writes to MMIO - kernel part [PATCH 2/2] kvm-userspace: Batch writes to MMIO - userspace part Signed-off-by: Laurent Vivier [EMAIL PROTECTED

[kvm-devel] [PATCH 1/2] kvm: Batch writes to MMIO

2008-04-23 Thread Laurent Vivier
: this breaks compatibility with old userspace part. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 21 + include/asm-x86/kvm_host.h |2 ++ include/linux/kvm.h| 10 +- virt/kvm/kvm_main.c|3 +++ 4 files changed, 35

Re: [kvm-devel] [PATCH 0/2] Batch writes to MMIO

2008-04-23 Thread Laurent Vivier
Le mercredi 23 avril 2008 à 17:05 +0300, Avi Kivity a écrit : Laurent Vivier wrote: These two patches allow to batch writes to MMIO. When kernel has to send MMIO writes to userspace, it stores them in memory until it has to pass the hand to userspace for another reason. This avoids

Re: [kvm-devel] [PATCH 0/2] Batch writes to MMIO

2008-04-23 Thread Laurent Vivier
Le mercredi 23 avril 2008 à 10:10 -0500, Anthony Liguori a écrit : [...] The ne2k is pretty mmio heavy. You should be able to observe a boost with something like iperf (guest=host) I would think if this is a real savings. I like your advices :-D I use iperf with e1000 emulation and a

Re: [kvm-devel] [PATCH 0/2] Batch writes to MMIO

2008-04-23 Thread Laurent Vivier
Le mercredi 23 avril 2008 à 19:25 +0300, Avi Kivity a écrit : Laurent Vivier wrote: Le mercredi 23 avril 2008 à 10:10 -0500, Anthony Liguori a écrit : [...] The ne2k is pretty mmio heavy. You should be able to observe a boost with something like iperf (guest=host) I would think

Re: [kvm-devel] [PATCH 0/2] Batch writes to MMIO

2008-04-23 Thread Laurent Vivier
Le mercredi 23 avril 2008 à 11:48 -0500, Anthony Liguori a écrit : Laurent Vivier wrote: Le mercredi 23 avril 2008 à 19:25 +0300, Avi Kivity a écrit : Laurent Vivier wrote: Le mercredi 23 avril 2008 à 10:10 -0500, Anthony Liguori a écrit : [...] The ne2k

Re: [kvm-devel] [Qemu-devel] Re: [RFC] linuxboot Option ROM for Linux kernel booting

2008-04-22 Thread Laurent Vivier
Le mardi 22 avril 2008 à 08:50 -0500, Anthony Liguori a écrit : Nguyen Anh Quynh wrote: Hi, This should be submitted to upstream (but not to kvm-devel list), but this is only the test code that I want to quickly send out for comments. In case it looks OK, I will send it to upstream

Re: [kvm-devel] extboot usage?

2008-04-04 Thread Laurent Vivier
Le vendredi 04 avril 2008 à 18:29 +0900, Jun Koi a écrit : On 4/3/08, Anthony Liguori [EMAIL PROTECTED] wrote: Jun Koi wrote: Hi, Could someone please post some concret examples on how to use extboot? I looked around, but saw nothing. Just append boot=on to your -drive

Re: [kvm-devel] stable distro for kvm?

2008-02-14 Thread Laurent Vivier
Le jeudi 14 février 2008 à 23:46 +0200, Dor Laor a écrit : On Thu, 2008-02-14 at 12:08 -0500, Andrey Dmitriev wrote: If I want to stick to debian, would the best way to do this be to just download kvm60 source, compile the module and load it in, or does kernel still require upgrading (I

Re: [kvm-devel] kvm-59 doesn't work

2008-01-23 Thread Laurent Vivier
Le mercredi 23 janvier 2008 à 15:29 +0200, Izik Eidus a écrit : Izik Eidus wrote: Andi Kleen wrote: On Tue, Jan 15, 2008 at 12:56:52PM +0200, Avi Kivity wrote: Andi Kleen wrote: FWIW it seems things are broken even without -kernel in -59 too. If I try to boot an existing

Re: [kvm-devel] kvm-59 doesn't work

2008-01-23 Thread Laurent Vivier
Le mercredi 23 janvier 2008 à 14:38 +0100, Laurent Vivier a écrit : Le mercredi 23 janvier 2008 à 15:29 +0200, Izik Eidus a écrit : Izik Eidus wrote: Andi Kleen wrote: On Tue, Jan 15, 2008 at 12:56:52PM +0200, Avi Kivity wrote: Andi Kleen wrote: FWIW it seems things

Re: [kvm-devel] [Qemu-devel] Re: [RFC][PATCH] Modify loop device to be able to manage partitions of the image disk

2008-01-16 Thread Laurent Vivier
Le mercredi 16 janvier 2008 à 08:57 -0600, Anthony Liguori a écrit : Le mardi 15 janvier 2008 à 23:54 +, Daniel P. Berrange a écrit : [...] 2- I'd like to mount qcow2 or others disk image formats, so perhaps it's easier to modify loop device driver (but perhaps you know another magic

Re: [kvm-devel] kvm-userspace fails to compile

2008-01-15 Thread Laurent Vivier
Le mardi 15 janvier 2008 à 15:49 +, Christoph Hellwig a écrit : On Mon, Jan 07, 2008 at 03:25:50PM +0100, Laurent Vivier wrote: Perhaps a ./configure is needed. What's your HEAD? I have a5b3d2c9b4d4ca3e02f294d14c7df016e070bda7, which compiles fine. OK, I found where

Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

2008-01-07 Thread Laurent Vivier
PROTECTED] Doesn't the cache=off option warrant an allocation here to ensure alignment (or perhaps a 1K stack buffer with runtime adjustment)? You're right, a good patch should be something like this (it is not tested or even compiled) : Signed-off-by: Laurent Vivier [EMAIL PROTECTED] diff --git

Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

2008-01-07 Thread Laurent Vivier
Le lundi 07 janvier 2008 à 12:47 +0200, Avi Kivity a écrit : Laurent Vivier wrote: Le lundi 07 janvier 2008 à 11:27 +0200, Avi Kivity a écrit : Carlo Marcelo Arenas Belon wrote: revert a merge conflict from 075da586c92f09bd9a7401f1e80d72fde27c173 that redefined sector

[kvm-devel] kvm-userspace fails to compile

2008-01-07 Thread Laurent Vivier
The error is: libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_access_report': /home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:221: undefined reference to `kvm_enable_vapic' libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_opt_setup':

[kvm-devel] kvm-userspace fails to compile

2008-01-07 Thread Laurent Vivier
The error is: libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_access_report': /home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:221: undefined reference to `kvm_enable_vapic' libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_opt_setup':

Re: [kvm-devel] kvm-userspace fails to compile

2008-01-07 Thread Laurent Vivier
Le lundi 07 janvier 2008 à 15:26 +0200, Dor Laor a écrit : On Mon, 2008-01-07 at 14:14 +0100, Laurent Vivier wrote: The error is: libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_access_report': /home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:221: undefined reference

Re: [kvm-devel] kvm-userspace fails to compile

2008-01-07 Thread Laurent Vivier
Le lundi 07 janvier 2008 à 15:57 +0200, Avi Kivity a écrit : Laurent Vivier wrote: but a pull doesn't resolve anything (the clone has the same effect). Is the correction has been pushed... ? Should be... Perhaps a ./configure is needed. What's your HEAD? I have

Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

2008-01-07 Thread Laurent Vivier
Le lundi 07 janvier 2008 à 12:47 +0200, Avi Kivity a écrit : Laurent Vivier wrote: Le lundi 07 janvier 2008 à 11:27 +0200, Avi Kivity a écrit : Carlo Marcelo Arenas Belon wrote: revert a merge conflict from 075da586c92f09bd9a7401f1e80d72fde27c173 that redefined sector

Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

2008-01-07 Thread Laurent Vivier
Le lundi 07 janvier 2008 à 10:34 -0500, Javier Guerra a écrit : On 1/7/08, Laurent Vivier [EMAIL PROTECTED] wrote: What I'm wondering now is: is it really useful to have cache=off and snapshot=on at the same time ? does cache=off means disk cache? if so, it might be useful to test

Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

2008-01-07 Thread Laurent Vivier
Le lundi 07 janvier 2008 à 11:03 -0500, Javier Guerra a écrit : On 1/7/08, Laurent Vivier [EMAIL PROTECTED] wrote: cache=off means files is opened with O_DIRECT and thus there is no cache in the kernel memory on the host side. IMO, cache=off and snapshot=on are incompatible because

Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

2008-01-07 Thread Laurent Vivier
-0500, Javier Guerra a écrit : On 1/7/08, Laurent Vivier [EMAIL PROTECTED] wrote: Le lundi 07 janvier 2008 à 11:03 -0500, Javier Guerra a écrit : hopefully, it would now work with -cache=off, don't you think? Well, I don't think the problem is at the host level but at the guest level

Re: [kvm-devel] [PATCH v2] kvm: Fix accounting of interrupts during guest execution on s390

2007-11-15 Thread Laurent Vivier
: Avi Kivity [EMAIL PROTECTED] CC: Laurent Vivier [EMAIL PROTECTED] Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] --- kernel/sched.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) Index: kvm/kernel/sched.c

Re: [kvm-devel] [ANNOUNCE] kvm-52 release

2007-11-13 Thread Laurent Vivier
Hi Levente, Le mardi 13 novembre 2007 à 10:07 +0100, Farkas Levente a écrit : Avi Kivity wrote: Farkas Levente wrote: Avi Kivity wrote: Farkas Levente wrote: first of all fully update your centos (a bit newer kernel), then i use these packages:

Re: [kvm-devel] 2.6.23 git current compile error on UP

2007-11-08 Thread Laurent Vivier
Le jeudi 08 novembre 2007 à 11:55 -0800, Dave Hansen a écrit : drivers/kvm/kvm_main.c: In function `kvm_flush_remote_tlbs': drivers/kvm/kvm_main.c:220: error: implicit declaration of function `smp_call_function_mask' make[2]: *** [drivers/kvm/kvm_main.o] Error 1 make[1]: *** [drivers/kvm]

[kvm-devel] [PATCH 3/4] Let gcc to choose which registers to save (svm-i386)

2007-10-25 Thread Laurent Vivier
: ebx, ecx, edx, esi, edi - rbp is saved (pop/push) because GCC seems to ignore its use in the clobber description. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/svm.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/kvm/svm.c b/drivers

[kvm-devel] [PATCH 1/4] Let gcc to choose which registers to save (vmx-x86_64)

2007-10-25 Thread Laurent Vivier
removed because %3 is rcx and rcx is restored just after. - line ASM_VMX_VMWRITE_RSP_RDX() is moved out of the ifdef/else/endif Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/vmx.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git

[kvm-devel] [PATCH 0/4] Let gcc to choose which registers to save

2007-10-25 Thread Laurent Vivier
to/from a VCPU in the case of intel i386. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events

[kvm-devel] [PATCH 4/4] Let gcc to choose which registers to save (vmx-i386)

2007-10-25 Thread Laurent Vivier
description. - line mov (%%esp), %3 \n\t has been removed because %3 is ecx and ecx is restored just after. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/vmx.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm

[kvm-devel] [PATCH] kvm-userspace: Add a target to create the tarball

2007-10-25 Thread Laurent Vivier
kvm-latest.tar.gz Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- Makefile | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 1e59217..3aba0f6 100644 --- a/Makefile +++ b/Makefile @@ -65,6 +65,23 @@ srpm: rpmbuild

Re: [kvm-devel] soft lockup in kvm_flush_remote_tlbs

2007-10-24 Thread Laurent Vivier
(); } This part has been removed by commit 49d3bd7e2b990e717aa66e229410b8f5096c4956, perhaps you could try it ? commit 49d3bd7e2b990e717aa66e229410b8f5096c4956 Author: Laurent Vivier [EMAIL PROTECTED] Date: Mon Oct 22 16:33:07 2007 +0200 KVM: Use new smp_call_function_mask

[kvm-devel] [PATCH] kvm uses smp_call_function_mask() in kvm_flush_remote_tlbs()

2007-10-22 Thread Laurent Vivier
This patches can be applied only on kvm-updates-2.6.24 and kvm-updates-2.6.25 as it needs smp_call_function_mask(). In kvm_flush_remote_tlbs(), it replaces a loop using smp_call_function_single() by a single call to smp_call_function_mask(). Signed-off-by: Laurent Vivier [EMAIL PROTECTED

[kvm-devel] [PATCH/RFC] Let gcc to choose which registers to save

2007-10-22 Thread Laurent Vivier
it to save only needed registers. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/vmx.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index 2c6b64a..d6c91ac 100644 --- a/drivers/kvm/vmx.c +++ b/drivers

Re: [kvm-devel] [PATCH] kvm uses smp_call_function_mask() inkvm_flush_remote_tlbs()

2007-10-22 Thread Laurent Vivier
Dor Laor a écrit : Laurent Vivier wrote: This patches can be applied only on kvm-updates-2.6.24 and kvm-updates-2.6.25 as it needs smp_call_function_mask(). In kvm_flush_remote_tlbs(), it replaces a loop using smp_call_function_single() by a single call to smp_call_function_mask

Re: [kvm-devel] [PATCH/RFC] Let gcc to choose which registers to save

2007-10-22 Thread Laurent Vivier
Avi Kivity a écrit : Laurent Vivier wrote: As x86_64 ABI defines some registers saved by the calling function, it is not needed to save all registers in the called function when switching to VCPU. (see http://www.x86-64.org/documentation/abi.pdf, chapter 3.2.1) The best way to do

Re: [kvm-devel] [PATCH/RFC] Let gcc to choose which registers to save

2007-10-22 Thread Laurent Vivier
Avi Kivity a écrit : Laurent Vivier wrote: Other than that the patch is very welcome -- the excessive register saving is very annoying to me. I think we can do the same thing with svm.c, but I can't test it. I can test it for you (but a separate patch please

Re: [kvm-devel] severe bug in 2.6.23+ kvm.git

2007-10-19 Thread Laurent Vivier
Christian Borntraeger a écrit : Am Freitag, 19. Oktober 2007 schrieb Jan Engelhardt: On Oct 19 2007 15:44, Carsten Otte wrote: Carsten Otte wrote: First thing we do, is figure whether or not 2.6.23.1 as released breaks our system too. This way, we can either focus on differences between Linus

Re: [kvm-devel] [ANNOUNCE] kvm-48 release

2007-10-19 Thread Laurent Vivier
Farkas Levente a écrit : Farkas Levente wrote: Avi Kivity wrote: kvm-47 had a host memory corruption bug when setting the guest pte dirty bit, so here's kvm-48 with a fix. Note that guest time accounting, below, will only work with Linux 2.6.24+. smp guests still not working with kvm-48:-(

Re: [kvm-devel] Fix guest time accounting going faster than user time accounting

2007-10-18 Thread Laurent Vivier
Acked-by: Laurent Vivier [EMAIL PROTECTED] Christian Borntraeger a écrit : Seems I overlooked this type while reviewing Laurents patch. cputime_add already adds, dont do it twice. Avi. This should go to Linus before 2.6.24. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED

[kvm-devel] [PATCH] Add some \n in ioapic_debug()

2007-10-12 Thread Laurent Vivier
Add new-line at end of debug strings. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/ioapic.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/kvm/ioapic.c b/drivers/kvm/ioapic.c index 3b69541..1a5e59a 100644

Re: [kvm-devel] Hacking QEMU/KVM to use unused graphics adapters

2007-10-11 Thread Laurent Vivier
Anthony de Almeida Lopes wrote: I was curious if anyone thinks that it may be possible to get a KVM-patched QEMU to use a real video card? For example, let's say I had a second video card. Is QEMU/kvm a codebase which would support hacking in the ability to utilize this second video card

Re: [kvm-devel] Hacking QEMU/KVM to use unused graphics adapters

2007-10-11 Thread Laurent Vivier
Dor Laor wrote: Laurent Vivier wrote: Anthony de Almeida Lopes wrote: I was curious if anyone thinks that it may be possible to get a KVM-patched QEMU to use a real video card? For example, let's say I had a second video card. Is QEMU/kvm a codebase which would support hacking

Re: [kvm-devel] build error

2007-10-11 Thread Laurent Vivier
if you put set -x at line 409 of configure, perhaps we can have more information. Laurent Zhao, Yunfeng wrote: The same as under qemu/ [EMAIL PROTECTED] kvm-userspace]# ./configure ./configure: line 415: /tmp/qemu-conf-24955-17104-27972.c: No such file or directory ERROR: /usr/bin/gcc34

Re: [kvm-devel] kvm-45 problems

2007-10-10 Thread Laurent Vivier
Avi Kivity wrote: Zhao, Yunfeng wrote: This fix cannot resolve this issue. Against latest kvm commits, SMP linux with 4 vcpus still cannot boot up. But the issue will not happen , if adding -smp4 -no-acpi. Can you try the attached patch?

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-08 Thread Laurent Vivier
Avi Kivity wrote: Aurelien Jarno wrote: It's actually described page 200 of the specifications (page 216 in ACPIspec30.pdf): Note: This descriptor is meant for describing interrupts that are connected to PIC-compatible interrupt controllers, which can only be programmed for

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-08 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: Avi Kivity wrote: Aurelien Jarno wrote: It's actually described page 200 of the specifications (page 216 in ACPIspec30.pdf): Note: This descriptor is meant for describing interrupts that are connected to PIC-compatible interrupt

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-06 Thread Laurent Vivier
Avi Kivity wrote: Aurelien Jarno wrote: On Fri, Oct 05, 2007 at 03:25:05PM +0200, Laurent Vivier wrote: Digging in the FreeBSD sources I found the origin of the problem: I added some ACPI traces: rsirq-0234 [13] RsIrqResource : Invalid interrupt polarity/trigger

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-05 Thread Laurent Vivier
Aurelien Jarno wrote: Hi all, That's not something new, but I never seen the problem mentioned here. FreeBSD does not work on KVM, approximately since the lapic merge. However, that does not seem related to lapic, as using -no-kvm-irqchip does not help. With -no-kvm I get a page fault in

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-05 Thread Laurent Vivier
Aurelien Jarno wrote: On Fri, Oct 05, 2007 at 03:25:05PM +0200, Laurent Vivier wrote: [snip] It looks like the solution is either to describe the IRQ with an Extended Interrupt Descriptor or to change this value to one of the two allowed values. In the later case we have to make sure

Re: [kvm-devel] [PATCH] Correct management of REP prefix

2007-10-03 Thread Laurent Vivier
Kamble, Nitin A wrote: Hi Laurent, This patch looks much cleaner to me. I see you are saving the regs like this in the patch. memcpy(c-regs, ctxt-vcpu-regs, sizeof c-regs); But I don't see any place in the patch these regs getting restored after failure. Is it taken care of the code

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-03 Thread Laurent Vivier
Avi Kivity wrote: Aurelien Jarno wrote: Avi Kivity a écrit : Aurelien Jarno wrote: Hi all, That's not something new, but I never seen the problem mentioned here. FreeBSD does not work on KVM, approximately since the lapic merge. However, that does not seem related to lapic, as

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-02 Thread Laurent Vivier
Hi Aurélien, did you try kvm-45 ? Laurent Aurelien Jarno wrote: Hi all, That's not something new, but I never seen the problem mentioned here. FreeBSD does not work on KVM, approximately since the lapic merge. However, that does not seem related to lapic, as using -no-kvm-irqchip does

Re: [kvm-devel] FreeBSD image hangs during boot

2007-10-02 Thread Laurent Vivier
Avi Kivity wrote: Aurelien Jarno wrote: Hi all, That's not something new, but I never seen the problem mentioned here. FreeBSD does not work on KVM, approximately since the lapic merge. However, that does not seem related to lapic, as using -no-kvm-irqchip does not help. With -no-kvm I get

Re: [kvm-devel] Unable to handle kernel paging request

2007-10-01 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: (Yes, I know, it's again another bug I've introduced into KVM...) To avoid this, I suggest that Nitin and yourself review each other's patches. While I review every patch I commit, it works much better when someone who's involved daily

Re: [kvm-devel] [PATCH] Correct management of REP prefix

2007-10-01 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: This patch corrects some errors appearing when we have an emulation failure on an operation using REP prefix. When x86_emulate_insn() fails, saving EIP and ECX is not enough as emulation should have modified other registers like RSI or RDI. Moreover

Re: [kvm-devel] FYI: fixing Vista networking with rtl8139 + KVM

2007-09-27 Thread Laurent Vivier
Avi Kivity wrote: Farkas Levente wrote: Daniel P. Berrange wrote: A Fedora user reported that Vista networking isn't working with KVM[1] and pointed to the Wiki http://kvm.qumranet.com/kvmwiki/Vista_Networking_Workaround FYI, a patch from Xen was merged into upstream QEMU to fix this

Re: [kvm-devel] Unable to handle kernel paging request

2007-09-27 Thread Laurent Vivier
() with c-dst - write_emulated failed() AND WE DON'T RESTORE ECX AND EIP - it's bad... - exit to QEMU - re-enter in x86_emulate_insn() with already modified ECX and EIP. Any comment ? (Yes, I know, it's again another bug I've introduced into KVM...) Laurent Laurent Vivier wrote: Hi, booting a FC6

[kvm-devel] Unable to handle kernel paging request

2007-09-27 Thread Laurent Vivier
Hi, booting a FC6 on my intel box (xeon) with a kernel 2.6.22.5 and KVM git, I had the following error (not reproducible): # kvm-userspace/qemu/x86_64-softmmu/qemu-system-x86_64 -hda fc6.qcow2 -net nic -net tap -serial stdio -smp 4 ... INIT: version 2.86 booting Welcome to Fedora

[kvm-devel] [PATCH] Correct management of REP prefix

2007-09-27 Thread Laurent Vivier
of x86_decode_insn(); and at beginning of x86_emulate_insn(), we restore all registers as they are in vcpu. We can do that, because the x86_decode_insn() doesn't modify registers (except EIP). Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 71

Re: [kvm-devel] [RFC] KVM Source layout Proposal to accommodate new CPU architecture

2007-09-26 Thread Laurent Vivier
Hi, is this the same layout introduced for the powerpc port ? Perhaps you should work together ? Laurent Zhang, Xiantao wrote: Hi Folks, We are working on enabling KVM support on IA64 platform, and now Linux, Windows guests get stable run and achieve reasonable performance on KVM with

Re: [kvm-devel] [ kvm-Bugs-1802223 ] nics have same hw address (rtl8139)

2007-09-26 Thread Laurent Vivier
Hi, I think there is a bug in qemu RTL8139. RTL8139 uses: cpu_register_physical_memory(addr + 0, 0x100, s-rtl8139_mmio_io_addr); But in the comment of cpu_register_physical_memory() we have: 'size' must be a multiple of the target page size. And I think 0x100 is not a multiple of target page

Re: [kvm-devel] [ kvm-Bugs-1802223 ] nics have same hw address (rtl8139)

2007-09-26 Thread Laurent Vivier
Daniel P. Berrange wrote: On Wed, Sep 26, 2007 at 05:47:20PM +0200, Laurent Vivier wrote: Hi, I think there is a bug in qemu RTL8139. RTL8139 uses: cpu_register_physical_memory(addr + 0, 0x100, s-rtl8139_mmio_io_addr); But in the comment of cpu_register_physical_memory() we have: 'size

Re: [kvm-devel] use of saved_eip

2007-09-26 Thread Laurent Vivier
Kamble, Nitin A wrote: Hi Vivier, Avi, Hi Nitin, (BTW, my first name is Laurent) In order to debug faulures in my tree, I was looking at the saved_eip changes coming from your commit. I did not understand the use of saved_eip properly. like why is it used in the emulation of the pop

[kvm-devel] [PATCH] Any legacy prefix after a REX prefix nullifies its effect

2007-09-25 Thread Laurent Vivier
This patch modifies the management of REX prefix according behavior I saw in Xen 3.1. In Xen, this modification has been introduced by Jan Beulich. http://lists.xensource.com/archives/html/xen-changelog/2007-01/msg00081.html Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm

[kvm-devel] [PATCH] remove unused variable

2007-09-25 Thread Laurent Vivier
Remove unused variable introduced by commit 5ed6627ee96f0a6802d99e71879d98610ba17e01 (I missed it, sorry) Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers

[kvm-devel] [PATCH 3/3] Remove no_wb, use dst.type = OP_NONE instead, idea stollen from xen-3.1

2007-09-24 Thread Laurent Vivier
Remove no_wb, use dst.type = OP_NONE instead, idea stollen from xen-3.1 Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 76 ++-- drivers/kvm/x86_emulate.h |2 +- 2 files changed, 25 insertions(+), 53 deletions(-) diff

[kvm-devel] [PATCH 1/3] move grp decoding into functions to make x86_emulate_insn() clearer

2007-09-24 Thread Laurent Vivier
To improve readability, move push, writeback, and grp 1a/2/3/4/5/9 emulation parts into functions. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 451 ++-- 1 files changed, 266 insertions(+), 185 deletions(-) diff --git

[kvm-devel] [PATCH 0/3] Make some cleanup in x86_emulate.c

2007-09-24 Thread Laurent Vivier
This patch series makes some cleanups in x86_emulate.c [PATCH 1/3] move some parts of x86_decode_insn() into functions. [PATCH 2/3] remove _eflags and use directly ctxt-eflags [PATCH 3/3] remove no_wb It has been rebased to current master. Signed-off-by: Laurent Vivier [EMAIL PROTECTED

[kvm-devel] [PATCH 2/3] remove _eflags and use directly ctxt-eflags.

2007-09-24 Thread Laurent Vivier
Remove _eflags and use directly ctxt-eflags. Caching eflags is not needed as it is restored to vcpu by kvm_main.c:emulate_instruction() from ctxt-eflags only if emulation doesn't fail. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 121

Re: [kvm-devel] Test result for KVM, kernel 06f0698c.. , userspace 114b08b..

2007-09-24 Thread Laurent Vivier
Avi Kivity wrote: Zhao, Yunfeng wrote: Avi, I still cannot boot up the smp windows against the latest commits. What are the symptoms, exactly? It works reliably here. It works for me too (winXP + smp 4), but I had to update kvm-userspace to last commits as well. Yunfeng, did you update

Re: [kvm-devel] Test result for KVM, kernel 62d1ea7.. , userspace 667f2deff8..

2007-09-24 Thread Laurent Vivier
Avi Kivity wrote: Farkas Levente wrote: hi, it seems we've got a real tester:-) for ma all of the bellow are serious bugs (tomorrow i'll try to send more detail of our host crash too) and imho the latest 'stable' version was kvm-36. wouldn't be better to postpone all patches and

Re: [kvm-devel] Test result for KVM, kernel 62d1ea7.. , userspace 667f2deff8..

2007-09-24 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: Avi Kivity wrote: Farkas Levente wrote: hi, it seems we've got a real tester:-) for ma all of the bellow are serious bugs (tomorrow i'll try to send more detail of our host crash too) and imho the latest 'stable' version was kvm-36. wouldn't

[kvm-devel] [PATCH] Purify x86_decode_insn() error case management

2007-09-24 Thread Laurent Vivier
Purify x86_decode_insn() error case management, the only valid case is on protected page access, other cases are errors Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/kvm_main.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/kvm

Re: [kvm-devel] Extending VGA ram?

2007-09-24 Thread Laurent Vivier
Avi Kivity wrote: Heinz Ulrich Stille wrote: Hi! I'd like to use screen resolutions of 1920x1200 to 2560x1600 at 32bpp. So far I managed to raise the pixel limit, but not the memory size, and 8MB is a bit low for what I want. [EMAIL PROTECTED] works fine, but 32bpp results in a segfault.

[kvm-devel] [PATCH 1/3] move grp decoding to function to make x86_emulate_insn() clearer

2007-09-21 Thread Laurent Vivier
To improve readability, move push, writeback, and grp 1a/2/3/4/5/9 emulation parts to functions. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 447 ++--- 1 files changed, 262 insertions(+), 185 deletions(-) diff --git

[kvm-devel] [PATCH 3/3] remove no_wb

2007-09-21 Thread Laurent Vivier
Remove no_wb, use dst.type = OP_NONE instead, idea stollen from xen-3.1 Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 76 ++-- drivers/kvm/x86_emulate.h |2 +- 2 files changed, 25 insertions(+), 53 deletions

[kvm-devel] [PATCH 0/3] Make some cleanup in x86_emulate.c

2007-09-21 Thread Laurent Vivier
This patch series makes some cleanups in x86_emulate.c [PATCH 1/3] move some parts of x86_decode_insn() into functions. [PATCH 2/3] remove _eflags and use directly ctxt-eflags [PATCH 3/3] remove no_wb - This SF.net email

[kvm-devel] [PATCH 2/3] remove _eflags and use directly ctxt-eflags.

2007-09-21 Thread Laurent Vivier
Remove _eflags and use directly ctxt-eflags. Caching eflags is not needed as it is restored to vcpu by kvm_main.c:emulate_instruction() from ctxt-eflags only if emulation doesn't fail Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 120

[kvm-devel] [PATCH] move grp decoding to functions to make x86_emulate_insn() clearer

2007-09-20 Thread Laurent Vivier
To improve readability, move push, writeback, and grp 1a/2/3/4/5 emulation parts to functions. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c | 447 ++--- 1 files changed, 262 insertions(+), 185 deletions(-) diff --git

Re: [kvm-devel] [PATCH] move grp decoding to functions to make x86_emulate_insn() clearer

2007-09-20 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: To improve readability, move push, writeback, and grp 1a/2/3/4/5 emulation parts to functions. +static inline int emulate_grp45(struct x86_emulate_ctxt *ctxt, + struct x86_emulate_ops *ops

Re: [kvm-devel] [PATCH] move grp decoding to functions to make x86_emulate_insn() clearer

2007-09-20 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: Avi Kivity wrote: Laurent Vivier wrote: To improve readability, move push, writeback, and grp 1a/2/3/4/5 emulation parts to functions. +static inline int emulate_grp45(struct x86_emulate_ctxt *ctxt, + struct x86_emulate_ops *ops

[kvm-devel] [PATCH] Correct inconcistency in x86_emulate_insn() between cr2 and ctxt-cr2.

2007-09-19 Thread Laurent Vivier
This patch corrects an inconcistency of cr2 introduced by the x86 emulator split. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] --- drivers/kvm/x86_emulate.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c

Re: [kvm-devel] OpenBSD geometry disk problem

2007-09-19 Thread Laurent Vivier
Izik Eidus wrote: this bug started at commit 091b206f6c56f2329e11bac2fa40d6f236ab0bc2 and it related to the changes that were made in vmx.c Laurent, can you help us with this? (openbsd find the harddisk to be 68mb while it should be 2048mb) Of course. Could you provide me the disk image

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode execute

2007-09-18 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: Avi Kivity wrote: Laurent Vivier (Bull) wrote: Not being able to emulate is sometimes legitimate. In the case of writing to a write-protected guest page table, we simply un-write-protect it and go back to the guest (which should now execute

[kvm-devel] [PATCH 5/5][RESEND] Call x86_decode_insn() only when needed

2007-09-18 Thread Laurent Vivier
move emulate_ctxt to kvm_vcpu to keep emulate context when we exit from kvm module. Call x86_decode_insn() only when needed. Modify x86_emulate_insn() to not modify the context if it must be re-entered. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Index: kvm/drivers/kvm/kvm.h

[kvm-devel] [PATCH 4/5][RESEND] emulate_instruction() calls now x86_decode_insn() and x86_emulate_insn()

2007-09-18 Thread Laurent Vivier
emulate_instruction() calls now x86_decode_insn() and x86_emulate_insn(). x86_emulate_insn() is x86_emulate_memop() without the decoding part. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Index: kvm/drivers/kvm/kvm_main.c

[kvm-devel] [PATCH 3/5][RESEND] move all decoding process to function x86_decode_insn().

2007-09-18 Thread Laurent Vivier
move all decoding process to function x86_decode_insn(). Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Index: kvm/drivers/kvm/x86_emulate.c === --- kvm.orig/drivers/kvm/x86_emulate.c 2007-09-18 10:41:06.0 +0200 +++ kvm

[kvm-devel] [PATCH 0/5][RESEND] Split the emulator: decode execute

2007-09-18 Thread Laurent Vivier
we exit from kvm module. Call x86_decode_insn() only when needed. Modify x86_emulate_insn() to not modify the context if it must be re-entered. Signed-off-by: Laurent Vivier [EMAIL PROTECTED] -- - [EMAIL PROTECTED] -- Software is hard

[kvm-devel] [PATCH 1/5][RESEND] some cleanup: remove unused functions

2007-09-18 Thread Laurent Vivier
Remove #ifdef functions never used Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Index: kvm/drivers/kvm/x86_emulate.c === --- kvm.orig/drivers/kvm/x86_emulate.c 2007-09-16 11:33:01.0 +0200 +++ kvm/drivers/kvm

[kvm-devel] [PATCH 2/5][RESEND] move all x86_emulate_memop() to a structure

2007-09-18 Thread Laurent Vivier
; u8 modrm_mod; u8 modrm_reg; u8 modrm_rm; u8 use_modrm_ea; unsigned long modrm_ea; unsigned long modrm_val; }; Signed-off-by: Laurent Vivier [EMAIL PROTECTED] Index: kvm/drivers/kvm

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode execute

2007-09-17 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: Avi Kivity wrote: Laurent Vivier wrote: These patches split the emulator in two parts: one to decode the instruction, the other to execute it. The decode part is then called only when needed. Patchset looks good, but fails

Re: [kvm-devel] [PATCH 0/5] Split the emulator: decode execute

2007-09-17 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier (Bull) wrote: Not being able to emulate is sometimes legitimate. In the case of writing to a write-protected guest page table, we simply un-write-protect it and go back to the guest (which should now execute the instruction natively). Perhaps

  1   2   >