Re: [kvm-devel] [PATCH] virtio_ring: make structure defines packed

2008-02-11 Thread Christian Borntraeger
Am Sonntag, 10. Februar 2008 schrieb ron minnich: The problem for me is that gcc packed is not compatible with the plan 9 C compiler. So, for a truly heterogeneous setup, you are going to have to have code to marshall the structures when transferring between domains, and you are better off

[kvm-devel] [PATCH] virtio_ring: make structure defines packed

2008-02-08 Thread Christian Borntraeger
Currently the virtio_ring structure are not declared packed, but they describe an hardware like interface. We should not allow compilers to make alignments and optimizations that can be different between the guest and host compiler. I propose to declare all structures that are in shared memory