Re: [kvm-devel] RFC/patch: a very trivial patch towards portability V3

2007-10-11 Thread Christian Ehrhardt
To give a statement from other architectures I wanted to say that this patch is fine for the power port. From my view it is the small and easy-to-review flavor of the big patch series I once sent to the list. And because Carsten and I sit in the same office these patches are usually

Re: [kvm-devel] RFC/patch: a very trivial patch towards portability V3

2007-10-11 Thread Avi Kivity
Carsten Otte wrote: Thanks to Avi's continued review, we've got even more common code this time: KVM_CHECK_EXTENSION ioctl is now completely handled in kvm_main.c instead of having arch callbacks to check extensions. The architectures are expected to setup a bit mask named KVM_ARCH_EXTENSIONS

Re: [kvm-devel] RFC/patch: a very trivial patch towards portability V3

2007-10-11 Thread Carsten Otte
Avi Kivity wrote: The new capability bitmap moves the patch out of the very trivial realm. I removed those hunks and applied. Thanks. Send more, the approach is clearly right. Leave things which require changes (like the capability bitmap) to the end, there's more than enough stuff for

[kvm-devel] RFC/patch: a very trivial patch towards portability V3

2007-10-10 Thread Carsten Otte
Thanks to Avi's continued review, we've got even more common code this time: KVM_CHECK_EXTENSION ioctl is now completely handled in kvm_main.c instead of having arch callbacks to check extensions. The architectures are expected to setup a bit mask named KVM_ARCH_EXTENSIONS with information about