Re: [kvm-devel] bug in virtio network driver?

2007-08-30 Thread Christian Borntraeger
Am Mittwoch, 29. August 2007 schrieb Rusty Russell: On Tue, 2007-08-21 at 18:02 +0200, Christian Borntraeger wrote: Am Dienstag, 21. August 2007 schrieb Rusty Russell: The only reason that we don't do it in skb_xmit_done() is because kfree_skb() isn't supposed to be called from an

Re: [kvm-devel] bug in virtio network driver?

2007-08-29 Thread Rusty Russell
On Tue, 2007-08-21 at 18:02 +0200, Christian Borntraeger wrote: Am Dienstag, 21. August 2007 schrieb Rusty Russell: The only reason that we don't do it in skb_xmit_done() is because kfree_skb() isn't supposed to be called from an interrupt. But there's dev_kfree_skb_any() which can be

[kvm-devel] bug in virtio network driver?

2007-08-21 Thread Christian Borntraeger
Hello Rusty, I think I have found a problem in the virtio network driver. virtio_net reclaims sent skbs on xmit. That means that there is always one skb outstanding and the netdev packet statistic is always one packet to low. Documentation/networking/drivers.txt says 3) Do not forget that

Re: [kvm-devel] bug in virtio network driver?

2007-08-21 Thread Rusty Russell
On Tue, 2007-08-21 at 10:48 +0200, Christian Borntraeger wrote: Hello Rusty, I think I have found a problem in the virtio network driver. virtio_net reclaims sent skbs on xmit. That means that there is always one skb outstanding and the netdev packet statistic is always one packet to low.

Re: [kvm-devel] bug in virtio network driver?

2007-08-21 Thread Christian Borntraeger
Am Dienstag, 21. August 2007 schrieb Rusty Russell: The only reason that we don't do it in skb_xmit_done() is because kfree_skb() isn't supposed to be called from an interrupt. But there's dev_kfree_skb_any() which can be used. Ok, I now hacked something that works but I really dont like the