Re: [PATCH RFC v3 0/8] EEH Support for VFIO PCI device

2014-05-19 Thread Gavin Shan
On Wed, May 14, 2014 at 02:11:54PM +1000, Gavin Shan wrote: Ping, Alex.G and Alex.W. Could you please take a look on this when you have available bandwidth? Thanks in advance for your time :-) The series of patches intends to support EEH for PCI devices, which are passed through to PowerKVM

Re: [PATCH 2/8] powerpc/eeh: Info to trace passed devices

2014-05-19 Thread Alexander Graf
On 14.05.14 06:11, Gavin Shan wrote: The address of passed PCI devices (domain:bus:slot:func) might be quite different from the perspective of host and guest. We have to trace the address mapping so that we can emulate EEH RTAS requests from guest. The patch introduces additional fields to

Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-19 Thread Alexander Graf
On 14.05.14 06:11, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Signed-off-by: Gavin Shan gws...@linux.vnet.ibm.com ---

Re: [PATCH 6/8] powerpc: Extend syscall ppc_rtas()

2014-05-19 Thread Alexander Graf
On 14.05.14 06:12, Gavin Shan wrote: Originally, syscall ppc_rtas() can be used to invoke RTAS call from user space. Utility errinjct is using it to inject various errors to the system for testing purpose. The patch intends to extend the syscall to support both pSeries and PowerNV platform.

Re: [PATCH 7/8] powerpc/powernv: Implement ppc_call_opal()

2014-05-19 Thread Alexander Graf
On 14.05.14 06:12, Gavin Shan wrote: If we're running PowerNV platform, ppc_firmware() will be directed to ppc_call_opal() where we can call to OPAL API accordingly. In ppc_call_opal(), the input argument are parsed out and call to appropriate OPAL API to handle that. Each request passed to the

Re: [PATCH 8/8] powerpc/powernv: Error injection infrastructure

2014-05-19 Thread Alexander Graf
On 14.05.14 06:12, Gavin Shan wrote: The patch intends to implement the error injection infrastructure for PowerNV platform. The predetermined handlers will be called according to the type of injected error (e.g. OpalErrinjctTypeIoaBusError). For now, we just support PCI error injection. We

Re: [PATCH 6/6] KVM: PPC: Book3S PR: Expose TM registers

2014-05-19 Thread Alexander Graf
On 17.05.14 08:20, Paul Mackerras wrote: On Tue, Apr 29, 2014 at 06:17:42PM +0200, Alexander Graf wrote: POWER8 introduces transactional memory which brings along a number of new registers and MSR bits. Implementing all of those is a pretty big headache, so for now let's at least emulate

Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-19 Thread Alex Williamson
On Wed, 2014-05-14 at 14:11 +1000, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Some comments throughout, but overall this seems to forgo every bit of the

Re: [PATCH 2/8] powerpc/eeh: Info to trace passed devices

2014-05-19 Thread Benjamin Herrenschmidt
On Mon, 2014-05-19 at 14:46 +0200, Alexander Graf wrote: I don't see the point of VFIO knowing about guest addresses. They are not unique across a system and the whole idea that a VFIO device has to be owned by a guest is also pretty dubious. I suppose what you really care about here is

Re: [PATCH 6/8] powerpc: Extend syscall ppc_rtas()

2014-05-19 Thread Benjamin Herrenschmidt
On Mon, 2014-05-19 at 14:55 +0200, Alexander Graf wrote: On 14.05.14 06:12, Gavin Shan wrote: Originally, syscall ppc_rtas() can be used to invoke RTAS call from user space. Utility errinjct is using it to inject various errors to the system for testing purpose. The patch intends to extend

Re: [PATCH 8/8] powerpc/powernv: Error injection infrastructure

2014-05-19 Thread Benjamin Herrenschmidt
On Mon, 2014-05-19 at 15:04 +0200, Alexander Graf wrote: On 14.05.14 06:12, Gavin Shan wrote: The patch intends to implement the error injection infrastructure for PowerNV platform. The predetermined handlers will be called according to the type of injected error (e.g.

Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-19 Thread Benjamin Herrenschmidt
On Mon, 2014-05-19 at 16:33 -0600, Alex Williamson wrote: On Wed, 2014-05-14 at 14:11 +1000, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Some comments

Re: [PATCH 2/8] powerpc/eeh: Info to trace passed devices

2014-05-19 Thread Gavin Shan
On Tue, May 20, 2014 at 08:37:29AM +1000, Benjamin Herrenschmidt wrote: On Mon, 2014-05-19 at 14:46 +0200, Alexander Graf wrote: I don't see the point of VFIO knowing about guest addresses. They are not unique across a system and the whole idea that a VFIO device has to be owned by a guest is

Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-19 Thread Gavin Shan
On Mon, May 19, 2014 at 02:51:27PM +0200, Alexander Graf wrote: On 14.05.14 06:11, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Signed-off-by: Gavin Shan

Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-19 Thread Gavin Shan
On Mon, May 19, 2014 at 04:33:10PM -0600, Alex Williamson wrote: On Wed, 2014-05-14 at 14:11 +1000, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Thanks for

Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-19 Thread Alex Williamson
On Tue, 2014-05-20 at 10:22 +1000, Gavin Shan wrote: On Mon, May 19, 2014 at 04:33:10PM -0600, Alex Williamson wrote: On Wed, 2014-05-14 at 14:11 +1000, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container to support EEH functionality for PCI devices, which have