Re: [PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings

2012-03-18 Thread Avi Kivity
On 03/16/2012 09:55 AM, Benjamin Herrenschmidt wrote: This is necessary for qemu to be able to pass the right information to the guest, as the supported sizes and encodings can vary depending on the machine, the type of KVM used (PR vs HV) and the version of KVM Signed-off-by: Benjamin

Re: [PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings

2012-03-18 Thread Benjamin Herrenschmidt
On Mon, 2012-03-19 at 07:47 +1100, Benjamin Herrenschmidt wrote: On Sun, 2012-03-18 at 12:23 +0200, Avi Kivity wrote: -ENODOCS What kind of docs do you expect ? Where ? I don't see any of the other private ioctls we use on ppc documented either... Note also that after more thoughts I

Re: [PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings

2012-03-18 Thread Alexander Graf
On 18.03.2012, at 21:47, Benjamin Herrenschmidt wrote: On Sun, 2012-03-18 at 12:23 +0200, Avi Kivity wrote: -ENODOCS What kind of docs do you expect ? Where ? I don't see any of the other private ioctls we use on ppc documented either... They should be - all documentation is in

Re: [PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings

2012-03-18 Thread Benjamin Herrenschmidt
On Sun, 2012-03-18 at 22:16 +0100, Alexander Graf wrote: What kind of docs do you expect ? Where ? I don't see any of the other private ioctls we use on ppc documented either... They should be - all documentation is in Documentation/virt/kvm/api.txt. Ok, I missed that. I'll make sure

[PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings

2012-03-16 Thread Benjamin Herrenschmidt
This is necessary for qemu to be able to pass the right information to the guest, as the supported sizes and encodings can vary depending on the machine, the type of KVM used (PR vs HV) and the version of KVM Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org --- Please comment ASAP.