Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-07 Thread Jan Kiszka
Am 06.01.2011 20:24, Anthony Liguori wrote: > On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: >> From: Jan Kiszka >> >> QEMU supports only one VM, so there is only one kvm_state per process, >> and we gain nothing passing a reference to it around. Eliminate any need >> to refer to it outside of kvm-

[RFT] IRQ sharing for assigned devices - method selection

2011-01-07 Thread Jan Kiszka
Hi, to finally select the approach for adding overdue IRQ sharing support for PCI pass-through, I hacked up two versions based on Thomas' patches and his suggestion to use a timeout-based mode transition: git://git.kiszka.org/linux-kvm.git queues/dev-assign.notify git://git.kiszka.org/lin

Re: [PATCH 0/2] Fix vmx real-mode state leakage

2011-01-07 Thread Marcelo Tosatti
On Mon, Jan 03, 2011 at 02:28:50PM +0200, Avi Kivity wrote: > When emulating real mode, we fake some segment state to conform with vm86 > mode. Unfortunately, we allow the guest to see this fake state if we live > migrate when this state is in effect. This patchset corrects the problem. > > Avi

Re: [PATCH] pci-assign: Fix transition MSI->INTx

2011-01-07 Thread Marcelo Tosatti
On Tue, Jan 04, 2011 at 10:04:30PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Make sure to re-register the IRQ of an assigned device as INTx when the > guest disables MSI[X] mode again. > > Signed-off-by: Jan Kiszka > --- > hw/device-assignment.c |6 ++ > 1 files changed, 6 insert

Re: [PATCH 0/4] Vendor specific instructions and the emulator

2011-01-07 Thread Marcelo Tosatti
On Tue, Jan 04, 2011 at 03:14:40PM +0200, Avi Kivity wrote: > Currently we have some ad-hoc code in x86.c to restrict #UD emulation to > expected instructions (that is, vendor specific instructions). This patchset > replaces the ad-hoc code with proper emulator support using decode tables. > > Av

Re: [KVM TSC trapping / migration 2/2] Add TSC KHZ MSR

2011-01-07 Thread Marcelo Tosatti
On Thu, Jan 06, 2011 at 12:10:45AM -1000, Zachary Amsden wrote: > Use an MSR to allow "soft" migration to hosts which do not support > TSC trapping. Rather than make this a required element of any > migration protocol, we allow the TSC rate to be exported as a data > field (useful in its own right

Re: [KVM TSC trapping / migration 1/2] Add TSC trapping for SVM and VMX

2011-01-07 Thread Marcelo Tosatti
On Thu, Jan 06, 2011 at 12:10:44AM -1000, Zachary Amsden wrote: > Reasons to trap the TSC are numerous, but we want to avoid it as much > as possible for performance reasons. > > We provide two conservative modes via modules parameters and userspace > hinting. First, the module can be loaded with

[ kvm-Bugs-2067179 ] Possible Bug in ATA Emulation Code

2011-01-07 Thread SourceForge.net
Bugs item #2067179, was opened at 2008-08-22 12:25 Message generated for change (Settings changed) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2067179&group_id=180599 Please note that this message will contain a full copy of the co

Re: [PATCH v2 2/3] KVM: send IPI to vcpu only when it's in guest mode

2011-01-07 Thread Marcelo Tosatti
On Fri, Jan 07, 2011 at 03:47:51PM +0800, Xiao Guangrong wrote: > We can interrupt the vcpu only when it's running in guest mode > to reduce IPI > > It looks like only ia64 and x86 need to send IPI to other vcpus, so > i only add the implementation of 'vcpu->guest_mode' in ia64, but i > don't know

[ kvm-Bugs-1868937 ] eepro100.c:1570: nic_receive: Assertion `0' failed.

2011-01-07 Thread SourceForge.net
Bugs item #1868937, was opened at 2008-01-11 00:08 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1868937&group_id=180599 Please note that this message will contain a full copy of the comme

[ kvm-Bugs-2314737 ] 100% host CPU usage with Win2k guest

2011-01-07 Thread SourceForge.net
Bugs item #2314737, was opened at 2008-11-19 13:53 Message generated for change (Comment added) made by jessorensen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2314737&group_id=180599 Please note that this message will contain a full copy of the comme

[PATCH] KVM test: Fix typos in ethtool

2011-01-07 Thread Lucas Meneghel Rodrigues
Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/kvm/tests/ethtool.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/tests/ethtool.py b/client/tests/kvm/tests/ethtool.py index 011df29..9708497 100644 --- a/client/tests/kvm/tests/ethtool.py

qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Jan Kiszka
Hi, does anyone immediately know if this hunk from vl.c @@ -1278,6 +1197,10 @@ void qemu_system_reset_request(void) } else { reset_requested = 1; } +if (cpu_single_env) { +cpu_single_env->stopped = 1; +cpu_exit(cpu_single_env); +} qemu_notify_event(

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Gleb Natapov
On Fri, Jan 07, 2011 at 04:57:31PM +0100, Jan Kiszka wrote: > Hi, > > does anyone immediately know if this hunk from vl.c > > @@ -1278,6 +1197,10 @@ void qemu_system_reset_request(void) > } else { > reset_requested = 1; > } > +if (cpu_single_env) { > +cpu_single_env

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 17:53, Gleb Natapov wrote: > On Fri, Jan 07, 2011 at 04:57:31PM +0100, Jan Kiszka wrote: >> Hi, >> >> does anyone immediately know if this hunk from vl.c >> >> @@ -1278,6 +1197,10 @@ void qemu_system_reset_request(void) >> } else { >> reset_requested = 1; >> } >> +

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Gleb Natapov
On Fri, Jan 07, 2011 at 05:59:34PM +0100, Jan Kiszka wrote: > Am 07.01.2011 17:53, Gleb Natapov wrote: > > On Fri, Jan 07, 2011 at 04:57:31PM +0100, Jan Kiszka wrote: > >> Hi, > >> > >> does anyone immediately know if this hunk from vl.c > >> > >> @@ -1278,6 +1197,10 @@ void qemu_system_reset_reque

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 18:16, Gleb Natapov wrote: > On Fri, Jan 07, 2011 at 05:59:34PM +0100, Jan Kiszka wrote: >> Am 07.01.2011 17:53, Gleb Natapov wrote: >>> On Fri, Jan 07, 2011 at 04:57:31PM +0100, Jan Kiszka wrote: Hi, does anyone immediately know if this hunk from vl.c @@ -127

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Gleb Natapov
On Fri, Jan 07, 2011 at 06:30:57PM +0100, Jan Kiszka wrote: > Am 07.01.2011 18:16, Gleb Natapov wrote: > > On Fri, Jan 07, 2011 at 05:59:34PM +0100, Jan Kiszka wrote: > >> Am 07.01.2011 17:53, Gleb Natapov wrote: > >>> On Fri, Jan 07, 2011 at 04:57:31PM +0100, Jan Kiszka wrote: > Hi, > >

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 18:53, Gleb Natapov wrote: > On Fri, Jan 07, 2011 at 06:30:57PM +0100, Jan Kiszka wrote: >> Am 07.01.2011 18:16, Gleb Natapov wrote: >>> On Fri, Jan 07, 2011 at 05:59:34PM +0100, Jan Kiszka wrote: Am 07.01.2011 17:53, Gleb Natapov wrote: > On Fri, Jan 07, 2011 at 04:57:31PM +

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 19:24, Jan Kiszka wrote: > Am 07.01.2011 18:53, Gleb Natapov wrote: >> On Fri, Jan 07, 2011 at 06:30:57PM +0100, Jan Kiszka wrote: >>> Am 07.01.2011 18:16, Gleb Natapov wrote: On Fri, Jan 07, 2011 at 05:59:34PM +0100, Jan Kiszka wrote: > Am 07.01.2011 17:53, Gleb Natapov wrot

[KVM-AUTOTEST PATCH v3 01/11] Fix Unhandled* exceptions

2011-01-07 Thread Michael Goldish
In recent Python versions, when exceptions are unpickled their __init__() method is called again. The parameters passed to __init__() upon unpickling are *self.args. Because the first execution of __init__() sets self.args to something different from the parameters passed to __init__() (by passin

[KVM-AUTOTEST PATCH v3 02/11] CmdError: remove extra blank line between methods

2011-01-07 Thread Michael Goldish
For consistency with other exception classes, keep just a single blank line between __init__() and __str__(). Signed-off-by: Michael Goldish --- client/common_lib/error.py |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/client/common_lib/error.py b/client/common_lib/erro

[KVM-AUTOTEST PATCH v3 03/11] Introduce exception context strings

2011-01-07 Thread Michael Goldish
In complex tests (KVM) an exception string is often not informative enough and the traceback and source code have to be examined in order to figure out what caused the exception. Context strings are a way for tests to provide information about what they're doing, so that when an exception is raise

[KVM-AUTOTEST PATCH v3 04/11] Embed context information in exception strings

2011-01-07 Thread Michael Goldish
Exceptions look for a ._context attribute and embed it in the string returned by __str__(). If the attribute isn't set (or if it's an empty string) nothing is embedded. Signed-off-by: Michael Goldish --- client/common_lib/error.py | 10 +- 1 files changed, 9 insertions(+), 1 deletions

[KVM-AUTOTEST PATCH v3 05/11] KVM test: Thread.join(): insert the current context into the thread's exception

2011-01-07 Thread Michael Goldish
Because contexts are thread specific, exceptions raised in another thread will not contain the context in which the thread was started/joined. This context should be explicitly inserted into any exception raised in the thread and re-raised in join(). Signed-off-by: Michael Goldish --- client/te

[KVM-AUTOTEST PATCH v3 06/11] KVM test: use error.context() in migration_with_file_transfer

2011-01-07 Thread Michael Goldish
This is an example of a case where context information is useful. Signed-off-by: Michael Goldish --- .../kvm/tests/migration_with_file_transfer.py | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/tests/migration_with_file_transfer.py b/cl

[KVM-AUTOTEST PATCH v3 08/11] KVM test: use error.context() in VM.login() and VM.copy_files_*()

2011-01-07 Thread Michael Goldish
Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_vm.py |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 056416e..997a44f 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@

[KVM-AUTOTEST PATCH v3 10/11] KVM test: use error.context() in VM.migrate()

2011-01-07 Thread Michael Goldish
Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_vm.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 6f494eb..259bb18 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@ -13

[KVM-AUTOTEST PATCH v3 11/11] KVM test: use error.context() in guest_s4

2011-01-07 Thread Michael Goldish
Signed-off-by: Michael Goldish --- client/tests/kvm/tests/guest_s4.py | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/tests/guest_s4.py b/client/tests/kvm/tests/guest_s4.py index 7f61c33..5641654 100644 --- a/client/tests/kvm/tests/guest_s4.

[KVM-AUTOTEST PATCH v3 07/11] KVM test: use error.context() in kvm_preprocessing.py

2011-01-07 Thread Michael Goldish
Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_preprocessing.py |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py index 5ce0a3b..5a452fa 100644 --- a/client/tests/kvm/kvm_preprocess

[KVM-AUTOTEST PATCH v3 09/11] KVM test: use error.context() in VM.create()

2011-01-07 Thread Michael Goldish
Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_vm.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 997a44f..6f494eb 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@ -656,6

Re: [RFT] IRQ sharing for assigned devices - method selection

2011-01-07 Thread Alex Williamson
On Fri, 2011-01-07 at 10:33 +0100, Jan Kiszka wrote: > Hi, > > to finally select the approach for adding overdue IRQ sharing support > for PCI pass-through, I hacked up two versions based on Thomas' patches > and his suggestion to use a timeout-based mode transition: > > git://git.kiszka.org/

Re: [RFT] IRQ sharing for assigned devices - method selection

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 19:57, Alex Williamson wrote: > On Fri, 2011-01-07 at 10:33 +0100, Jan Kiszka wrote: >> Hi, >> >> to finally select the approach for adding overdue IRQ sharing support >> for PCI pass-through, I hacked up two versions based on Thomas' patches >> and his suggestion to use a timeout-bas

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Gleb Natapov
On Fri, Jan 07, 2011 at 07:24:00PM +0100, Jan Kiszka wrote: > Am 07.01.2011 18:53, Gleb Natapov wrote: > > On Fri, Jan 07, 2011 at 06:30:57PM +0100, Jan Kiszka wrote: > >> Am 07.01.2011 18:16, Gleb Natapov wrote: > >>> On Fri, Jan 07, 2011 at 05:59:34PM +0100, Jan Kiszka wrote: > Am 07.01.2011

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 20:10, Gleb Natapov wrote: We are on a good track now. I predict that we will be left with only one or two major additional features in qemu-kvm in a few months from now, no more duplications with subtle differences, and production-grade kvm upstream stability. >>>

Re: [KVM TSC trapping / migration 2/2] Add TSC KHZ MSR

2011-01-07 Thread Zachary Amsden
On 01/07/2011 12:48 AM, Marcelo Tosatti wrote: On Thu, Jan 06, 2011 at 12:10:45AM -1000, Zachary Amsden wrote: Use an MSR to allow "soft" migration to hosts which do not support TSC trapping. Rather than make this a required element of any migration protocol, we allow the TSC rate to be exp

kernel BUG at arch/x86/kvm/mmu.c:655!

2011-01-07 Thread Tomasz Chmielewski
The following happened when I tried to reboot a virtual machine (host running qemu 0.13.0, kernel 2.6.36.2). After a while, the server hanged and was no longer reachable. kvm: 3927: cpu0 unhandled wrmsr: 0x198 data 0 kvm: 3927: cpu1 unhandled wrmsr: 0x198 data 0 rmap_remove: 88060e9437f8 0 1

Re: qemu-kvm vs. qemu: Terminate cpu loop on reset?

2011-01-07 Thread Gleb Natapov
On Fri, Jan 07, 2011 at 08:33:20PM +0100, Jan Kiszka wrote: > Am 07.01.2011 20:10, Gleb Natapov wrote: > We are on a good track now. I predict that we will be left with only one > or two major additional features in qemu-kvm in a few months from now, > no more duplications with subtl

Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-07 Thread Anthony Liguori
On 01/07/2011 03:03 AM, Jan Kiszka wrote: Am 06.01.2011 20:24, Anthony Liguori wrote: On 01/06/2011 11:56 AM, Marcelo Tosatti wrote: From: Jan Kiszka QEMU supports only one VM, so there is only one kvm_state per process, and we gain nothing passing a reference to it around. Eliminate

[PATCH] Handle guest access to BBL_CR_CTL3 MSR

2011-01-07 Thread john cooper
A correction to Intel cpu model CPUID data (patch queued) caused winxp-64 to BSOD when booted with a Penryn model. This was traced to the CPUID "model" field correction from 6 -> 23 (as is proper for a Penryn class of cpu). Only in this case does the problem surface. The cause for this failure is