[PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-22 Thread Jan Kiszka
A 16-bit TSS is only 44 bytes long. So make sure to test for the correct size on task switch. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- This should be stable material as well. I can provide a patch that applies on .32 and .33, or what will be the procedure? arch/x86/kvm/emulate.c

Re: Time and KVM - best practices

2010-03-22 Thread Jan Kiszka
Dor Laor wrote: On 03/21/2010 01:29 PM, Thomas Løcke wrote: Hey, What is considered best practice when running a KVM host with a mixture of Linux and Windows guests? Currently I have ntpd running on the host, and I start my guests using -rtc base=localhost,clock=host, with an extra -tdf

x86: Exception handling via task gates broken

2010-03-22 Thread Jan Kiszka
Hi, when switching an x86 hardware task because of some exception, KVM does not push potential error codes on the stack of the handler task. I guess not many OSes make use of this slow feature - we found one :). Does anyone happen to have a fix on his agenda? Otherwise I will look into this (next

Re: KVM call agenda for Mar 23

2010-03-23 Thread Jan Kiszka
Chris Wright wrote: Please send in any agenda items you are interested in covering. Yes, usability is a valid topic esp. if you promise to come w/ GUI patches. - state and roadmap for upstream merge of in-kernel device models (looks to me like this central merge effort is stalled ATM)

Re: KVM call agenda for Mar 23

2010-03-23 Thread Jan Kiszka
Avi Kivity wrote: On 03/23/2010 11:31 AM, Jan Kiszka wrote: Chris Wright wrote: Please send in any agenda items you are interested in covering. Yes, usability is a valid topic esp. if you promise to come w/ GUI patches. - state and roadmap for upstream merge of in-kernel device

Re: KVM call agenda for Mar 23

2010-03-23 Thread Jan Kiszka
Avi Kivity wrote: On 03/23/2010 12:50 PM, Jan Kiszka wrote: Avi Kivity wrote: On 03/23/2010 11:31 AM, Jan Kiszka wrote: Chris Wright wrote: Please send in any agenda items you are interested in covering. Yes, usability is a valid topic esp. if you promise to come w/ GUI

Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Jan Kiszka
Avi Kivity wrote: On 03/22/2010 12:29 PM, Jan Kiszka wrote: A 16-bit TSS is only 44 bytes long. So make sure to test for the correct size on task switch. This should be stable material as well. I can provide a patch that applies on .32 and .33, or what will be the procedure

[PATCH v2] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com A 16-bit TSS is only 44 bytes long. So make sure to test for the correct size on task switch. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Changes in v2: - fixed off-by-one in 16-bit limit arch/x86/kvm/emulate.c |6 +- 1 files changed

Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks

2010-03-23 Thread Jan Kiszka
Avi Kivity wrote: On 03/23/2010 12:25 PM, Avi Kivity wrote: This should be stable material as well. I can provide a patch that applies on .32 and .33, or what will be the procedure? I'd like to drop the Cc: stable and maintain stable queues explicitly (in kvm-updates/2.6.3[23]). I'll

Re: [Qemu-devel] Re: KVM call agenda for Mar 23

2010-03-25 Thread Jan Kiszka
Zhang, Xiantao wrote: Jes Sorensen wrote: On 03/23/10 13:45, Anthony Liguori wrote: I don't think we can pull in: - extboot - ia64 - in-kernel pit[1] - associated command line options - device passthrough The question is, if we dropped those things, would people actually use qemu.git

Re: [PATCH 1/2] qemu-kvm: extboot: Keep variables in RAM

2010-04-06 Thread Jan Kiszka
Avi Kivity wrote: On 02/18/2010 06:13 PM, Jan Kiszka wrote: Instead of saving the old INT 0x13 and 0x19 handlers in ROM which fails under QEMU as it enforces protection, keep them in spare vectors of the interrupt table, namely INT 0x80 and 0x81. Applied both, thanks. Forgot to tag

Re: VMX and save/restore guest in virtual-8086 mode

2010-04-08 Thread Jan Kiszka
Avi Kivity wrote: On 04/07/2010 11:24 PM, Marcelo Tosatti wrote: During initialization, WinXP.32 switches to virtual-8086 mode, with paging enabled, to use VGABIOS functions. Since enter_pmode unconditionally clears IOPL and VM bits in RFLAGS flags = vmcs_readl(GUEST_RFLAGS);

Re: VMX and save/restore guest in virtual-8086 mode

2010-04-08 Thread Jan Kiszka
Avi Kivity wrote: On 04/08/2010 10:22 AM, Jan Kiszka wrote: Avi Kivity wrote: On 04/07/2010 11:24 PM, Marcelo Tosatti wrote: During initialization, WinXP.32 switches to virtual-8086 mode, with paging enabled, to use VGABIOS functions. Since enter_pmode unconditionally clears

Re: VMX and save/restore guest in virtual-8086 mode

2010-04-08 Thread Jan Kiszka
Marcelo Tosatti wrote: On Thu, Apr 08, 2010 at 11:05:56AM +0300, Avi Kivity wrote: On 04/08/2010 10:54 AM, Jan Kiszka wrote: Looks like KVM_SET_REGS should write rmode.save_iopl (and a new save_vm)? Just like we manipulate the flags for guest debugging in the set/get_rflags vendor handlers

Re: [PATCH] KVM: move DR register access handling into generic code.

2010-04-12 Thread Jan Kiszka
Avi Kivity wrote: On 04/12/2010 03:27 PM, Gleb Natapov wrote: Currently both SVM and VMX have their own DR handling code. Move it to x86.c. The standard process is to make them identical first and finally merge identical code, but I guess we can skip it in this case (Jan?) Looks OK,

Re: [PATCHv2] KVM: move DR register access handling into generic code

2010-04-13 Thread Jan Kiszka
Gleb Natapov wrote: Currently both SVM and VMX have their own DR handling code. Move it to x86.c. Changelog: v1-v2 - kvm_set_dr() always return 1 in a case of error Signed-off-by: Gleb Natapov g...@redhat.com Acked-by: Jan Kiszka jan.kis...@siemens.com diff --git a/arch/x86/include

Re: kvmtrace and debugging kvm

2010-04-14 Thread Jan Kiszka
Manish Regmi wrote: hi, I am trying to use kvmtrace but it looks like its no longer used. in Right, kernel support was removed a few releases ago. I think it's time to drop that tool from the qemu-kvm package. kvm_main.c it is returning -EOPNOTSUP. kvmtrace -V -D test -o mykvmtest does

KVM: x86: Push potential exception error code on task switches

2010-04-14 Thread Jan Kiszka
When a fault triggers a task switch, the error code, if it exists, has to be pushed on the new task's stack. Implement the missing bits. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/include/asm/kvm_emulate.h |3 ++- arch/x86/include/asm/kvm_host.h|3 ++- arch/x86

Re: KVM: x86: Push potential exception error code on task switches

2010-04-14 Thread Jan Kiszka
Avi Kivity wrote: On 04/14/2010 03:11 PM, Jan Kiszka wrote: When a fault triggers a task switch, the error code, if it exists, has to be pushed on the new task's stack. Implement the missing bits. @@ -2416,12 +2417,23 @@ static int emulator_do_task_switch(struct x86_emulate_ctxt *ctxt

Re: KVM: x86: Push potential exception error code on task switches

2010-04-14 Thread Jan Kiszka
Jan Kiszka wrote: Avi Kivity wrote: On 04/14/2010 03:11 PM, Jan Kiszka wrote: When a fault triggers a task switch, the error code, if it exists, has to be pushed on the new task's stack. Implement the missing bits. @@ -2416,12 +2417,23 @@ static int emulator_do_task_switch(struct

Re: KVM: x86: Push potential exception error code on task switches

2010-04-14 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Apr 14, 2010 at 02:11:39PM +0200, Jan Kiszka wrote: static int emulator_do_task_switch(struct x86_emulate_ctxt *ctxt, -struct x86_emulate_ops *ops, -u16 tss_selector, int reason

Re: KVM: x86: Push potential exception error code on task switches

2010-04-14 Thread Jan Kiszka
Avi Kivity wrote: On 04/14/2010 03:58 PM, Jan Kiszka wrote: The TSS descriptor (gate doesn't have a size). But isn't it possible to have a 32-bit TSS with a 16-bit CS/SS? Might be possible, but will cause troubles as the spec says: The error code is pushed on the stack

[PATCH 1/2] KVM: x86: Terminate early if task_switch_16/32 failed

2010-04-14 Thread Jan Kiszka
Stop the switch immediately if task_switch_16/32 returned an error. Only if that step succeeded, the switch should actually take place and update any register states. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/emulate.c |2 ++ 1 files changed, 2 insertions(+), 0

[PATCH v2 2/2] KVM: x86: Push potential exception error code on task switches

2010-04-14 Thread Jan Kiszka
When a fault triggers a task switch, the error code, if existent, has to be pushed on the new task's stack. Implement the missing bits. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Changes in v2: - push writeback into emulator_task_switch - refactored over Terminate early

[PATCH] kvm test: Fix i386 crossbuild

2010-04-14 Thread Jan Kiszka
This fixes make ARCH=i386 of the KVM micro tests on x86-64 hosts. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm/user/config-x86-common.mak |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/kvm/user/config-x86-common.mak b/kvm/user/config-x86-common.mak index

[PATCH] kvm test: Add 32-bit task switch micro-test

2010-04-14 Thread Jan Kiszka
This implements a basic task switch test for 32-bit targets. It specifically stresses the case that a fault with attached error code triggers the switch via a task gate. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Gleb, you might want to have a look at this test. When using it with my

Re: [PATCH] kvm test: Add 32-bit task switch micro-test

2010-04-14 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Apr 14, 2010 at 04:12:46PM +0200, Jan Kiszka wrote: This implements a basic task switch test for 32-bit targets. It specifically stresses the case that a fault with attached error code triggers the switch via a task gate. How do you compile this? I was sure kvm

[PATCH][STABLE] KVM: x86: Push potential exception error code on task switches

2010-04-14 Thread Jan Kiszka
When a fault triggers a task switch, the error code, if existent, has to be pushed on the new task's stack. Implement the missing bits. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- This is a backport of the proposed fix for master. It applies at least down to 2.6.32 and should

Re: [PATCH] kvm test: Add 32-bit task switch micro-test

2010-04-14 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Apr 14, 2010 at 04:12:46PM +0200, Jan Kiszka wrote: Gleb, you might want to have a look at this test. When using it with my 2.6.34 queue (or below or with QEMU), I get the following, expected output: fault at 8:4002ef, prev task 18, error code 1234 post fault

[ANNOUNCE] kvm-kmod-2.6.34-rc3

2010-04-15 Thread Jan Kiszka
Here is a preview on the next stable kvm-kmod series based on 2.6.34. There are currently no pending patches in the related kernel queue, so you may want to give this a try. It should be close to final 2.6.34. To recall the major contributions (as Avi summarized them): - rdtscp support - much

Re: KVM: x86: Push potential exception error code on task switches

2010-04-15 Thread Jan Kiszka
Avi Kivity wrote: On 04/14/2010 04:19 PM, Jan Kiszka wrote: Avi Kivity wrote: On 04/14/2010 03:58 PM, Jan Kiszka wrote: The TSS descriptor (gate doesn't have a size). But isn't it possible to have a 32-bit TSS with a 16-bit CS/SS? Might be possible, but will cause

Re: [PATCH] KVM-Test: Add KVM unit test (kvmctl)

2010-04-19 Thread Jan Kiszka
Lucas Meneghel Rodrigues wrote: From: sshang ssh...@redhat.com The test use kvm test harness kvmctl load binary test case file to test various functions of the kvm kernel module. I thought that tool is deprecated (or even broken), and I was about to suggest dropping it from the tree in favor

Re: [PATCH] KVM-Test: Add KVM unit test (kvmctl)

2010-04-19 Thread Jan Kiszka
Lucas Meneghel Rodrigues wrote: On Mon, 2010-04-19 at 10:50 +0200, Jan Kiszka wrote: Lucas Meneghel Rodrigues wrote: From: sshang ssh...@redhat.com The test use kvm test harness kvmctl load binary test case file to test various functions of the kvm kernel module. I thought that tool

Re: [PATCH][STABLE] KVM: x86: Fix TSS size check for 16-bit tasks

2010-04-21 Thread Jan Kiszka
Avi Kivity wrote: On 04/14/2010 05:57 PM, Jan Kiszka wrote: A 16-bit TSS is only 44 bytes long. So make sure to test for the correct size on task switch. Signed-off-by: Jan Kiszkajan.kis...@siemens.com --- This is a backport of 8f2d524 from master. It applies at least down to 2.6.32

Re: [PATCH] KVM: VMX: Translate interrupt shadow when waiting on NMI window

2010-04-21 Thread Jan Kiszka
Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:37:15AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:27:07AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:14:45AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:04

Re: [PATCH] KVM: VMX: Translate interrupt shadow when waiting on NMI window

2010-04-21 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Apr 21, 2010 at 04:17:03PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:37:15AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:27:07AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:14

Re: [PATCH] KVM: VMX: Translate interrupt shadow when waiting on NMI window

2010-04-21 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Apr 21, 2010 at 04:41:38PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Apr 21, 2010 at 04:17:03PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:37:15AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Tue, Feb 16, 2010 at 11:27

Re: [uq/master patch 2/5] kvm: add logging count to slots

2010-04-24 Thread Jan Kiszka
Marcelo Tosatti wrote: Otherwise there is no way to differentiate between global and slot specific logging, so for example vga dirty log start migration start migration fail Disables dirty logging for the vga slot. This is not true (unless there is a bug): Migration logging is tracked

Re: [uq/master patch 2/5] kvm: add logging count to slots

2010-04-25 Thread Jan Kiszka
Avi Kivity wrote: On 04/24/2010 10:34 AM, Jan Kiszka wrote: Marcelo Tosatti wrote: Otherwise there is no way to differentiate between global and slot specific logging, so for example vga dirty log start migration start migration fail Disables dirty logging for the vga slot

Re: [uq/master patch 2/5] kvm: add logging count to slots

2010-04-25 Thread Jan Kiszka
Avi Kivity wrote: On 04/25/2010 04:57 PM, Jan Kiszka wrote: It's still a good idea. The current API assumes that there will be only one slot-based client (or that multiple clients will keep the refcount themselves). After the bytemap - multiple bitmaps conversion this can be extended

Re: [uq/master patch 2/5] kvm: add logging count to slots

2010-04-25 Thread Jan Kiszka
Avi Kivity wrote: On 04/25/2010 05:29 PM, Jan Kiszka wrote: There isn't. But I don't like hidden breakage. It's (so far) an unproblematic API property we can document. I don't like changing APIs just for there might be the case that I guess it's one of those agree

Re: [uq/master patch 2/5] kvm: add logging count to slots

2010-04-25 Thread Jan Kiszka
Avi Kivity wrote: On 04/25/2010 05:51 PM, Jan Kiszka wrote: Avi Kivity wrote: On 04/25/2010 05:29 PM, Jan Kiszka wrote: There isn't. But I don't like hidden breakage. It's (so far) an unproblematic API property we can document. I don't like changing APIs just

Re: [uq/master patch 2/5] kvm: add logging count to slots

2010-04-25 Thread Jan Kiszka
Avi Kivity wrote: On 04/25/2010 06:07 PM, Jan Kiszka wrote: The fact that the API assumes a single user is what's broken IMO. If the API were to take a memory slot as parameter you could say it is the responsibility of the slot's owner to multiplex (and since vga has a single owner, no need

2.6.32.12: Build warning due to 78ce64a384 / missing in 2.6.33?

2010-04-26 Thread Jan Kiszka
Gleb, I'm getting a build warning with latest 2.6.32.12 due to Fix segment descriptor loading. load_segment_descriptor_to_kvm_desct is unused after that patch. I assume it's just forgotten code and did not accidentally become unused, right? The fact that 2.6.33.3 does not generate this makes me

[ANNOUNCE] kvm-kmod-2.6.32.12 kvm-kmod-2.6.33.3

2010-04-27 Thread Jan Kiszka
Two updates to the stable kvm-kmod series have just been released. kvm-kmod-2.6.33.3 is the normal one as it reflects the most recent stable kernel. Here is the corresponding changelog: KVM changes since kvm-kmod-2.6.33.1: - Fix TSS size check for 16-bit tasks - Increase NR_IOBUS_DEVS limit to

[PATCH] qemu-kvm: Process exit requests in kvm loop

2010-05-04 Thread Jan Kiszka
This unbreaks the monitor quit command for qemu-kvm. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qemu-kvm.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index 91f0222..43d599d 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -2047,6

Re: EHCI / USB2.0 for USB passthrough, or how to pass USB host device

2010-05-08 Thread Jan Kiszka
Tom Lanyon wrote: Hi list, I've been playing with some KVM guests on KVM 83 on a RedHat 2.6.18 kernel (2.6.18-164.15.1.el5). I tried to pass through a USB TV tuner device with a hostdev option in the guest's configuration. The guest can see the device but the driver (dvb_usb_dib0700)

[PATCH] KVM: VMX: blocked-by-sti must not defer NMI injections

2010-05-11 Thread Jan Kiszka
GUEST_INTR_STATE_STI is active (originally suggested by Gleb). Intel confirmed that this is safe, the processor will never complain about NMI injection in this state. Signed-off-by: Jan Kiszka jan.kis...@siemens.com KVM-Stable-Tag --- arch/x86/kvm/vmx.c |3 +-- 1 files changed, 1 insertions(+), 2

Re: [PATCH 10/12] kvm: enable smp 1

2010-05-14 Thread Jan Kiszka
Alexander Graf wrote: On 14.05.2010, at 17:48, Avi Kivity wrote: On 05/14/2010 05:06 PM, Alexander Graf wrote: On 12.05.2010, at 23:25, Marcelo Tosatti wrote: Process INIT/SIPI requests and enable -smp 1. Does this enable real SMP or does it still only allow one vcpu to run at a

Re: Qemu-KVM Livate Migration 0.12.2 - 0.12.3/4 broken?

2010-05-16 Thread Jan Kiszka
Juan Quintela wrote: Lack of proper subsections. IDE is something like: const VMStateDescription vmstate_ide_drive = { .version_id = 4, } static const VMStateDescription vmstate_bmdma = { .name = ide bmdma, .version_id = 4, ... } const VMStateDescription

[ANNOUNCE] kvm-kmod-2.6.34

2010-05-17 Thread Jan Kiszka
Linux 2.6.34 is out, and here comes the corresponding kvm-kmod package. Download is available at http://downloads.sourceforge.net/project/kvm/kvm-kmod/2.6.34/kvm-kmod-2.6.34.tar.bz2 KVM changes since kvm-kmod-2.6.34-rc3: - VMX: blocked-by-sti must not defer NMI injections - x86: Call vcpu_load

Re: Qemu-KVM Livate Migration 0.12.2 - 0.12.3/4 broken?

2010-05-17 Thread Jan Kiszka
Juan Quintela wrote: Jan Kiszka jan.kis...@web.de wrote: Juan Quintela wrote: Lack of proper subsections. IDE is something like: const VMStateDescription vmstate_ide_drive = { .version_id = 4, } static const VMStateDescription vmstate_bmdma = { .name = ide bmdma

[PATCH] kvm: Switch kvm_update_guest_debug to run_on_cpu

2010-05-19 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Guest debugging under KVM is currently broken once io-threads are enabled. Easily fixable by switching the fake on_vcpu to the real run_on_cpu implementation. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c | 12 +--- 1 files

Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing. When already writing to a file, why not reusing QEMU's logging infrastructure (log foo / -d

Re: [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: On Fri, May 21, 2010 at 12:13 PM, Jan Kiszka jan.kis...@siemens.com wrote: Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: On 05/21/2010 08:46 AM, Jan Kiszka wrote: Anthony Liguori wrote: On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: On Fri, May 21, 2010 at 5:52 PM, Jan Kiszka jan.kis...@siemens.com wrote: I would just like to avoid that too much efforts are spent on re-inventing smart trace buffers, trace daemons, or trace visualization tools. Then better pick up some semi-perfect approach (e.g. [1

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: I'm not opposed to using a framework, but I'd rather have an equivalent to kvm_stat tomorrow than wait 3 years for LTTng to not get merged. So let's have a dirt-simple tracing mechanism and focus on adding useful trace points. Then when we have a framework we can use,

Re: [RFC 0/5] Tracing backends

2010-05-23 Thread Jan Kiszka
Stefan Hajnoczi wrote: The following patches against qemu.git allow static trace events to be declared in QEMU. Trace events use a lightweight syntax and are independent of the backend tracing system (e.g. LTTng UST). Supported backends are: * my trivial tracer (simple) * LTTng

Re: [PATCH 3/5] trace: Add LTTng Userspace Tracer backend

2010-05-23 Thread Jan Kiszka
Stefan Hajnoczi wrote: This patch adds LTTng Userspace Tracer (UST) backend support. The UST system requires no kernel support but libust and liburcu must be installed. $ ./configure --trace-backend ust $ make Start the UST daemon: $ ustd List available tracepoints and enable some:

[PATCH] KVM: x86: Propagate fpu_alloc errors

2010-05-25 Thread Jan Kiszka
Memory allocation may fail. Propagate such errors. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/include/asm/kvm_host.h |2 +- arch/x86/kvm/svm.c |7 ++- arch/x86/kvm/vmx.c |4 +++- arch/x86/kvm/x86.c | 11 +-- 4

[PATCH] KVM: svm: Drop unused local variable

2010-05-25 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/svm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 5f25e59..3c03c36 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -1491,8 +1491,6 @@ static

Re: [PATCH 0/4] some kvm-kmod issues

2010-05-26 Thread Jan Kiszka
Zachary Amsden wrote: On 05/25/2010 05:28 PM, Zachary Amsden wrote: I found some issues with kvm-kmod from recently pulled tree on F13 (2.6.33) kernel. I am not 100% sure the version numbers are right in all of these fixes, but at least it compiles and seems to run VMs again. The FPU change

[PATCH] KVM: svm: Fix erratum 383 check for 32-bit hosts

2010-05-26 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This overflow should have left the check broken behind for 32-bit hosts. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/svm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm

Re: [PATCH 1/4] Fix tboot enabled macro

2010-05-26 Thread Jan Kiszka
Zachary Amsden wrote: (please post inlined - I have to copy your patch manually now) From 614d5fa8bba5f98fd3cb1d66d63b0b70ca98fe51 Mon Sep 17 00:00:00 2001 From: Zachary Amsden zams...@redhat.com Date: Fri, 14 May 2010 12:25:14 -1000 Subject: [PATCH 1/5] Fix tboot_enabled macro; was present

Re: [PATCH 2/4] Fix FPU interface changes

2010-05-26 Thread Jan Kiszka
Zachary Amsden wrote: The FPU interface changed to dynamic allocation; redefine the missing struct fpu to be a static structure and add back the old macros. The FPU interface changed to dynamic allocation; redefine the missing struct fpu to be a static structure and add back the old macros.

Re: [PATCH 3/4] AMD module build failure

2010-05-26 Thread Jan Kiszka
Zachary Amsden wrote: From abbb464f0c2dd9681c4380598a1ac098d024b576 Mon Sep 17 00:00:00 2001 From: Zachary Amsden zams...@redhat.com Date: Tue, 25 May 2010 16:33:47 -1000 Subject: [PATCH 3/5] Fix AMD module build failure because of undefined MSR Signed-off-by: Zachary Amsden

Re: [PATCH 4/4] Hack around IOMMU changes

2010-05-26 Thread Jan Kiszka
Zachary Amsden wrote: On 05/25/2010 05:36 PM, Zachary Amsden wrote: Not for the faint of heart, this patch subverts the code by reassigning a local variable from a macro. This time, with patch. From 97b9230f699aba1c5f47972032b2d4d935a83054 Mon Sep 17 00:00:00 2001 From: Zachary Amsden

Re: [PATCH] KVM: svm: Fix erratum 383 check for 32-bit hosts

2010-05-26 Thread Jan Kiszka
Roedel, Joerg wrote: On Wed, May 26, 2010 at 03:11:17AM -0400, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This overflow should have left the check broken behind for 32-bit hosts. The check itself should work but it gives a compile warning for me (at least in my small

Re: [PATCH 1/4] Fix tboot enabled macro

2010-05-26 Thread Jan Kiszka
Wang, Shane wrote: Avi Kivity wrote: On 05/26/2010 10:25 AM, Jan Kiszka wrote: This is for CONFIG_INTEL_TXT enabled? Good point but needs to be solved differently. tboot, the variable that is checked by the original header, is not exported to modules. I wonder how this worked out for you

Re: [PATCH v5] KVM: VMX: Enable XSAVE/XRSTORE for guest

2010-05-26 Thread Jan Kiszka
Avi Kivity wrote: On 05/26/2010 12:19 PM, Sheng Yang wrote: I've done a prototype of LM support, would send out tomorrow. But the test case in QEmu side seems got something wrong. I always got an segfault at: qemu-kvm/hw/fw_cfg.c:223 223 s-entries[arch][key].data = data; Haven't

Re: [PATCH 4/4] Hack around IOMMU changes

2010-05-26 Thread Jan Kiszka
Zachary Amsden wrote: On 05/25/2010 09:40 PM, Jan Kiszka wrote: Zachary Amsden wrote: On 05/25/2010 05:36 PM, Zachary Amsden wrote: Not for the faint of heart, this patch subverts the code by reassigning a local variable from a macro. This time, with patch. From

Re: [PATCH 2/4] Fix FPU interface changes

2010-05-26 Thread Jan Kiszka
Zachary Amsden wrote: On 05/25/2010 09:33 PM, Jan Kiszka wrote: Zachary Amsden wrote: The FPU interface changed to dynamic allocation; redefine the missing struct fpu to be a static structure and add back the old macros. The FPU interface changed to dynamic allocation; redefine

[PATCH] KVM: Fix order passed to iommu_unmap

2010-05-26 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This is obviously a left-over from the the old interface taking the size. Apparently a mostly harmless issue with the current iommu_unmap implementation. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- virt/kvm/iommu.c |2 +- 1 files changed, 1

[PATCH v2] KVM: Fix order passed to iommu_unmap

2010-05-26 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This is obviously a left-over from the the old interface taking the size. Apparently a mostly harmless issue with the current iommu_unmap implementation. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- I think this one is even closer to the right

Re: [PATCH 1/4] Fix tboot enabled macro

2010-05-27 Thread Jan Kiszka
Wang, Shane wrote: Jan Kiszka wrote: If TXT is on and VT is locked but KVM sees tboot_enabled == 0, it won't check for FEATURE_CONTROL_VMXON_ENABLED_INSIDE_SMX during setup and may consider VT unavailable. If vt is locked, txt is on, tboot_enabled = 0, then it will check VMXON_OUTSIDE_SMX

[PATCH] KVM: mmu: Remove unused local variable

2010-06-03 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- No one else checks for new build warnings? arch/x86/kvm/mmu.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index c16c4ca..9b9d773

Re: [PATCH] KVM: mmu: Remove unused local variable

2010-06-03 Thread Jan Kiszka
Xiao Guangrong wrote: Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- No one else checks for new build warnings? arch/x86/kvm/mmu.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm

Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

2009-09-09 Thread Jan Kiszka
Avi Kivity wrote: On 09/04/2009 05:43 PM, Anthony Liguori wrote: From: Jan Kiszkajan.kis...@siemens.com Rebased version of Anthony's patch: Allow to specify more than one monitor terminal via the -monitor command line switch. This is particularly useful when libvirt or some other management

Re: [Qemu-commits] [COMMIT ddd9bbd] Support for multiple -monitor devices

2009-09-09 Thread Jan Kiszka
Avi Kivity wrote: On 09/09/2009 02:42 PM, Avi Kivity wrote: On 09/09/2009 02:32 PM, Jan Kiszka wrote: This (as merged into kvm-next) breaks autotest. Autotest starts qemu-kvm with -monitor unix:/tmp/blah,server,nowait; with this patch it no longer opens the socket (as seen with lsof). I

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1 at this stage causes loading of wrong vcpu state on the next vcpu_run(). We need

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers() returns only after vcpu thread is back to kernel. Setting regs_modified to 1

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:57:40PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't work if io thread calls kvm_cpu_synchronize_state() since kvm_arch_get_registers

Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu

2009-09-09 Thread Jan Kiszka
Gleb Natapov wrote: On Wed, Sep 09, 2009 at 06:21:48PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:57:40PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Wed, Sep 09, 2009 at 05:47:13PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: regs_modified logic doesn't

Re: GDB + KVM Debug

2009-09-16 Thread Jan Kiszka
Saksena, Abhishek wrote: Hi All, I see Qemu support GDB server that allows debugging kernels, boot loaders and others. Is this kind of support is available when KVM is enabled. Yes. For some reason the single stepping of instructions doesn't seem to work when KVM is in use. So what

Re: GDB + KVM Debug

2009-09-16 Thread Jan Kiszka
Saksena, Abhishek wrote: Thanks for the quick reply. What versions (kernel/kvm-kmod and qemu-kvm) are you using? What is your host, what your target architecture/operating mode (real mode, 32 bit prot. mode, 64 bit mode)? I am using KVM-74? Do I need to upgrade then? Yes, definitely.

Re: GDB + KVM Debug

2009-09-16 Thread Jan Kiszka
Avi Kivity wrote: On 09/16/2009 07:37 PM, Jan Kiszka wrote: My target is x86 and we want to debug all real, prot. and 64 bit mode. If your host is running 64 bit mode but your target uses less, you need an extra patch [1] to deal with gdb limitations and a lacking workaround in qemu

Re: GDB + KVM Debug

2009-09-17 Thread Jan Kiszka
Saksena, Abhishek wrote: I am using KVM-88. However I can't get gdb still working. I stared qemu with -s -S option and when I try to connect gdb to it I get following error:- (gdb) target remote lochost:1234 lochost: unknown host lochost:1234: No such file or directory. (gdb) target

[PATCH] gdbstub: x86: Switch 64/32 bit registers dynamically

2009-09-17 Thread Jan Kiszka
it by switching the register layout as the guest switches its execution mode between 16/32 and 64 bit. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Sent to qemu-kvm for inclusion on Avi's request as this workaround is still disliked upstream. Note: qemu-kvm's gdbstub support in kvm mode is currently

[PATCH] qemu-kvm: Fix guest single-stepping

2009-09-17 Thread Jan Kiszka
Hopefully the last regression of 4c0960c0: KVM_SET_GUEST_DEBUG requires properly synchronized guest registers (on x86: eflags) on entry. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qemu-kvm.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qemu-kvm.c b/qemu

Re: [PATCH 1/5] Implement #NMI exiting for nested SVM

2009-09-18 Thread Jan Kiszka
Alexander Graf wrote: When injecting an NMI to the l1 guest while it was running the l2 guest, we didn't #VMEXIT but just injected the NMI to the l2 guest. Let's be closer to real hardware and #VMEXIT if we're supposed to do so. Signed-off-by: Alexander Graf ag...@suse.de ---

Re: [PATCH 2/5] Don't call svm_complete_interrupts for nested guests

2009-09-18 Thread Jan Kiszka
Alexander Graf wrote: SVM has some cleanup code, that tries to reinject interrupts and exceptions when the guest didn't manage to deal with them yet. It basically transfers them to KVM internal state. Unfortunately, the internal state is reserved for the L1 guest state, so we shouldn't try

Re: [PATCH 1/5] Implement #NMI exiting for nested SVM

2009-09-18 Thread Jan Kiszka
Alexander Graf wrote: Am 18.09.2009 um 15:33 schrieb Jan Kiszka jan.kis...@siemens.com: Alexander Graf wrote: When injecting an NMI to the l1 guest while it was running the l2 guest, we didn't #VMEXIT but just injected the NMI to the l2 guest. Let's be closer to real hardware

[PATCH] qemu-kvm: Reindent pc_new_cpu

2009-09-18 Thread Jan Kiszka
...for better match with upstream. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- PS: regs_modified = 1 is another sign that the initialization order in qemu-kvm needs a rework. hw/pc.c | 28 +++- 1 files changed, 15 insertions(+), 13 deletions(-) diff --git

[PATCH] qemu-kvm: Cleanup compatfd makefile rule

2009-09-18 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 6a9ca7c..6855fa2 100644 --- a/Makefile +++ b/Makefile @@ -65,9 +65,8 @@ recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES) block

[PATCH] x86: Pick up local arch trace header (was: kvm-kmod 88 or git not working with 2.6.31)

2009-09-19 Thread Jan Kiszka
--init ./configure --kerneldir=/usr/src/linux make sync make still the same error. is there a patch for 2.6.31 support? This should fix it: -- This unbreaks 2.6.31 builds but also ensures that we always use the most recent one. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

Re: [PATCH 01/24] Don't disable werror unconditionally

2009-09-19 Thread Jan Kiszka
Avi Kivity wrote: On 09/18/2009 10:02 PM, Marcelo Tosatti wrote: On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: Signed-off-by: Juan Quintelaquint...@redhat.com --- configure |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure

Re: eepro100.c

2009-09-19 Thread Jan Kiszka
Michal Filka wrote: Hi, I have question on i82557b emulation in kvm. I have run a proprietary operating system (Pharlap OS) in kvm. Part of the job has been porting driver for i8255x. During the job I discovered that kvm's emulation doesn't support a RNR interrupt (it is disabled in the

Re: [PATCH 0/2] make --disable-kvm to compile again

2009-09-19 Thread Jan Kiszka
Juan Quintela wrote: There were a couple of missing #ifdef KVM_* from last merge. ./configure --disable-kvm compiles and boots again. It compiles, it boot, it is perfect!!! (*) Well, almost (try to build all targets): :p You also have to move vga_dirty_log_start/stop back to vga.c where

  1   2   3   4   5   6   7   8   9   10   >