[KVM-AUTOTEST PATCH 1/5] KVM test: kvm_preprocessing.py: minor style corrections

2010-03-21 Thread Michael Goldish
Also, fetch the KVM version before setting up the VMs. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 58 +++- 1 files changed, 27 insertions(+), 31 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b

[KVM-AUTOTEST PATCH 2/5] KVM test: kvm.py: make sure all dump_env() calls are inside 'finally' blocks

2010-03-21 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 9b8a10c..c6e146d 100644 --- a/client/tests/kvm/kvm.py +++ b

[KVM-AUTOTEST PATCH 4/5] KVM test: make kvm_stat usage optional

2010-03-21 Thread Michael Goldish
Relying on the test tag is not cool. Use a dedicated parameter instead. By default, all tests except build tests will use kvm_stat. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py |8 client/tests/kvm/tests_base.cfg.sample |3 +++ 2

[KVM-AUTOTEST PATCH 3/5] KVM test: kvm_utils.load_env(): do not fail if env file is corrupted

2010-03-21 Thread Michael Goldish
- Include the unpickling code in the 'try' block, so that an exception raised during unpickling will not fail the test. - Change the default env (returned by load_env() when the file is missing or corrupt) to {}. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

[KVM-AUTOTEST PATCH 5/5] KVM test: take frequent screendumps during all tests

2010-03-21 Thread Michael Goldish
place.) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 85 +-- client/tests/kvm/tests_base.cfg.sample | 13 - 2 files changed, 89 insertions(+), 9 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b

Re: [Autotest] [PATCH 4/4] KVM test: Enable timedrift for Linux guests

2010-03-22 Thread Michael Goldish
- Jason Wang jasow...@redhat.com wrote: We should also test timedrift for Linux guests especially for guest with pvclock. So this patch enable the timedrift for linux guests. Signed-off-by: Jason Wang jasow...@redhat.com --- client/tests/kvm/tests_base.cfg.sample | 11 ++-

[KVM-AUTOTEST PATCH v2] KVM test: kvm_preprocessing.py: minor style corrections

2010-03-22 Thread Michael Goldish
, change 'for k in params.keys()' to 'for k in params' in process_command(). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 58 +++- 1 files changed, 27 insertions(+), 31 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH v2] KVM test: take frequent screendumps during all tests

2010-03-22 Thread Michael Goldish
place.) Changes from v1: Print debug messages when starting or terminating the screendump thread. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 87 +-- client/tests/kvm/tests_base.cfg.sample | 13 - 2 files

[KVM-AUTOTEST PATCH v3] KVM test: take frequent screendumps during all tests

2010-03-23 Thread Michael Goldish
or terminating the screendump thread. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 98 ++-- client/tests/kvm/tests_base.cfg.sample | 13 +++- 2 files changed, 102 insertions(+), 9 deletions(-) diff --git a/client

[KVM-AUTOTEST PATCH 1/5] KVM test: remote_login(): if rss.exe says Please wait, wait

2010-03-23 Thread Michael Goldish
Recognize rss.exe's Please wait message and give the login procedure more time to complete. The message is sent before spawning cmd.exe, which may take some time under heavy load. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py |9 +++-- 1 files

[KVM-AUTOTEST PATCH 2/5] KVM test: tests_base.cfg.sample: add /f option to all Windows shutdown commands

2010-03-23 Thread Michael Goldish
It seems that when Windows is locked it refuses to shutdown unless given the /f option. - Add /f to all Windows shutdown and reboot commands. - Remove duplicate shutdown and reboot commands for Win2003, Win2008 and Win7. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm

[KVM-AUTOTEST PATCH 3/5] KVM test: timedrift: first open ssh/rss sessions with the guest, then start load

2010-03-23 Thread Michael Goldish
open all load sessions first, and then send the load command to all open sessions. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/timedrift.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests/timedrift.py b/client

[KVM-AUTOTEST PATCH 4/5] KVM test: stress_boot: make boot timeout controllable

2010-03-23 Thread Michael Goldish
Use parameter 'boot_timeout'. Defaults to 240. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/stress_boot.py |9 + client/tests/kvm/tests_base.cfg.sample |1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/client/tests/kvm/tests

[KVM-AUTOTEST PATCH 5/5] KVM test: abort-on-error mode

2010-03-23 Thread Michael Goldish
(somewhere in tests_base.cfg). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 13 + client/tests/kvm/tests.cfg.sample |5 + 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b

[KVM-AUTOTEST PATCH] KVM test: timedrift: open load sessions before taking initial time

2010-03-24 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/timedrift.py | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/client/tests/kvm/tests/timedrift.py b/client/tests/kvm/tests/timedrift.py index 194f09c..9cb7489 100644

[KVM-AUTOTEST PATCH] KVM test: increase default timeout for autotest.sleeptest

2010-03-24 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample index 249f1b4..b8288fc 100644 --- a/client/tests

[KVM-AUTOTEST PATCH] KVM test: tests_base.cfg.sample: remove kill_vm_gracefully=no for system_powerdown

2010-03-24 Thread Michael Goldish
There's no good reason to set kill_vm_gracefully=no for system_powerdown. Furthermore, killing the VM ungracefully (with 'quit') can severely damage the filesystem (I witnessed that at least once). Therefore, revert to the default, which is kill_vm_gracefully=yes. Signed-off-by: Michael Goldish

Re: [PATCH 1/2] KVM test: Make the profiler could be configurated

2010-03-30 Thread Michael Goldish
- Jason Wang jasow...@redhat.com wrote: The patch let the profilers could be specified through configuration file. kvm_stat was kept as the default profiler. Looks good. Some minor style comments: Signed-off-by: Jason Wang jasow...@redhat.com --- client/tests/kvm/kvm_utils.py

[KVM-AUTOTEST PATCH] KVM test: kvm_vm: destroy VM if hugepage setup fails

2010-03-30 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 921414d..047505a 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm

Re: [PATCH 2/3] KVM Test: Add function run_autotest_background and wait_autotest_background.

2010-04-08 Thread Michael Goldish
On 04/07/2010 11:49 AM, Feng Yang wrote: Add function run_autotest_background and wait_autotest_background to kvm_test_utils.py. This two functions is used in ioquit test script. Signed-off-by: Feng Yang fy...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 68

Re: [PATCH 3/3] KVM Test: Add ioquit test case

2010-04-08 Thread Michael Goldish
On 04/07/2010 11:49 AM, Feng Yang wrote: Signed-off-by: Feng Yang fy...@redhat.com --- client/tests/kvm/tests/ioquit.py | 54 client/tests/kvm/tests_base.cfg.sample |4 ++ 2 files changed, 58 insertions(+), 0 deletions(-) create mode 100644

Re: kvm autotest, how to disable address cache

2010-04-15 Thread Michael Goldish
On 04/08/2010 11:53 PM, Ryan Harper wrote: Is there any way to disable this? I'm running a guest on -net user networking, no interaction with the host network, yet, during the test, I get tons of: 15:50:48 DEBUG| (address cache) Adding cache entry: 00:1a:64:39:04:91 --- 10.0.253.16

Re: [PATCH] KVM test: Silence screendump thread by default

2010-04-20 Thread Michael Goldish
On 04/16/2010 09:12 PM, Lucas Meneghel Rodrigues wrote: The VM screendump thread recently introduced generates a lot of output on debug logs. Such output is not needed most of the time (we are interested to see if a screenshot production attempt failed though) and distracts the user from

Re: [PATCH] [RFC] KVM test: Create a remote session cleaning thread

2010-04-21 Thread Michael Goldish
On 04/17/2010 01:23 AM, Lucas Meneghel Rodrigues wrote: In some occasions even though a VM has terminated, some remote shell sessions will take a long time before giving up on the host. This situation is happening frequently on subtests such as autotest: The VM shuts down, but the session

Re: [PATCH 3/9] KVM test: Make the login re suitable for serial console

2010-04-28 Thread Michael Goldish
On 04/26/2010 01:03 PM, Jason Wang wrote: Current matching re ^\s*[Ll]ogin:\s*$ is not suitable for the serial console, so change it to [Ll]ogin:. Signed-off-by: Jason Wang jasow...@redhat.com --- client/tests/kvm/kvm_utils.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH 1/9] KVM test: Introduce the prompt assist

2010-04-28 Thread Michael Goldish
On 04/26/2010 01:03 PM, Jason Wang wrote: Sometimes we need to send an assist string to a session in order to get the prompt especially when re-connecting to an already logged serial session. This patch send the assist string before doing the pattern matching of remote_login. Can you give an

Re: [PATCH 2/9] KVM test: Add the ability to send the username in remote_login()

2010-04-28 Thread Michael Goldish
On 04/26/2010 01:03 PM, Jason Wang wrote: In order to let the serial console work, we must let the remote_login() send the username when needed. Signed-off-by: Jason Wang jasow...@redhat.com --- client/tests/kvm/kvm_utils.py | 14 ++ 1 files changed, 10 insertions(+), 4

Re: [Autotest] [PATCH 8/9] KVM test: Create the background threads before calling process()

2010-04-28 Thread Michael Goldish
On 04/26/2010 01:04 PM, Jason Wang wrote: If the screendump and scrialdump threads are created after the process(), we may lose the progress tracking of guest shutting down. So this patch creates them before calling process() in preprocess. Signed-off-by: Jason Wang jasow...@redhat.com ---

Re: [PATCH 7/9] KVM test: Introduce the local_login()

2010-04-28 Thread Michael Goldish
On 04/26/2010 01:04 PM, Jason Wang wrote: This patch introduces a new method which is used to log into the guest through the guest serial console. The serial_mode must be set to session in order to make use of this patch. In what cases would we want to use this feature? The serial console is

Re: [Autotest] [PATCH 7/9] KVM test: Introduce the local_login()

2010-05-05 Thread Michael Goldish
On 04/29/2010 02:44 AM, Amos Kong wrote: On Wed, Apr 28, 2010 at 03:01:40PM +0300, Michael Goldish wrote: On 04/26/2010 01:04 PM, Jason Wang wrote: This patch introduces a new method which is used to log into the guest through the guest serial console. The serial_mode must be set to session

Re: [PATCH v2 10/10] KVM test: Add a helper to search the panic in the log

2010-05-12 Thread Michael Goldish
On 05/11/2010 12:04 PM, Jason Wang wrote: This checker serves as the post_command to find the panic information in the file which contains the content of guest serial console. Signed-off-by: Jason Wang jasow...@redhat.com --- client/tests/kvm/scripts/check_serial.py | 41

[KVM-AUTOTEST PATCH] KVM test: formatting improvements to scan_results.py

2010-05-17 Thread Michael Goldish
Print results clearly even if test names are very long. Also, for consistency, use the same quote character everywhere. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/scan_results.py | 49 ++--- 1 files changed, 29 insertions(+), 20

[KVM-AUTOTEST PATCH] KVM test: use command line option wrapper functions

2010-05-17 Thread Michael Goldish
In order to support multiple versions of qemu which use different command line options or syntaxes, wrap all command line options in small helper functions, which append text to the command line according to the output of 'qemu -help'. Signed-off-by: Michael Goldish mgold...@redhat.com

[KVM-AUTOTEST PATCH] KVM test: make use of tcpdump optional

2010-05-17 Thread Michael Goldish
To disable tcpdump, set 'run_tcpdump = no' in a config file. If 'run_tcpdump' isn't set at all, it defaults to 'yes'. (Currently TAP mode cannot be used without tcpdump.) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |2 +- client/tests/kvm

Re: [Autotest] [KVM-AUTOTEST PATCH] KVM test: make use of tcpdump optional

2010-05-17 Thread Michael Goldish
On 05/17/2010 04:35 PM, Lucas Meneghel Rodrigues wrote: On Mon, 2010-05-17 at 16:29 +0300, Michael Goldish wrote: To disable tcpdump, set 'run_tcpdump = no' in a config file. If 'run_tcpdump' isn't set at all, it defaults to 'yes'. (Currently TAP mode cannot be used without tcpdump.) Maybe

Re: [Autotest] [PATCH] KVM Test: Make remote_scp() more robust.

2010-05-17 Thread Michael Goldish
On 05/07/2010 01:26 PM, Feng Yang wrote: 1. In remote_scp(), if SCP connetion stalled for some reason, following code will be ran. else: # match == None logging.debug(Timeout elapsed or process terminated) status = sub.get_status() sub.close()

Re: [Autotest] [PATCH] KVM Test: Make remote_scp() more robust.

2010-05-20 Thread Michael Goldish
On 05/19/2010 05:14 AM, Feng Yang wrote: - Michael Goldish mgold...@redhat.com wrote: From: Michael Goldish mgold...@redhat.com To: Feng Yang fy...@redhat.com Cc: autot...@test.kernel.org, kvm@vger.kernel.org Sent: Monday, May 17, 2010 11:05:37 PM GMT +08:00 Beijing / Chongqing / Hong

Re: [KVM-AUTOTEST PATCH] KVM test: use command line option wrapper functions

2010-05-20 Thread Michael Goldish
consumption. - Michael Goldish mgold...@redhat.com wrote: From: Michael Goldish mgold...@redhat.com To: autot...@test.kernel.org, kvm@vger.kernel.org Cc: Michael Goldish mgold...@redhat.com Sent: Monday, May 17, 2010 9:29:35 PM GMT +08:00 Beijing / Chongqing / Hong Kong / Urumqi

Re: [Autotest] [v3 PATCH] KVM test: Add a helper to search the panic in the log

2010-05-20 Thread Michael Goldish
On 05/19/2010 12:13 PM, Jason Wang wrote: This checker serves as the post_command to find the panic information in the file which contains the content of guest serial console. Changes from v2: - Put all things into __main__ - Fix some typos Signed-off-by: Jason Wang jasow...@redhat.com

Re: [Autotest] [v3 PATCH] KVM test: Add a helper to search the panic in the log

2010-05-26 Thread Michael Goldish
On 05/24/2010 10:38 AM, Jason Wang wrote: Michael Goldish wrote: On 05/19/2010 12:13 PM, Jason Wang wrote: This checker serves as the post_command to find the panic information in the file which contains the content of guest serial console. Changes from v2: - Put all things

Re: [Autotest][PATCH] KVM Test: Extend migration test to test unix, exec and migrate_cancel

2010-05-26 Thread Michael Goldish
On 05/26/2010 07:41 AM, Feng Yang wrote: Update migrate() in kvm_test_utils.py to support unix, exec protocol and migration cancel test. Add four migration sub test. There are tcp, unix, exec and mig_cancel. migrate_cancel only work in tcp protocol. Signed-off-by: Feng Yang fy...@redhat.com

[KVM-AUTOTEST PATCH 1/4] KVM test: support -kernel and -append command line options

2010-06-03 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 94bacdf..f3c05f3 100755 --- a/client/tests/kvm/kvm_vm.py +++ b

[KVM-AUTOTEST PATCH 2/4] KVM test: add boolean 'testdev' VM parameter for RHEL-6 style unit tests

2010-06-03 Thread Michael Goldish
Should be set to yes to enable testdev. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index f3c05f3

[KVM-AUTOTEST PATCH 3/4] KVM test: add wrapper for RHEL-6 style unittests

2010-06-03 Thread Michael Goldish
Based on Naphtali Sprei's patches. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/unittest.py | 66 1 files changed, 66 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/tests/unittest.py diff --git a/client

[KVM-AUTOTEST PATCH 4/4] KVM test: add sample RHEL-6 style unittest config file

2010-06-03 Thread Michael Goldish
Based on Naphtali Sprei's patches. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/unittests.cfg.sample | 98 + 1 files changed, 98 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/unittests.cfg.sample diff --git

[KVM-AUTOTEST PATCH] KVM test: kvm_vm.py: don't require pci_assignable to be defined

2010-06-06 Thread Michael Goldish
Currently to disable PCI device assignment pci_assignable must be explicitly set to no. This patch allows it to remain undefined (and adds a warning message and a comment). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 47

[PATCH 02/19] KVM test: Migration test cleanup

2009-09-09 Thread Michael Goldish
This should hopefully make the test code a little more readable. The test is now also more similar to other tests in that it uses a single 'main_vm', which gets cloned, instead of a source and a destination VM. (This will allow to easily run multiple migration iterations.) Signed-off-by: Michael

[PATCH 03/19] KVM test: scan_results.py: allow parsing and printing of multiple result files

2009-09-09 Thread Michael Goldish
This is useful for printing results of several jobs executing in parallel (using job.parallel()). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/scan_results.py | 42 +++-- 1 files changed, 22 insertions(+), 20 deletions(-) diff --git

[PATCH 01/19] KVM test: kvm_utils.py: make verify_ip_address_ownership() more robust

2009-09-09 Thread Michael Goldish
Use arping in addition to querying the arp cache. Under certain circumstances a TCP connection may not trigger an ARP request so it must be triggered explicitly using arping. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 40

[PATCH 05/19] KVM test: kvm_subprocess: use kill_process_tree() to close child processes

2009-09-09 Thread Michael Goldish
This is safer than just killing the session leader because some processes seem to remain alive after their session leader has exited. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |7 ++- client/tests/kvm/kvm_vm.py |2 +- 2 files

[PATCH 04/19] KVM test: kvm_utils.py: add kill_process_tree()

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index f046810..f686a53 100644 --- a/client/tests/kvm

[PATCH 07/19] KVM test: kvm_subprocess: get rid of get_pid() (replace it with get_shell_pid())

2009-09-09 Thread Michael Goldish
Don't differentiate between the PID of the subprocess and the PID of the shell running it. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 38 +-- client/tests/kvm/kvm_tests.py |2 +- 2 files changed, 7

[PATCH 09/19] KVM test: kvm_config.py: remove unused function get_match_block_indices()

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_config.py | 27 --- 1 files changed, 0 insertions(+), 27 deletions(-) diff --git a/client/tests/kvm/kvm_config.py b/client/tests/kvm/kvm_config.py index da7988b..405de4b 100755 --- a/client

[PATCH 08/19] KVM test: remove unused function is_sshd_running()

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_utils.py | 46 - client/tests/kvm/kvm_vm.py| 15 - 2 files changed, 0 insertions(+), 61 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests

[PATCH 06/19] KVM test: timedrift test: set CPU affinity recursively for all children

2009-09-09 Thread Michael Goldish
In addition to setting the CPU affinity of the given process, set it for all of its children too. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b

[PATCH 10/19] KVM test: boot test: add option to reboot using system_reset

2009-09-09 Thread Michael Goldish
system_reset, the VM is sent a system_reset monitor command, and the test waits until the guest comes back up. Before sending the system_reset command the test sleeps for a given duration. The duration is controlled by the parameter 'sleep_before_reset'. Signed-off-by: Michael Goldish mgold

[PATCH 11/19] KVM test: shutdown test: allow shutting down using system_powerdown

2009-09-09 Thread Michael Goldish
of time (controlled by the parameter sleep_before_powerdown) and then sends the system_powerdown monitor command. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |8 client/tests/kvm/kvm_tests.py | 22 -- 2 files

[PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-09 Thread Michael Goldish
. For example, a function should not be used where it may display misleading or inaccurate info or debug messages. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 61 1 files changed, 61 insertions(+), 0 deletions

[PATCH 13/19] KVM test: kvm_tests.py: save test code by using utilities in kvm_test_utils.py

2009-09-09 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 148 - 1 files changed, 27 insertions(+), 121 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py index 863b863..35666cf 100644

[PATCH 14/19] KVM test: kvm_preprocessing.py: don't explicitly print failure messages

2009-09-09 Thread Michael Goldish
This is taken care of elsewhere, so currently when something fails during pre/post-processing, messages get logged twice. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff

[PATCH 16/19] KVM test: kvm_subprocess: robustify the test for child process termination

2009-09-09 Thread Michael Goldish
Don't rely on os.read() raising an exception; use waitpid() to check for child termination: - every 0.5 seconds, or - when os.read() raises an exception, or - when os.read() returns a zero-length string. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py

[PATCH 15/19] KVM test: Autotest test wrapper cleanup

2009-09-09 Thread Michael Goldish
Make the code shorter and simpler. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 153 +++-- 1 files changed, 72 insertions(+), 81 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py

[PATCH 17/19] KVM test: kvm_vm.py: add macaddr= to command line only if a MAC address is given

2009-09-09 Thread Michael Goldish
(Avoid adding weird things like 'macaddr=None' to the command line.) Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index d360d8e

[PATCH 18/19] KVM test: kvm_tests.cfg.sample: get all Windows test utilities from a single ISO

2009-09-09 Thread Michael Goldish
' tests still use the usual ISO files. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample | 18 +- 1 files changed, 5 insertions(+), 13 deletions(-) diff --git a/client/tests/kvm/kvm_tests.cfg.sample b/client/tests/kvm/kvm_tests.cfg.sample

[PATCH 19/19] KVM test: kvm_preprocessing.py: verify PPM file validity before passing to PIL

2009-09-09 Thread Michael Goldish
Passing PIL an invalid PPM file makes it throw an IOError. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm

[PATCH 1/3] KVM test: use a better source for random numbers

2009-09-10 Thread Michael Goldish
and is probably done by default anyway. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |5 + client/tests/kvm/kvm_utils.py |3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 4930e80

[PATCH 2/3] [RFC] KVM test: kvm_tests.cfg.sample: add some scheduler params

2009-09-10 Thread Michael Goldish
used_cpus denotes the number of CPUs required for a test. used_mem denotes the amount of RAM required for a test. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/client

[PATCH 3/3] [RFC] KVM test: client parallel test execution

2009-09-10 Thread Michael Goldish
between the queues (workers). This should be straightforward to do but I haven't had the time to do it yet. scan_results.py can be used to list the test results during and after execution. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control.parallel | 320

[KVM-AUTOTEST PATCH v2 1/3] KVM test: use a better source for random numbers

2009-09-11 Thread Michael Goldish
and is probably done by default anyway. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm.py |5 + client/tests/kvm/kvm_utils.py |3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm/kvm.py b/client/tests/kvm/kvm.py index 4930e80

[KVM-AUTOTEST PATCH v2 2/3] [RFC] KVM test: kvm_tests.cfg.sample: add some scheduler params

2009-09-11 Thread Michael Goldish
of CPUs required for a test. used_mem denotes the amount of RAM required for a test. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH v2 3/3] [RFC] KVM test: client parallel test execution

2009-09-11 Thread Michael Goldish
the test results during and after execution. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control.parallel | 330 + 1 files changed, 330 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/control.parallel diff --git

Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-14 Thread Michael Goldish
- Uri Lublin u...@redhat.com wrote: On 09/14/2009 08:26 AM, Yolkfull Chow wrote: On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: This module is meant to reduce code size by performing common test procedures. Generally, code here should look like test code. +def

[KVM-AUTOTEST PATCH 1/4] KVM test: migration test: destroy dest_vm if test fails

2009-09-14 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.py | 94 ++--- 1 files changed, 50 insertions(+), 44 deletions(-) diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py index b61d98c..446b415 100644

[KVM-AUTOTEST PATCH 2/4] KVM test: wait_for_login(): include the VM's name in log messages

2009-09-14 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_test_utils.py b/client/tests/kvm/kvm_test_utils.py index 39e92b9..9924232 100644 --- a/client/tests/kvm

[KVM-AUTOTEST PATCH 3/4] KVM test: kvm_vm.py: wrap VM.destroy() in a try-finally block

2009-09-14 Thread Michael Goldish
This makes the function a little shorter or at least a little cleaner. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py | 84 ++-- 1 files changed, 42 insertions(+), 42 deletions(-) diff --git a/client/tests/kvm

Re: [PATCH] Adding a userspace application crash handling system to autotest

2009-09-14 Thread Michael Goldish
I think this is a very useful feature to have. Please see some very minor comments below. - Lucas Meneghel Rodrigues l...@redhat.com wrote: This patch adds a system to watch user space segmentation faults, writing core dumps and some degree of core dump analysis report. We believe that

Re: [Autotest] [KVM-AUTOTEST PATCH 0/7] KVM test: support for the new remote shell server for Windows

2009-09-14 Thread Michael Goldish
- Yolkfull Chow yz...@redhat.com wrote: On Tue, Aug 18, 2009 at 06:30:14PM -0400, Michael Goldish wrote: - Lucas Meneghel Rodrigues l...@redhat.com wrote: On Tue, Aug 18, 2009 at 7:15 AM, Michael Goldishmgold...@redhat.com wrote: - Lucas Meneghel Rodrigues l

Re: [Autotest] [KVM-AUTOTEST PATCH 0/7] KVM test: support for the new remote shell server for Windows

2009-09-17 Thread Michael Goldish
- Michael Goldish mgold...@redhat.com wrote: - Yolkfull Chow yz...@redhat.com wrote: On Tue, Aug 18, 2009 at 06:30:14PM -0400, Michael Goldish wrote: - Lucas Meneghel Rodrigues l...@redhat.com wrote: On Tue, Aug 18, 2009 at 7:15 AM, Michael Goldishmgold

[KVM-AUTOTEST PATCH v3] [RFC] KVM test: client parallel test execution

2009-09-20 Thread Michael Goldish
it yet. scan_results.py can be used to list the test results during and after execution. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control.parallel | 176 client/tests/kvm/kvm_scheduler.py | 229 + 2

[KVM-AUTOTEST PATCH 1/4] KVM test: allow setting shell line separator string in the config file

2009-09-20 Thread Michael Goldish
The shell line separator string is appended to strings sent by sendline(). The string is controlled by the parameter shell_linesep. It defaults to \n. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |1 + client/tests/kvm/kvm_utils.py

[KVM-AUTOTEST PATCH 2/4] KVM test: rss.cpp: send characters to the console window rather than directly to STDIN

2009-09-20 Thread Michael Goldish
Some Windows programs behave badly when their STDIN is redirected to a pipe (most notably wmic). Therefore, keep STDIN unredirected, and send input to the console window as a series of WM_CHAR messages. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/deps/rss.cpp | 54

[KVM-AUTOTEST PATCH 3/4] KVM test: WinXP-64-rss.steps: modify first barrier

2009-09-20 Thread Michael Goldish
The start menu button seems to have two possible appearances. Therefore change the barrier to test the center of the screen (including the mouse cursor) instead. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/steps/WinXP-64-rss.steps |2 +- 1 files changed, 1

Re: [Autotest] [KVM-AUTOTEST PATCH] Adding NAS Parallel Benchmarks(NPB) as client test [1/2]

2009-09-21 Thread Michael Goldish
- Chen Cao k...@redhat.com wrote: - Using NPB OpenMP implementaion. Signed-off-by: Cao, Chen k...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |4 + client/tests/npb/control| 28 client/tests/npb/enable-all-tests.patch | 233

Re: [Autotest] [KVM-AUTOTEST PATCH 2/4] KVM test: rss.cpp: send characters to the console window rather than directly to STDIN

2009-09-21 Thread Michael Goldish
- Yolkfull Chow yz...@redhat.com wrote: On Sun, Sep 20, 2009 at 06:16:28PM +0300, Michael Goldish wrote: Some Windows programs behave badly when their STDIN is redirected to a pipe (most notably wmic). Therefore, keep STDIN unredirected, and send input to the console window

[KVM-AUTOTEST PATCH 1/6] KVM test: kvm_subprocess: use read_nonblocking(0) instead of read_nonblocking (0.1)

2009-09-29 Thread Michael Goldish
() to send commands (because the former waits for the prompt to return, whereas the latter returns immediately). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH 2/6] KVM test: AutoIt and Autotest wrappers: use get_command_output() instead of sendline()

2009-09-29 Thread Michael Goldish
to complete, and this will make the wrapper exit as if the test has completed. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/autoit.py |7 +++ client/tests/kvm/tests/autotest.py |9 - 2 files changed, 7 insertions(+), 9 deletions(-) diff --git

[KVM-AUTOTEST PATCH 4/6] KVM test: step file tests: add parameter timeout_multiplier

2009-09-29 Thread Michael Goldish
the test more time to complete. In addition to modifying tests/steps.py, this patch adds a usage example to control and control.parallel. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/control |1 + client/tests/kvm/control.parallel |1 + client/tests/kvm/tests

[KVM-AUTOTEST PATCH 3/6] KVM test: kvm_vm.py: change qemu-img timeout to 120 seconds

2009-09-29 Thread Michael Goldish
The timeout of qemu-img commands is currently 30 seconds. This may not suffice under heavy load (e.g. when multiple tests run in parallel and use the same physical disk). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_vm.py |2 +- 1 files changed, 1 insertions

[KVM-AUTOTEST PATCH 5/6] KVM test: tests/steps.py: simplify barrier_2()

2009-09-29 Thread Michael Goldish
= float(params.get(timeout_multiplier, 1)) will raise an exception if timeout_multiplier is . Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/steps.py | 32 ++-- 1 files changed, 10 insertions(+), 22 deletions(-) diff --git a/client/tests/kvm

[KVM-AUTOTEST PATCH 6/6] KVM test: kvm_subprocess: use select() in read_until_output_matches()

2009-09-29 Thread Michael Goldish
until there's output to read from the child process. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_subprocess.py b/client/tests/kvm/kvm_subprocess.py

[KVM-AUTOTEST PATCH 1/7] KVM test: migration test: move the bulk of the code to a utility function

2009-10-07 Thread Michael Goldish
Move most of the code to a utility function in kvm_test_utils.py, in order to make it reusable. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 72 +++ client/tests/kvm/tests/migration.py | 62

[KVM-AUTOTEST PATCH 2/7] KVM test: timedrift test: move the get_time() helper function to kvm_test_utils.py

2009-10-07 Thread Michael Goldish
Move get_time() to kvm_test_utils.py to make it reusable. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 27 ++ client/tests/kvm/tests/timedrift.py | 164 -- 2 files changed, 104 insertions(+), 87 deletions

[KVM-AUTOTEST PATCH 4/7] KVM test: move the reboot code to kvm_test_utils.py

2009-10-07 Thread Michael Goldish
Move the reboot code from the boot test (tests/boot.py) to kvm_test_utils.py in order to make it reusable. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_test_utils.py | 44 client/tests/kvm/tests/boot.py | 33

[KVM-AUTOTEST PATCH 6/7] KVM test: add option to kill all unresponsive VMs at the end of each test

2009-10-07 Thread Michael Goldish
This is useful for tests that may leave VMs in a bad state but can't afford to use kill_vm_on_error = yes. For example, timedrift.with_reboot can fail because the reboot failed or because the time drift was too large. In the latter case there's no reason to kill the VM. Signed-off-by: Michael

[KVM-AUTOTEST PATCH 3/7] KVM test: new test timedrift_with_migration

2009-10-07 Thread Michael Goldish
This patch adds a new test that checks the timedrift introduced by migrations. It uses the same parameters used by the timedrift test to get the guest time. In addition, the number of migrations the test performs is controlled by the parameter 'migration_iterations'. Signed-off-by: Michael

[KVM-AUTOTEST PATCH 7/7] KVM test: kvm_preprocessing.py: fix indentation and logging messages in postprocess_vm

2009-10-07 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py index e624a42..5bae2bd 100644 --- a/client

[KVM-AUTOTEST PATCH 5/7] KVM test: new test timedrift_with_reboot

2009-10-07 Thread Michael Goldish
Checks the time drift introduced by several reboots (default 1). Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_tests.cfg.sample |5 ++ client/tests/kvm/tests/timedrift_with_reboot.py | 88 +++ 2 files changed, 93 insertions(+), 0

Re: [KVM-AUTOTEST,01/17] Add new module kvm_subprocess

2009-10-12 Thread Michael Goldish
in one big try..finally block: session = ... try: try: except: try: except: ... finally: session.close() - Original Message - From: Chen Cao k...@redhat.com To: Michael Goldish mgold...@redhat.com Cc: autot...@test.kernel.org, kvm@vger.kernel.org Sent: Monday, October 12, 2009 8

Re: [Autotest] [KVM-AUTOTEST PATCH 3/7] KVM test: new test timedrift_with_migration

2009-10-12 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: Hi Michael, I am reviewing your patchset and have just a minor remark to make here: On Wed, Oct 7, 2009 at 2:54 PM, Michael Goldish mgold...@redhat.com wrote: This patch adds a new test that checks the timedrift introduced

[KVM-AUTOTEST PATCH 1/3] KVM test: kvm_subprocess.py: do not start tail thread by default

2009-10-13 Thread Michael Goldish
Start the tail thread only if the user specifies a non-None output_func or termination_func. Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_subprocess.py | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm

  1   2   3   4   5   6   7   >