[PATCH] kvm tools: fix help output for run command

2012-10-11 Thread William Dauchy
This dummy patch remove tabs in help output. Introduced in commit: ae9ec23 kvm tools: generate command line options dynamically Signed-off-by: William Dauchy --- tools/kvm/builtin-run.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a

[PATCH 3/5] kvm tools: correctly handle mem ballooning

2012-10-24 Thread William Dauchy
from the virtio_balloon.h: num_pages is the number of pages host wants Guest to give up. Our implementation is doing the reverse, resulting in decreasing pages when increasing needed and so on. Reverse the implementation. Signed-off-by: William Dauchy --- tools/kvm/virtio/balloon.c |8

[PATCH 1/5] kvm tools: check ioctl return value for msi signal

2012-10-24 Thread William Dauchy
Signed-off-by: William Dauchy --- tools/kvm/virtio/pci.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c index b6ac571..ab1119a 100644 --- a/tools/kvm/virtio/pci.c +++ b/tools/kvm/virtio/pci.c @@ -245,7 +245,9 @@ static

[PATCH 4/5] kvm tools: initialize msi flags to zero even is not used yet

2012-10-24 Thread William Dauchy
kvm explictly checks if msi flags is equal to zero before going further; just make sure it is correctly initialized. Signed-off-by: William Dauchy --- tools/kvm/virtio/pci.c |1 + 1 file changed, 1 insertion(+) diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c index f4ea3c9

[PATCH 5/5] kvm tools: specify the amount to balloon is in MB

2012-10-24 Thread William Dauchy
Signed-off-by: William Dauchy --- tools/kvm/builtin-balloon.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/kvm/builtin-balloon.c b/tools/kvm/builtin-balloon.c index 5bd2291..d158ace 100644 --- a/tools/kvm/builtin-balloon.c +++ b/tools/kvm/builtin-balloon.c

[PATCH 0/5] kvm tools: virtio-balloon fix and cleaning

2012-10-24 Thread William Dauchy
Hi, This set of patches fixes the virtio ballooning and also clean a few non important things around ballooning functionnality. Tested on top of a v3.6.3 for both guest and host. William Dauchy (5): kvm tools: check ioctl return value for msi signal kvm tools: use the correct config vector

[PATCH 2/5] kvm tools: use the correct config vector interrupt

2012-10-24 Thread William Dauchy
when registering the config interrupt, the later is registered in vcpi->config_vector and not in vpci->vq_vector introduced in: a841f15 kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject interrupts directly. Signed-off-by: William Dauchy --- tools/kvm/virtio/pci.c |2 +- 1 file c

Re: [PATCH 3/5] kvm tools: correctly handle mem ballooning

2012-10-24 Thread William Dauchy
On Oct24 13:43, Sasha Levin wrote: > This one was actually correct originally. > > When we inflate (-i) the balloon we increase num_pages, which is a > counter of how many pages the balloon has. Sorry, I misunderstood the option; please ignore this patch. Thanks, -- William signature.asc Desc

Re: [PATCH 1/5] kvm tools: check ioctl return value for msi signal

2012-10-25 Thread William Dauchy
On Oct25 10:01, Pekka Enberg wrote: > Is this something that happens on your machine? I wonder if it makes more > sense to return the error from virtio_pci__signal_vq() and > virtio_pci__signal_config() and make the callers deal with it. no but I thought it was worth not keeping a system call un

Re: [PATCH 4/5] kvm tools: initialize msi flags to zero even is not used yet

2012-10-25 Thread William Dauchy
On Oct25 10:07, Pekka Enberg wrote: > It is initialized to zero by default as per C struct initialization, isn't > it? Does this fix a problem you are experiencing? no, just a security since kvm checks it. Anyway you can ignore this patch if you want. -- William signature.asc Description: Digi

Re: [PATCH] kvm tools: fix rbtree-interval search

2012-10-29 Thread William Dauchy
;t found the time to fix it. Applying the patch fixes the problem. Tested-by: William Dauchy Thanks, -- William signature.asc Description: Digital signature

[PATCH] kvmtool/run: set a default cmdline if not set

2015-10-31 Thread William Dauchy
=, rtld_fini=, stack_end=0x7fffe828) at libc-start.c:287 0x00403962 in _start () this patch suggests to set a minimal cmdline when kernel_cmdline is NULL Signed-off-by: William Dauchy --- builtin-run.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/builtin-run.c b

Re: [PATCH] kvm: irqchip: fix memory leak

2015-11-03 Thread William Dauchy
Hi Paolo, I was wondering it this could be a valid candidate for -stable, don't you think? (commit ba60c41) Best regards, On Sep02 12:33, Sudip Mukherjee wrote: > We were taking the exit path after checking ue->flags and return value > of setup_routing_entry(), but 'e' was not freed incase of a

kvm: irqchip: fix memory leak in -stable

2015-11-04 Thread William Dauchy
Hello stable release team, The commit ba60c41 kvm: irqchip: fix memory leak is fixing commit e73f61e kvm: irqchip: Break up high order allocations of kvm_irq_routing_table I believe commit ba60c41 kvm: irqchip: fix memory leak is a good candidate for -stable. I also got an agreement from Paolo.

Re: [PATCH v2] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c

2015-11-06 Thread William Dauchy
Hi Paolo, Looking at the history of this function, is it reasonable to say it fixes the following commit? af585b9 KVM: Halt vcpu if page it tries to access is swapped out Does it make it a good candidate for -stable? Thanks, On Oct09 12:21, Kosuke Tatsukawa wrote: > async_pf_execute() seems to