RE: [ANNOUNCE] kvm-kmod-2.6.31.5
Locally, you could simply comment out the double definition for now. Yes, that will work. Many thanks for the fast help! Is native_read_tsc the only conflict with hardy's kernel? yes. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Dietmar Maurer wrote: Locally, you could simply comment out the double definition for now. Yes, that will work. Many thanks for the fast help! Is native_read_tsc the only conflict with hardy's kernel? yes. Then you may want to have a look at [1]. If you want to test it, apply that commit to your tree and patch native_read_tsc to kvm_native_read_tsc in svm.c. Jan [1]http://git.kernel.org/?p=virt/kvm/kvm-kmod.git;a=commitdiff;h=05614f03734680065746a3ca374ba00f71785126 signature.asc Description: OpenPGP digital signature
RE: [ANNOUNCE] kvm-kmod-2.6.31.5
This release has been tested on x86 down to host kernel 2.6.27 and
builds down to 2.6.24. Building against older kernels is expected to be
broken, but if anyone provides patches to fix it, I'm open to merge
them.
I am still not able to build with our 2.6.24 kernel.
./sync -v kvm-kmod-2.6.31.5 -l /path/to/kernel/linux-2.6.24-openvz
Traceback (most recent call last):
File ./sync, line 247, in module
header_sync(arch)
File ./sync, line 219, in header_sync
hack(T, arch, 'include/asm-%(arch)s/kvm.h' % { 'arch': arch })
File ./sync, line 158, in hack
_hack(T + '/' + file, arch)
File ./sync, line 149, in _hack
data = file(fname).read()
IOError: [Errno 2] No such file or directory: 'header/include/asm-x86/kvm.h'
The files required are simply not in the correct location. But it seem that
make sync (after manually change paths and remove non-existing files) does not
change a single file anyways for kernel 2.6.24?
So I can simply skip 'make sync'?
But when I run make I get the following error:
/home/dietmar/svn-devel/pve-kernel-2.6.24/kvm-kmod-2.6.31.5/x86/external-module-compat.h:93:
error: redefinition of native_read_tsc
include/asm/msr.h:230: error: previous definition of native_read_tsc was here
if fact, it is defined in msr.h too:
static inline unsigned long long native_read_tsc(void)
{
unsigned long long val;
rdtsc_barrier();
asm volatile(rdtsc : =A (val));
rdtsc_barrier();
return val;
}
and in external-module-compat.h:
static inline unsigned long long native_read_tsc(void)
{
unsigned long long val;
asm volatile(rdtsc : =A (val));
return val;
}
And I compile on 64bit. So what is the correct version?
- Dietmar
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Dietmar Maurer wrote:
This release has been tested on x86 down to host kernel 2.6.27 and
builds down to 2.6.24. Building against older kernels is expected to be
broken, but if anyone provides patches to fix it, I'm open to merge
them.
I am still not able to build with our 2.6.24 kernel.
./sync -v kvm-kmod-2.6.31.5 -l /path/to/kernel/linux-2.6.24-openvz
Traceback (most recent call last):
File ./sync, line 247, in module
header_sync(arch)
File ./sync, line 219, in header_sync
hack(T, arch, 'include/asm-%(arch)s/kvm.h' % { 'arch': arch })
File ./sync, line 158, in hack
_hack(T + '/' + file, arch)
File ./sync, line 149, in _hack
data = file(fname).read()
IOError: [Errno 2] No such file or directory: 'header/include/asm-x86/kvm.h'
The files required are simply not in the correct location. But it seem that
make sync (after manually change paths and remove non-existing files) does
not change a single file anyways for kernel 2.6.24?
So I can simply skip 'make sync'?
The release tarball contains all required sources (as described, they
were obtained from 2.6.31.5). So you do have to sync, just run configure
make. And you definitely *must not* sync against 2.6.24 or any other
older kernel.
But when I run make I get the following error:
/home/dietmar/svn-devel/pve-kernel-2.6.24/kvm-kmod-2.6.31.5/x86/external-module-compat.h:93:
error: redefinition of native_read_tsc
include/asm/msr.h:230: error: previous definition of native_read_tsc was
here
if fact, it is defined in msr.h too:
static inline unsigned long long native_read_tsc(void)
{
unsigned long long val;
rdtsc_barrier();
asm volatile(rdtsc : =A (val));
rdtsc_barrier();
return val;
}
and in external-module-compat.h:
static inline unsigned long long native_read_tsc(void)
{
unsigned long long val;
asm volatile(rdtsc : =A (val));
return val;
}
And I compile on 64bit. So what is the correct version?
I'm running a 64-bit 2.6.24 kernel [1] against the stable branch, but I
may have missed some constellation. Please send me your .config
(provided you get this error with a clean kvm-kmod-2.6.31.5).
Jan
[1] http://buildbot.kiszka.org/kvm-kmod/waterfall?show=stable-2.6.31
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [ANNOUNCE] kvm-kmod-2.6.31.5
Well, we use the ubuntu tree:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary
They have a few more patches applied:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=history;f=include/asm-x86/msr.h;h=cfe169475b5b50a448326ef3c34f50100ac83faf;hb=HEAD
Seems the last two patches cause the problem.
I just wonder if we need those bariers or not?
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=commitdiff;h=198b348d96c9769153e72ca2461f8d841ddff1cc
- Dietmar
-Original Message-
From: Jan Kiszka [mailto:jan.kis...@siemens.com]
Sent: Mittwoch, 28. Oktober 2009 12:55
To: Dietmar Maurer
Cc: kvm
Subject: Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Dietmar Maurer wrote:
This release has been tested on x86 down to host kernel 2.6.27 and
builds down to 2.6.24. Building against older kernels is expected to
be
broken, but if anyone provides patches to fix it, I'm open to merge
them.
I am still not able to build with our 2.6.24 kernel.
./sync -v kvm-kmod-2.6.31.5 -l /path/to/kernel/linux-2.6.24-openvz
Traceback (most recent call last):
File ./sync, line 247, in module
header_sync(arch)
File ./sync, line 219, in header_sync
hack(T, arch, 'include/asm-%(arch)s/kvm.h' % { 'arch': arch })
File ./sync, line 158, in hack
_hack(T + '/' + file, arch)
File ./sync, line 149, in _hack
data = file(fname).read()
IOError: [Errno 2] No such file or directory: 'header/include/asm-
x86/kvm.h'
The files required are simply not in the correct location. But it
seem that make sync (after manually change paths and remove non-
existing files) does not change a single file anyways for kernel
2.6.24?
So I can simply skip 'make sync'?
The release tarball contains all required sources (as described, they
were obtained from 2.6.31.5). So you do have to sync, just run
configure
make. And you definitely *must not* sync against 2.6.24 or any other
older kernel.
But when I run make I get the following error:
/home/dietmar/svn-devel/pve-kernel-2.6.24/kvm-kmod-
2.6.31.5/x86/external-module-compat.h:93: error: redefinition of
native_read_tsc
include/asm/msr.h:230: error: previous definition of
native_read_tsc was here
if fact, it is defined in msr.h too:
static inline unsigned long long native_read_tsc(void)
{
unsigned long long val;
rdtsc_barrier();
asm volatile(rdtsc : =A (val));
rdtsc_barrier();
return val;
}
and in external-module-compat.h:
static inline unsigned long long native_read_tsc(void)
{
unsigned long long val;
asm volatile(rdtsc : =A (val));
return val;
}
And I compile on 64bit. So what is the correct version?
I'm running a 64-bit 2.6.24 kernel [1] against the stable branch, but I
may have missed some constellation. Please send me your .config
(provided you get this error with a clean kvm-kmod-2.6.31.5).
Jan
[1] http://buildbot.kiszka.org/kvm-kmod/waterfall?show=stable-2.6.31
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Dietmar Maurer wrote: So I can simply skip 'make sync'? The release tarball contains all required sources (as described, they were obtained from 2.6.31.5). So you do have to sync, So I need to run 'make sync'? Ouch. Of course I meant you do *not* have to sync. Practically, there is no reason to re-sync when you have the release tarball in hands. 'make sync' is a developer tool when working with the git version of kvm-kmod and/or dragging in brand new kvm kernel sources. Sorry for the confusion. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Dietmar Maurer wrote: Well, we use the ubuntu tree: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary They have a few more patches applied: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=history;f=include/asm-x86/msr.h;h=cfe169475b5b50a448326ef3c34f50100ac83faf;hb=HEAD Seems the last two patches cause the problem. I just wonder if we need those bariers or not? http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=commitdiff;h=198b348d96c9769153e72ca2461f8d841ddff1cc The barrier is not our problem regarding the kvm-kmod build, it's the addition of native_read_tsc (http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=commitdiff;h=d10247b31c2be39ab3109015bc99bbd2ba6554d4). Do you know if there is anything to tell this ubuntu-patched kernel apart from a vanilla version? If so, we could adjust the check in x86/external-module-compat.h to avoid this breakage. Locally, you could simply comment out the double definition for now. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [ANNOUNCE] kvm-kmod-2.6.31.5
Do you know if there is anything to tell this ubuntu-patched kernel apart from a vanilla version? If so, we could adjust the check in x86/external-module-compat.h to avoid this breakage. no, not really Locally, you could simply comment out the double definition for now. Yes, that will work. Many thanks for the fast help! - Dietmar -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Dietmar Maurer wrote: Do you know if there is anything to tell this ubuntu-patched kernel apart from a vanilla version? If so, we could adjust the check in x86/external-module-compat.h to avoid this breakage. no, not really OK, but I think I have a plan B. The next kvm-kmod release should handle this case gracefully. Locally, you could simply comment out the double definition for now. Yes, that will work. Many thanks for the fast help! Is native_read_tsc the only conflict with hardy's kernel? Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Alexander Graf wrote: On 26.10.2009, at 18:26, Jan Kiszka wrote: This package contains the kvm external modules, using the sources from latest stable Linux release 2.6.31.5. It can be used to update the kernel-side support of kvm without upgrading the host kernel. This release has been tested on x86 down to host kernel 2.6.27 and builds down to 2.6.24. Building against older kernels is expected to be broken, but if anyone provides patches to fix it, I'm open to merge them. Aww - I'm missing the awesome changelogs :-). Your wish is my command: Major KVM changes since kvm-kmod-2.6.30.1: - MSI-X support - MCE support - SVM: Reworkedfixed IRQ injection, added NMI injection - Host security: Limit lapic periodic timer frequency - Guest security: CPL check on hypercalls and debug register access - x86 emulator: lcall and soft INT support, interrupt shadow handling - Guest migration fixes (I probably missed some more important stuff) Major kvm-kmod changes: - Reanimated support down to 2.6.24 hosts - Fixed building against out-of-tree kernel builds / split kernels - udev script with auto-modprobe on boot - Installation fixes (DESTDIR) Wanted to attach this information to the tarball as well, but sourceforge's FRS is still in a almost completely broken state. Sigh. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
On 10/27/2009 10:25 AM, Jan Kiszka wrote: Wanted to attach this information to the tarball as well, but sourceforge's FRS is still in a almost completely broken state. Sigh. It can be done - upload the changelog file, make it as a changelog, and then go to the tarball and link the newly marked changelog. Messy. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
Avi Kivity wrote: On 10/27/2009 10:25 AM, Jan Kiszka wrote: Wanted to attach this information to the tarball as well, but sourceforge's FRS is still in a almost completely broken state. Sigh. It can be done - upload the changelog file, make it as a changelog, and then go to the tarball and link the newly marked changelog. Unless the web interface refuses to work with my Firefox (interestingly, it works with IE6 under Windows?!) and the shell access reports the frs folder as detached. Messy. Indeed, beside the bugs, the new concept looks like a step backward: You now have to download the changelog to view it. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] kvm-kmod-2.6.31.5
On 26.10.2009, at 18:26, Jan Kiszka wrote: This package contains the kvm external modules, using the sources from latest stable Linux release 2.6.31.5. It can be used to update the kernel-side support of kvm without upgrading the host kernel. This release has been tested on x86 down to host kernel 2.6.27 and builds down to 2.6.24. Building against older kernels is expected to be broken, but if anyone provides patches to fix it, I'm open to merge them. Aww - I'm missing the awesome changelogs :-). Great to see you take this up Jan! Alex -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
