Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-17 Thread Avi Kivity
Han, Weidong wrote: Avi Kivity wrote: +static void kvm_pci_pt_work_fn(struct work_struct *work) +{ + struct kvm_pci_pt_dev_list *match; + struct kvm_pci_pt_work *int_work; + int source; + unsigned long flags; + int guest_irq; + int host_irq; + +

Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-17 Thread Ben-Ami Yassour
On Thu, 2008-07-17 at 09:02 +0300, Avi Kivity wrote: Han, Weidong wrote: Avi Kivity wrote: +static void kvm_pci_pt_work_fn(struct work_struct *work) +{ + struct kvm_pci_pt_dev_list *match; + struct kvm_pci_pt_work *int_work; + int source; + unsigned long flags; + int guest_irq;

Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-17 Thread Avi Kivity
Ben-Ami Yassour wrote: + +/* FIXME: Implement the OR logic needed to make shared interrupts on + * this line behave properly + */ Isn't this a showstopper? There is no easy way for a user to avoid sharing, especially as we have only three pci irqs at present. What

Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-17 Thread Avi Kivity
Ben-Ami Yassour wrote: On Wed, 2008-07-16 at 18:04 +0300, Avi Kivity wrote: Ben-Ami Yassour wrote: +/* Stores information for identifying host PCI devices assigned to the + * guest: this is used in the host kernel and in the userspace. + */ +struct kvm_pci_pt_info { + unsigned

Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-17 Thread Ben-Ami Yassour
On Thu, 2008-07-17 at 11:31 +0300, Avi Kivity wrote: Ben-Ami Yassour wrote: + +/* FIXME: Implement the OR logic needed to make shared interrupts on + * this line behave properly + */ Isn't this a showstopper? There is no easy way for a user to avoid sharing,

Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-17 Thread Avi Kivity
Ben-Ami Yassour wrote: On Thu, 2008-07-17 at 12:50 +0300, Avi Kivity wrote: Ben-Ami Yassour wrote: On Wed, 2008-07-16 at 18:04 +0300, Avi Kivity wrote: If a level triggered interrupt remains active after the eoi, the ioapic has to inject it. This is used to support shared

Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-17 Thread Avi Kivity
Ben-Ami Yassour wrote: On Thu, 2008-07-17 at 11:31 +0300, Avi Kivity wrote: Ben-Ami Yassour wrote: + +/* FIXME: Implement the OR logic needed to make shared interrupts on + * this line behave properly + */ Isn't this a showstopper? There is no easy

Re: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-16 Thread Avi Kivity
Ben-Ami Yassour wrote: From: Han, Weidong [EMAIL PROTECTED] This patch adds support for handling PCI devices that are assigned to the guest (PCI passthrough). + +/* + * Used to find a registered host PCI device (a passthrough device) + * during ioctls, interrupts or EOI + */ +struct

RE: [PATCH 3/8] KVM: Handle device assignment to guests

2008-07-16 Thread Han, Weidong
Avi Kivity wrote: +static void kvm_pci_pt_work_fn(struct work_struct *work) +{ +struct kvm_pci_pt_dev_list *match; +struct kvm_pci_pt_work *int_work; +int source; +unsigned long flags; +int guest_irq; +int host_irq; + +int_work = container_of(work, struct