Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Alexander Graf
On 22.04.2010, at 12:33, Joerg Roedel wrote: The patch introducing nested nmi handling had a bug. The check does not belong to enable_nmi_window but must be in nmi_allowed. This patch fixes this. Signed-off-by: Joerg Roedel joerg.roe...@amd.com --- arch/x86/kvm/svm.c | 16

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Joerg Roedel
On Fri, Apr 23, 2010 at 03:46:07PM +0200, Alexander Graf wrote: On 22.04.2010, at 12:33, Joerg Roedel wrote: The patch introducing nested nmi handling had a bug. The check does not belong to enable_nmi_window but must be in nmi_allowed. This patch fixes this. Signed-off-by: Joerg

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Alexander Graf
On 23.04.2010, at 16:13, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 03:46:07PM +0200, Alexander Graf wrote: On 22.04.2010, at 12:33, Joerg Roedel wrote: The patch introducing nested nmi handling had a bug. The check does not belong to enable_nmi_window but must be in nmi_allowed. This

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Joerg Roedel
On Fri, Apr 23, 2010 at 04:19:40PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:13, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 03:46:07PM +0200, Alexander Graf wrote: On 22.04.2010, at 12:33, Joerg Roedel wrote: The patch introducing nested nmi handling had a bug. The

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Alexander Graf
On 23.04.2010, at 16:22, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 04:19:40PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:13, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 03:46:07PM +0200, Alexander Graf wrote: On 22.04.2010, at 12:33, Joerg Roedel wrote: The patch

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Joerg Roedel
On Fri, Apr 23, 2010 at 04:24:54PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:22, Joerg Roedel wrote: No, nested_svm_nmi runs in atomic context where we can't emulate a vmexit. We set exit_required and emulate the vmexit later. So we modify the L2 rflags and then trigger a

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Alexander Graf
On 23.04.2010, at 16:31, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 04:24:54PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:22, Joerg Roedel wrote: No, nested_svm_nmi runs in atomic context where we can't emulate a vmexit. We set exit_required and emulate the vmexit later. So we

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Joerg Roedel
On Fri, Apr 23, 2010 at 04:42:52PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:31, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 04:24:54PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:22, Joerg Roedel wrote: No, nested_svm_nmi runs in atomic context where we can't

Re: [PATCH 1/8] KVM: SVM: Fix nested nmi handling

2010-04-23 Thread Alexander Graf
On 23.04.2010, at 16:51, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 04:42:52PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:31, Joerg Roedel wrote: On Fri, Apr 23, 2010 at 04:24:54PM +0200, Alexander Graf wrote: On 23.04.2010, at 16:22, Joerg Roedel wrote: No, nested_svm_nmi