Re: [PATCH v1 0/5] KVM-UNIT-TESTS: Hyper-V SynIC timers test

2015-11-27 Thread Paolo Bonzini


On 26/11/2015 17:29, Andrey Smetanin wrote:
> The test checks Hyper-V SynIC timers functionality.
> The test runs on every vCPU and performs start/stop
> of periodic/one-shot timers (with period=1ms) and checks
> validity of received expiration messages in appropriate
> ISR's.
> 
> Signed-off-by: Andrey Smetanin 
> Reviewed-by: Roman Kagan 
> CC: Paolo Bonzini 
> CC: Marcelo Tosatti 
> CC: Roman Kagan 
> CC: Denis V. Lunev 
> CC: qemu-de...@nongnu.org
> 
> Andrey Smetanin (5):
>   lib/x86: Added Hyper-V MSR's availability bits into msr.h
>   lib/x86: Added HV_X64_MSR_TIME_REF_COUNT value into msr.h
>   lib/x86: Added Hyper-V SynIC timers MSR's values
>   lib/x86: Make free_page() available to call
>   x86: Hyper-V SynIC timers test

In addition to my comments on 5/5, can you make instead a hyperv.h file
with all that you need in the two testcases?

Paolo

>  config/config-x86-common.mak |   4 +-
>  lib/x86/msr.h|  19 ++
>  lib/x86/vm.h |   1 +
>  x86/hyperv_stimer.c  | 500 
> +++
>  x86/hyperv_synic.c   |   2 +-
>  x86/unittests.cfg|   5 +
>  6 files changed, 529 insertions(+), 2 deletions(-)
>  create mode 100644 x86/hyperv_stimer.c
> 
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v1 0/5] KVM-UNIT-TESTS: Hyper-V SynIC timers test

2015-11-27 Thread Andrey Smetanin



On 11/27/2015 02:17 PM, Paolo Bonzini wrote:



On 26/11/2015 17:29, Andrey Smetanin wrote:

The test checks Hyper-V SynIC timers functionality.
The test runs on every vCPU and performs start/stop
of periodic/one-shot timers (with period=1ms) and checks
validity of received expiration messages in appropriate
ISR's.

Signed-off-by: Andrey Smetanin 
Reviewed-by: Roman Kagan 
CC: Paolo Bonzini 
CC: Marcelo Tosatti 
CC: Roman Kagan 
CC: Denis V. Lunev 
CC: qemu-de...@nongnu.org

Andrey Smetanin (5):
   lib/x86: Added Hyper-V MSR's availability bits into msr.h
   lib/x86: Added HV_X64_MSR_TIME_REF_COUNT value into msr.h
   lib/x86: Added Hyper-V SynIC timers MSR's values
   lib/x86: Make free_page() available to call
   x86: Hyper-V SynIC timers test


In addition to my comments on 5/5, can you make instead a hyperv.h file
with all that you need in the two testcases?

Yes, I'll do it. Thanks!


Paolo


  config/config-x86-common.mak |   4 +-
  lib/x86/msr.h|  19 ++
  lib/x86/vm.h |   1 +
  x86/hyperv_stimer.c  | 500 +++
  x86/hyperv_synic.c   |   2 +-
  x86/unittests.cfg|   5 +
  6 files changed, 529 insertions(+), 2 deletions(-)
  create mode 100644 x86/hyperv_stimer.c


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html